[#16015 Fix]: Cleaning up unused code from snappi_fixtures by selldinesh · Pull Request #16026 · sonic-net/sonic-mgmt

selldinesh · 2024-12-11T22:52:39Z

Description of PR

Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and
get_multidut_snappi_ports from snappi_fixtures.py
Fixes # (issue)
#16015

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

How did you do it?

deleted the code

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2024-12-11T22:52:42Z

/azp run

linux-foundation-easycla · 2024-12-11T22:52:43Z

The committers listed above are authorized under a signed CLA.

✅ login: selldinesh / name: Dinesh Kumar Sellappan (4ffacc9)

azure-pipelines · 2024-12-11T22:52:53Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2024-12-11T23:30:18Z

@amitpawar12 for viz.

sdszhang · 2024-12-12T13:27:22Z

@selldinesh can you sign the CLA?

sdszhang

LGTM

mssonicbld · 2025-01-09T19:06:14Z

/azp run

azure-pipelines · 2025-01-09T19:06:27Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-09T19:43:54Z

/azp run

azure-pipelines · 2025-01-09T19:44:08Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-09T20:13:27Z

/azp run

azure-pipelines · 2025-01-09T20:13:39Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-09T21:38:15Z

/azp run

azure-pipelines · 2025-01-09T21:38:28Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-09T21:54:17Z

/azp run

azure-pipelines · 2025-01-09T21:54:30Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-09T22:47:40Z

/azp run

azure-pipelines · 2025-01-09T22:47:52Z

Azure Pipelines successfully started running 1 pipeline(s).

…onic-net#16026) Description of PR Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and get_multidut_snappi_ports from snappi_fixtures.py Fixes # (issue) sonic-net#16015 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? How did you do it? deleted the code co-authorized by: jianquanye@microsoft.com

mssonicbld · 2025-01-14T03:43:04Z

Cherry-pick PR to 202411: #16506

Description of PR Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and get_multidut_snappi_ports from snappi_fixtures.py Fixes # (issue) #16015 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? How did you do it? deleted the code co-authorized by: jianquanye@microsoft.com

…onic-net#16026) Description of PR Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and get_multidut_snappi_ports from snappi_fixtures.py Fixes # (issue) sonic-net#16015 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? How did you do it? deleted the code co-authorized by: jianquanye@microsoft.com

[sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures (sonic-net#16026) Description of PR Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and get_multidut_snappi_ports from snappi_fixtures.py Fixes # (issue) sonic-net#16015 Approach What is the motivation for this PR? How did you do it? deleted the code co-authorized by: jianquanye@microsoft.com

…onic-net#16026) Description of PR Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and get_multidut_snappi_ports from snappi_fixtures.py Fixes # (issue) sonic-net#16015 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? How did you do it? deleted the code co-authorized by: jianquanye@microsoft.com

Merge 202405 branch in as of 12:23pm 20/01/2025 AEST b118611 (HEAD -> merge/202405) Use alternate check for reboot for T2 after reboot with REBOOT_TYPE_POWEROFF (sonic-net#16348) 0e0e898 flap interface after sfp reset (sonic-net#16375) 41e2b2f Temporarily skip lpmode test for some transceivers with known issue (sonic-net#16547) de60273 [Snappi] Infra changes for new PFC-ECN testcases. (sonic-net#13864) 7b357f5 [Snappi] New testcases for PFC-ECN. (sonic-net#13865) 3523a7f [Snappi]: PFC - Mixed Speed testcases (sonic-net#14122) 3754f2a sonic-mgmt: Fix namespace issues for qos tests on T2 single ASIC (sonic-net#15708) 21f6526 [sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures (sonic-net#16026) d8f23be Correcting client arguments to dynamically_compensate_leakout (sonic-net#16169) 3c47107 [sanity_check][bgp] Enhance sanity check recover for bgp default route missing (sonic-net#16357) 37352b8 Eliminate cross-feature dependency from macsec module (sonic-net#15617) 4f33b0d (pub_upstream/202405) [202405][dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic (sonic-net#16494) (sonic-net#16567)

…onic-net#16026) Description of PR Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and get_multidut_snappi_ports from snappi_fixtures.py Fixes # (issue) sonic-net#16015 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? How did you do it? deleted the code co-authorized by: jianquanye@microsoft.com

[sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures

4ffacc9

sdszhang approved these changes Dec 13, 2024

View reviewed changes

sdszhang added chassis IXIA_CHASSIS labels Jan 8, 2025

selldinesh force-pushed the pr_cleanup branch from a8be96e to ae54669 Compare January 9, 2025 21:54

selldinesh force-pushed the pr_cleanup branch from ae54669 to 4ffacc9 Compare January 9, 2025 22:47

sdszhang added Request for 202411 branch Request for msft-202405 Branch labels Jan 14, 2025

yejianquan merged commit baf48c2 into sonic-net:master Jan 14, 2025

yejianquan added Approved for 202411 branch Approved for msft-202405 Branch labels Jan 14, 2025

mssonicbld added the Created PR to 202411 branch label Jan 14, 2025

mssonicbld mentioned this pull request Jan 14, 2025

[action] [PR:16026] [#16015 Fix]: Cleaning up unused code from snappi_fixtures #16506

Merged

8 tasks

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels Jan 14, 2025

sdszhang mentioned this pull request Jan 14, 2025

[Snappi] cleanup unused code after PR #14127 #16015

Closed

Javier-Tan added Included in msft-202405 Branch Request for msft-202405 Branch and removed Request for msft-202405 Branch labels Jan 16, 2025

Conversation

selldinesh commented Dec 11, 2024

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Dec 11, 2024

Uh oh!

linux-foundation-easycla bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Dec 11, 2024

Uh oh!

sdszhang commented Dec 11, 2024

Uh oh!

sdszhang commented Dec 12, 2024

Uh oh!

sdszhang left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Jan 9, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2025

Uh oh!

mssonicbld commented Jan 9, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2025

Uh oh!

mssonicbld commented Jan 9, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2025

Uh oh!

mssonicbld commented Jan 9, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2025

Uh oh!

mssonicbld commented Jan 9, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2025

Uh oh!

mssonicbld commented Jan 9, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2025

Uh oh!

mssonicbld commented Jan 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

linux-foundation-easycla bot commented Dec 11, 2024 •

edited

Loading