[sanity_check][bgp] Enhance sanity check recover for bgp default route missing#16357
Merged
StormLiangMS merged 3 commits intosonic-net:masterfrom Jan 8, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yaqiangz
force-pushed
the
azure-master_bgp_sanity
branch
from
de33174 to
211097f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hi @StormLiangMS could you please help to review this PR? |
StormLiangMS
approved these changes
Jan 8, 2025
Collaborator
StormLiangMS
left a comment
StormLiangMS
left a comment
There was a problem hiding this comment.
LGTM, and thanks for fix this flaky issue.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 8, 2025
…e missing (sonic-net#16357) What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check
Collaborator
|
Cherry-pick PR to 202411: #16386 |
8 tasks
yaqiangz
added
Request for 202405 branch
and removed
Request for 202311 branch
Request for 202405 branch
labels
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jan 9, 2025
…e missing (sonic-net#16357) What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check
mssonicbld
pushed a commit
that referenced
this pull request
Jan 13, 2025
…e missing (#16357) What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Javier-Tan
added
Included in msft-202405 Branch
and removed
Request for msft-202405 Branch
labels
yejianquan
pushed a commit
to yejianquan/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
…e missing (sonic-net#16357) What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check
yejianquan
added a commit
to yejianquan/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
[sanity_check][bgp] Enhance sanity check recover for bgp default route missing (sonic-net#16357) Approach What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check co-authorized by: jianquanye@microsoft.com
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
…e missing (sonic-net#16357) What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
Merge 202405 branch in as of 12:23pm 20/01/2025 AEST b118611 (HEAD -> merge/202405) Use alternate check for reboot for T2 after reboot with REBOOT_TYPE_POWEROFF (sonic-net#16348) 0e0e898 flap interface after sfp reset (sonic-net#16375) 41e2b2f Temporarily skip lpmode test for some transceivers with known issue (sonic-net#16547) de60273 [Snappi] Infra changes for new PFC-ECN testcases. (sonic-net#13864) 7b357f5 [Snappi] New testcases for PFC-ECN. (sonic-net#13865) 3523a7f [Snappi]: PFC - Mixed Speed testcases (sonic-net#14122) 3754f2a sonic-mgmt: Fix namespace issues for qos tests on T2 single ASIC (sonic-net#15708) 21f6526 [sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures (sonic-net#16026) d8f23be Correcting client arguments to dynamically_compensate_leakout (sonic-net#16169) 3c47107 [sanity_check][bgp] Enhance sanity check recover for bgp default route missing (sonic-net#16357) 37352b8 Eliminate cross-feature dependency from macsec module (sonic-net#15617) 4f33b0d (pub_upstream/202405) [202405][dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic (sonic-net#16494) (sonic-net#16567)
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…e missing (sonic-net#16357) What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check.
How did you do it?
How did you verify/test it?
Run test with sanity check
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation