CoPP Neighbor Miss Trap and Other Enhancements HLD#1943
Merged
prsunny merged 2 commits intosonic-net:masterfrom Jun 9, 2025
Merged
CoPP Neighbor Miss Trap and Other Enhancements HLD#1943prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
|
@prabhataravind , please review as this should cover subnet trap. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
prsunny
reviewed
Mar 25, 2025
Contributor
|
Can you please test trap flow counters with this feature? |
rminnikanti
added a commit
to rminnikanti/sonic-swss
that referenced
this pull request
Apr 22, 2025
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
Contributor
|
@prabhataravind , Merging the HLD. Please review #3624 |
rminnikanti
added a commit
to rminnikanti/sonic-utilities
that referenced
this pull request
Jun 10, 2025
What I did: CoPP show commands: * show copp configuration * show copp configuration detailed --trapid <trap_id> * show copp configuration detailed --group <group> Added UT for the CLI commands. HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti
added a commit
to rminnikanti/sonic-swss
that referenced
this pull request
Jun 10, 2025
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db * Added UT and mock tests HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
saiarcot895
added a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Jun 10, 2025
* [vslib]: hostif enum capability query API support 1. vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP, attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE 2. Added UT for SAI_OBJECT_TYPE_HOSTIF_TRAP 3. Added UT for SAI_OBJECT_TYPE_DEBUG_COUNTER HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]> * Added comments in unittest Added unittest comments to satisfy PR checks. Signed-off-by: Ravi Minnikanti <[email protected]> --------- Signed-off-by: Ravi Minnikanti <[email protected]> Co-authored-by: Saikrishna Arcot <[email protected]>
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jun 13, 2025
What I did: Added CoPP show commands: show copp configuration show copp configuration detailed --trapid <trap_id> show copp configuration detailed --group <group> Added UT for the CLI commands. Why I did it Details in HLD: sonic-net/SONiC#1943 How to verify it Verified with UT
rminnikanti
added a commit
to rminnikanti/sonic-swss
that referenced
this pull request
Jun 17, 2025
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db * Added UT and mock tests HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti
added a commit
to rminnikanti/sonic-swss
that referenced
this pull request
Jun 22, 2025
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db * Added UT and mock tests HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
What I did: Added CoPP show commands: show copp configuration show copp configuration detailed --trapid <trap_id> show copp configuration detailed --group <group> Added UT for the CLI commands. Why I did it Details in HLD: sonic-net/SONiC#1943 How to verify it Verified with UT
rminnikanti
added a commit
to rminnikanti/sonic-swss
that referenced
this pull request
Jun 26, 2025
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db * Added UT and mock tests HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
mssonicbld
added a commit
to mssonicbld/sonic-swss-common
that referenced
this pull request
Jul 3, 2025
**What I did** Added the `COPP_TRAP_CAPABILITY_TABLE` table definition to schema.h **Why I did it** Details in HLD: sonic-net/SONiC#1943 **How I verified it** NA **Details if related** Signed-off-by: Ravi Minnikanti <[email protected]>
mssonicbld
added a commit
to mssonicbld/sonic-sairedis
that referenced
this pull request
Jul 3, 2025
**What I did** vslib support for hostif trap object - SAI_OBJECT_TYPE_HOSTIF_TRAP, attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE Implementation returns all trap types as supported. **Why I did** Details in HLD: sonic-net/SONiC#1943 **How I verified it** Verified with UT and DVS Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti
added a commit
to rminnikanti/sonic-utilities
that referenced
this pull request
Jul 7, 2025
What I did: CoPP show commands: * show copp configuration * show copp configuration detailed --trapid <trap_id> * show copp configuration detailed --group <group> Added UT for the CLI commands. HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti
added a commit
to rminnikanti/sonic-swss
that referenced
this pull request
Jul 7, 2025
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db * Added UT and mock tests HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
yejianquan
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jul 9, 2025
What I did: CoPP show commands: * show copp configuration * show copp configuration detailed --trapid <trap_id> * show copp configuration detailed --group <group> Added UT for the CLI commands. HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti
added a commit
to rminnikanti/sonic-swss
that referenced
this pull request
Jul 11, 2025
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db * Added UT and mock tests HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
yejianquan
added a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Jul 12, 2025
**What I did** vslib support for hostif trap object - SAI_OBJECT_TYPE_HOSTIF_TRAP, attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE Implementation returns all trap types as supported. **Why I did** Details in HLD: sonic-net/SONiC#1943 **How I verified it** Verified with UT and DVS Signed-off-by: Ravi Minnikanti <[email protected]> Co-authored-by: Jianquan Ye <[email protected]>
mssonicbld
added a commit
to sonic-net/sonic-swss-common
that referenced
this pull request
Jul 14, 2025
**What I did** Added the `COPP_TRAP_CAPABILITY_TABLE` table definition to schema.h **Why I did it** Details in HLD: sonic-net/SONiC#1943 **How I verified it** NA **Details if related** Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti
added a commit
to rminnikanti/sonic-swss
that referenced
this pull request
Jul 15, 2025
What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db * Added UT and mock tests HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
rminnikanti
added a commit
to rminnikanti/sonic-buildimage
that referenced
this pull request
Jul 15, 2025
Added copp default configuration for neighbor_miss trap type to copp_cfg.json HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <[email protected]>
prsunny
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jul 15, 2025
* [orchagent] CoPP neighbor miss trap and enhancements What I did * Added neighbor_miss trap type support * enum capability query for hostif trap type * Added trap hw_status field to state_db * Added UT and mock tests HLD: sonic-net/SONiC#1943
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HLD for CoPP Neighbor Miss Trap type support and Other CoPP Enhancements
What we did:
PRs: