Skip to content

[copp_cfg.json]: Default config for neighbor_miss trap type#22406

Merged
kperumalbfn merged 1 commit intosonic-net:masterfrom
rminnikanti:neighbor_miss
Jul 18, 2025
Merged

[copp_cfg.json]: Default config for neighbor_miss trap type#22406
kperumalbfn merged 1 commit intosonic-net:masterfrom
rminnikanti:neighbor_miss

Conversation

@rminnikanti
Copy link
Copy Markdown
Contributor

@rminnikanti rminnikanti commented Apr 22, 2025

Added default configuration for neighbor_miss trap type to copp_cfg.json

Why I did it

Refer HLD: sonic-net/SONiC#1943

How I did it

How to verify it

To verify the neighbor_miss trap configuration, related PRs of sonic-net/SONiC#1943 are required and vendor SAI should support this trap type.

Which release branch to backport (provide reason below if selected)

  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411

Description for the changelog

copp default configuration for neighbor_miss trap type

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Ravi Minnikanti [email protected]

@rminnikanti rminnikanti requested a review from lguohan as a code owner April 22, 2025 17:41
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Apr 22, 2025

@prabhataravind for review, signoff for merge

@prsunny prsunny requested a review from prabhataravind April 22, 2025 23:54
Copy link
Copy Markdown
Contributor

@prabhataravind prabhataravind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@rminnikanti
Copy link
Copy Markdown
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@rminnikanti
Copy link
Copy Markdown
Contributor Author

@qiluo-msft, checks failing on this PR are unrelated. This PR only has json change to copp_cfg.j2.

PR check failure log:

Error type: RUN_TEST_CASE_FAILED
Error message: qos/test_qos_dscp_mapping.py|||2 failed for RUN_TEST_CASE_FAILED, stop whole test plan

Can you please take a look?

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@rminnikanti
Copy link
Copy Markdown
Contributor Author

rminnikanti commented Jun 16, 2025

/azpw run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 22406 in repo sonic-net/sonic-buildimage

@rminnikanti
Copy link
Copy Markdown
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Added copp default configuration for neighbor_miss trap type
to copp_cfg.json

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@rminnikanti
Copy link
Copy Markdown
Contributor Author

PR checks are failing because of a PTF testcase error which is not related to this PR changes.

acl/test_acl.py:918: 
failed on setup with &quot;RuntimeError: Thread worker aborted: AttributeError(&quot;'ApplyResult' object has no attribute '_condition'&quot;)&quot

@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Jul 16, 2025

@rminnikanti , kindly keep the commit history and not force-push

@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Jul 16, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@rminnikanti
Copy link
Copy Markdown
Contributor Author

@prsunny force pushes you see are only rebase's. No new code changes are made since the PR is created.

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #23395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants