[orchagent] CoPP neighbor miss trap and enhancements

[rminnikanti]

What I did

• Added neighbor_miss trap type support
• enum capability query for hostif trap type in copporch.cpp
• Added hw_status field to COPP_TRAP_TABLE table in state_db

Why I did it

HLD: sonic-net/SONiC#1943

How I verified it

Verified with test_copp.py DVS test
Verified on Sonic switch with and without neighbor_miss trap support by vendorSAI.

Details if related

PR Dependencies:

• Depends on: [schema]: Add CoPP trap capability table to state_db sonic-swss-common#1010
• Depends on: [vslib]: hostif enum capability query API support sonic-sairedis#1586

Signed-off-by: Ravi Minnikanti [email protected]

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rminnikanti]

@prsunny @kcudnik PR check compilation failing because of dependency on sonic-swss-common PR - sonic-net/sonic-swss-common#1010
Can you please suggest if there is a way to run PR checks with dependencies?

[kcudnik]

there is no way to run code without dependency checked in, technically you could modify azure pipeline to pull swss common at specific commit, compile it and then build against that, but this is not standard approach and it would break everything else

[rminnikanti]

Thank you for your response. Can the dependency PR be merged to allow the PR checks to run on this PR?
dependency - sonic-net/sonic-swss-common#1010

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[msherif1234]

do you need to also update mock test json file https://github.com/sonic-net/sonic-swss/pull/3646/files#diff-7a754ce5badfcc6c7f079baabf320c731eab42f9f98194df7ec53eccb0e6064bR106 ?

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rminnikanti]

do you need to also update mock test json file https://github.com/sonic-net/sonic-swss/pull/3646/files#diff-7a754ce5badfcc6c7f079baabf320c731eab42f9f98194df7ec53eccb0e6064bR106 ?

mock_tests/copp_cfg.json is being used in coppmgrd UT.
I still updated it as suggested for consistency.

[msherif1234]

I created PR under sonic-mgmt to add new CoPP configs for this new trap type PTAL
sonic-net/sonic-mgmt#18480

[rminnikanti]

I created PR under sonic-mgmt to add new CoPP configs for this new trap type PTAL sonic-net/sonic-mgmt#18480

@msherif1234 I have sonic-mgmt implemented for this HLD which already covers validating neighbor_miss traffic with default 200PPS if the neighbor_miss trap is supported sonic-net/sonic-mgmt#18326

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[prsunny]

@rminnikanti , please don't force-push any commit. Reviewers prefer to understand the incremental changes

[rminnikanti]

@prsunny Sure, noted. Any new changes I made different commits for viz.

[prsunny]

@dgsudharsan , can you please approve?

[prsunny]

@prabhataravind for viz

[yejianquan]

@prsunny @prabhataravind please suggest whether it's safe to go to 202505,
If so I prefer so take it, since most changes for Neighbor miss trap(sonic-net/SONiC#1943) has been in 202505 branch

[Aravind-Subbaroyan]

@prsunny - can this be cherry-picked for 202411?

[prsunny]

@prsunny - can this be cherry-picked for 202411?

unfortunately no. 202411 is already a stable branch and this feature tests are still not yet merged

[mssonicbld]

Cherry-pick PR to 202505: #3811

[mssonicbld]

Cherry-pick PR to msft-202506: Azure/sonic-swss.msft#138