[copp]: Added CoPP show configuration commands#3863
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Jun 13, 2025
Merged
[copp]: Added CoPP show configuration commands#3863qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rminnikanti
force-pushed
the
neighbor_miss
branch
from
2ac2edc to
39341d3
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@prabhataravind @prsunny please review. |
dgsudharsan
approved these changes
May 2, 2025
rminnikanti
force-pushed
the
neighbor_miss
branch
from
39341d3 to
b6a90e0
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rminnikanti
force-pushed
the
neighbor_miss
branch
from
b6a90e0 to
379adaf
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run Azure.sonic-utilities |
|
Commenter does not have sufficient privileges for PR 3863 in repo sonic-net/sonic-utilities |
rminnikanti
force-pushed
the
neighbor_miss
branch
from
379adaf to
b69ff1d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@rminnikanti , can you please resolve conflicts |
Contributor
|
Also, please share a command output as per description template |
prsunny
previously approved these changes
Jun 9, 2025
Contributor
prsunny
left a comment
prsunny
left a comment
There was a problem hiding this comment.
lgtm, @qiluo-msft to merge
Contributor
|
@rminnikanti Could you resolve conflict? |
What I did: CoPP show commands: * show copp configuration * show copp configuration detailed --trapid <trap_id> * show copp configuration detailed --group <group> Added UT for the CLI commands. HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>
rminnikanti
force-pushed
the
neighbor_miss
branch
from
b69ff1d to
a3b4be1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
@qiluo-msft Done. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds CoPP (Control Plane Policing) CLI support, including show configuration and detailed views, with unit tests and documentation updates.
- Introduces
show copp configurationandshow copp configuration detailedcommands - Adds mock DB entries and unit tests for the new CLI paths
- Updates dump plugin mapping and command reference documentation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/mock_tables/state_db.json | Added mock state entries for CoPP traps |
| tests/mock_tables/config_db.json | Added mock CONFIG_DB entries for CoPP groups/traps |
| tests/copp_test.py | New pytest cases for CoPP CLI |
| tests/copp_input/mock_config/mock_copp_cfg.json | Mock CoPP JSON config data |
| show/main.py | Registered copp commands in main CLI |
| show/copp.py | Implemented CoPP show commands and merge logic |
| dump/plugins/copp.py | Added neighbor_miss trap mapping |
| doc/Command-Reference.md | Documented CoPP commands in command reference |
Comments suppressed due to low confidence (3)
doc/Command-Reference.md:14900
- The sample output uses lowercase
queuehere, but the CLI printsQueuewith an uppercase Q. Update the doc to match the actual output.
queue....................... 1
doc/Command-Reference.md:14910
- The sample uses
Oper Status, but the implementation printsHW Status. Align the documentation to showHW Statusfor consistency.
Oper Status................. installed
show/copp.py:149
- There is no unit test covering the
FileNotFoundErrorbranch when the config file is missing. Add a test to verify that the warning is printed as expected.
with open(COPP_INIT_CFG_JSON_FILE, 'r') as file:
Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>
auto-merge was automatically disabled
June 10, 2025 14:47
Head branch was pushed to by a user without write access
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Jun 13, 2025
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
What I did: Added CoPP show commands: show copp configuration show copp configuration detailed --trapid <trap_id> show copp configuration detailed --group <group> Added UT for the CLI commands. Why I did it Details in HLD: sonic-net/SONiC#1943 How to verify it Verified with UT
Contributor
|
Hi @rminnikanti , please create PR and fix conflict to 202505 branch |
Contributor
Author
|
@yejianquan, created PR for 202505 #3955 |
yejianquan
added
Included in 202505 Branch
and removed
Cherry Pick Conflict_202505
labels
Contributor
Author
|
@qiluo-msft @yejianquan to have this PR included in sonic master image we need to update the git submodule of src/sonic-utilties in sonic-buildimage. Can we please update submodule of src/sonic-utilities in master branch? This will help sonic-mgmt PR of this feature. Below is the last submodule update of sonic-utilities in sonic-buildimage master: commit c19ece7106b30d941aff8774f1742486eebc1ec3
Author: mssonicbld <79238446+mssonicbld@users.noreply.github.com>
Date: Thu May 22 19:01:49 2025 +0800
[submodule] Update submodule sonic-utilities to the latest HEAD automatically (#22614) |
YairRaviv
pushed a commit
to YairRaviv/sonic-utilities
that referenced
this pull request
Jan 12, 2026
What I did: Added CoPP show commands: show copp configuration show copp configuration detailed --trapid <trap_id> show copp configuration detailed --group <group> Added UT for the CLI commands. Why I did it Details in HLD: sonic-net/SONiC#1943 How to verify it Verified with UT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
Added CoPP show commands:
Added UT for the CLI commands.
Why I did it
Details in HLD: sonic-net/SONiC#1943
How to verify it
Verified with UT
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Signed-off-by: Ravi Minnikanti rminnikanti@marvell.com