[CoPP]: Added neighbor_miss trap verification and cli test by rminnikanti · Pull Request #18326 · sonic-net/sonic-mgmt

rminnikanti · 2025-05-10T03:23:25Z

Description of PR

Added/updated tests to cover sonic-net/SONiC#1943
If the platform supports the CoPP neighbor_miss trap, verify that VLAN subnet traffic is policed under the neighbor_miss CoPP (200 PPS). If not, verify it under the existing default CoPP logic.
CoPP trap capability of platform is determined by COPP_TRAP_CAPABILITY_TABLE in STATE_DB.
Added a test case to verify the show copp configuration CLI output - test_verify_copp_configuration_cli.
Updated the existing test case to validate the trap installation status for the trap being verified with traffic.

Summary:
Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

sonic-net/SONiC#1943

How did you do it?

Modified update_copp_config.py script to not modify neighbor_miss trap CBS/CIR values if the platform supports this trap type. This way verification will be able to verify neighbor_miss trap is policed under its own copp but not under default trap.
Updated existing tests to verify the installation status of the trap before performing traffic test for the respective trap.

How did you verify/test it?

Tested by running copp component tests on T0 topology on marvell-teralynx platform.

copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-ARP]PASSED                               [  5%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-IP2ME]PASSED                             [ 10%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-SNMP]PASSED                              [ 15%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-SSH]PASSED                               [ 20%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-DHCP]PASSED                              [ 25%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-DHCP6]PASSED                             [ 30%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-BGP]PASSED                               [ 35%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-LACP]PASSED                              [ 40%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-LLDP]PASSED                              [ 45%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-UDLD] PASSED                             [ 50%]
copp/test_copp.py::TestCOPP::test_policer[str-marvell-01-Default]PASSED                           [ 55%]
copp/test_copp.py::TestCOPP::test_trap_neighbor_miss[4-VlanSubnet-str-marvell-01]PASSED           [ 60%]
copp/test_copp.py::TestCOPP::test_trap_neighbor_miss[4-VlanSubnetIPinIP-str-marvell-01]PASSED     [ 65%]
copp/test_copp.py::TestCOPP::test_trap_neighbor_miss[6-VlanSubnet-str-marvell-01]PASSED           [ 70%]
copp/test_copp.py::TestCOPP::test_trap_neighbor_miss[6-VlanSubnetIPinIP-str-marvell-01]PASSED     [ 75%]
copp/test_copp.py::TestCOPP::test_add_new_trap[str-marvell-01]PASSED                              [ 80%]
copp/test_copp.py::TestCOPP::test_remove_trap[str-marvell-01-delete_feature_entry]PASSED          [ 85%]
copp/test_copp.py::TestCOPP::test_remove_trap[str-marvell-01-disable_feature_status]PASSED        [ 90%]
copp/test_copp.py::TestCOPP::test_trap_config_save_after_reboot[str-marvell-01]PASSED             [ 95%]
copp/test_copp.py::test_verify_copp_configuration_cli[str-marvell-01] PASSED                      [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-05-10T03:23:33Z

/azp run

azure-pipelines · 2025-05-10T03:23:44Z

Azure Pipelines successfully started running 1 pipeline(s).

rminnikanti · 2025-05-10T03:25:12Z

@prabhataravind @prsunny, please review.

Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>

mssonicbld · 2025-07-16T05:40:29Z

/azp run

azure-pipelines · 2025-07-16T05:40:43Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny

lgtm

prsunny · 2025-07-16T17:33:37Z

@rminnikanti , can you check the test failure? As I understand, this test should fall back to old behavior if new traps are not installed, hence should not have a dependency on (sonic-net/sonic-buildimage#22406)

rminnikanti · 2025-07-16T18:03:10Z

@prsunny, tests also verify the new show copp configuration CLI and also uses new STATE_DB capability table.

CLI command is not yet part of the master image:

PR failures log:

_ansible_no_log = None
stdout =
stderr =
Usage: show [OPTIONS] COMMAND [ARGS]...
Try "show -h" for help.

Error: No such command "copp".

FAILED

sonic-utilities submodule in master doesn't yet include the new copp CLI changes.
sonic-utilities submodule in master is last updated on May 22nd, CoPP CLI merged on Jun 13th.

commit c19ece7106b30d941aff8774f1742486eebc1ec3
Author: mssonicbld <79238446+mssonicbld@users.noreply.github.com>
Date:   Thu May 22 19:01:49 2025 +0800

    [submodule] Update submodule sonic-utilities to the latest HEAD automatically (#22614)

nhe-NV · 2025-07-24T14:15:54Z

Should it also be part of the 202505 branch, right? I don't see the label for 202505

rminnikanti · 2025-07-25T05:33:21Z

@nhe-NV I edited the PR description and added 202505 backport from my side.

rminnikanti · 2025-07-25T05:34:21Z

/azpw run Azure.sonic-mgmt

mssonicbld · 2025-07-25T05:34:23Z

/AzurePipelines run Azure.sonic-mgmt

azure-pipelines · 2025-07-25T05:34:36Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>

mssonicbld · 2025-07-25T17:36:10Z

/azp run

azure-pipelines · 2025-07-25T17:36:23Z

Azure Pipelines successfully started running 1 pipeline(s).

rminnikanti · 2025-07-26T01:32:46Z

@prsunny @prabhataravind PR checks are passing now. Can you please review

prsunny · 2025-08-04T18:21:50Z

@prabhataravind , would you review and signoff?

nhe-NV · 2025-08-05T01:18:47Z

@prabhataravind , would you review and signoff?

I see the label for 202505 is not added, I will add it in case not missing

tests/copp/test_copp.py

prabhataravind · 2025-08-07T22:57:03Z

@dgsudharsan could you pls review as well, esp from Nvidia platform pov?

prsunny · 2025-08-11T21:44:34Z

@StormLiangMS , would you help with merge?

ZhaohuiS · 2025-08-12T05:40:04Z

test_copp passed on VKM testbed.

rminnikanti · 2025-08-24T01:54:58Z

@yxieca can you please help merge this PR?

…#18326) * Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>

mssonicbld · 2025-08-26T06:18:28Z

Cherry-pick PR to 202505: #20397

* Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>

…#18326) * Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>

…#18326) * Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…#18326) * Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com> Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…#18326) * Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…#18326) * Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>

…#18326) * Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…#18326) * Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>

…#18326) * Added neighbor_miss trap and copp cli tests Added test for the following - If the platform supports neighbor_miss trap, verify Vlan subnet traffic is policed under neighbor_miss copp - Verify 'show copp configuration' CLI output - Verify trap installation status of configured traps Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>

rminnikanti mentioned this pull request May 20, 2025

[orchagent] CoPP neighbor miss trap and enhancements sonic-net/sonic-swss#3624

Merged

msherif1234 mentioned this pull request May 20, 2025

Update CoPP configs to handle neighbor_miss trap type #18480

Closed

11 tasks

prsunny requested a review from prabhataravind June 9, 2025 22:21

rminnikanti force-pushed the neighbor_miss branch from 28a7098 to 4403df2 Compare July 16, 2025 05:40

prsunny mentioned this pull request Jul 16, 2025

CoPP Neighbor Miss Trap and Other Enhancements HLD sonic-net/SONiC#1943

Merged

prsunny requested a review from dgsudharsan July 16, 2025 17:30

prsunny previously approved these changes Jul 16, 2025

View reviewed changes

Perform trap installed check only if feature is enabled

be4bfc4

Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>

rminnikanti dismissed prsunny’s stale review via be4bfc4 July 25, 2025 17:36

rminnikanti requested a review from prsunny July 26, 2025 01:31

nhe-NV added the Request for 202505 branch label Aug 5, 2025

prabhataravind reviewed Aug 5, 2025

View reviewed changes

tests/copp/test_copp.py Show resolved Hide resolved

prabhataravind requested a review from ZhaohuiS August 7, 2025 19:49

prabhataravind approved these changes Aug 7, 2025

View reviewed changes

prsunny approved these changes Aug 11, 2025

View reviewed changes

ZhaohuiS approved these changes Aug 12, 2025

View reviewed changes

yxieca merged commit 663f59a into sonic-net:master Aug 25, 2025
19 checks passed

yejianquan added the Approved for 202505 branch label Aug 26, 2025

mssonicbld added the Created PR to 202505 branch label Aug 26, 2025

mssonicbld mentioned this pull request Aug 26, 2025

[action] [PR:18326] [CoPP]: Added neighbor_miss trap verification and cli test #20397

Merged

12 tasks

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels Aug 27, 2025

nhe-NV mentioned this pull request Sep 10, 2025

Stabilize the copp test case #20595

Merged

11 tasks

This was referenced Oct 2, 2025

Bug: COPP 'test_policer' tests fails for multi-asic duts #20896

Open

Fix for parse_show_copp_configuration for multi-asic dut #20946

Merged

Conversation

rminnikanti commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented May 10, 2025

Uh oh!

azure-pipelines bot commented May 10, 2025

Uh oh!

rminnikanti commented May 10, 2025

Uh oh!

mssonicbld commented Jul 16, 2025

Uh oh!

azure-pipelines bot commented Jul 16, 2025

Uh oh!

prsunny left a comment

Choose a reason for hiding this comment

Uh oh!

prsunny commented Jul 16, 2025

Uh oh!

rminnikanti commented Jul 16, 2025

Uh oh!

nhe-NV commented Jul 24, 2025

Uh oh!

rminnikanti commented Jul 25, 2025

Uh oh!

rminnikanti commented Jul 25, 2025

Uh oh!

mssonicbld commented Jul 25, 2025

Uh oh!

azure-pipelines bot commented Jul 25, 2025

Uh oh!

mssonicbld commented Jul 25, 2025

Uh oh!

azure-pipelines bot commented Jul 25, 2025

Uh oh!

rminnikanti commented Jul 26, 2025

Uh oh!

prsunny commented Aug 4, 2025

Uh oh!

nhe-NV commented Aug 5, 2025

Uh oh!

Uh oh!

prabhataravind commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prsunny commented Aug 11, 2025

Uh oh!

ZhaohuiS commented Aug 12, 2025

Uh oh!

rminnikanti commented Aug 24, 2025

Uh oh!

Uh oh!

mssonicbld commented Aug 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rminnikanti commented May 10, 2025 •

edited

Loading

prabhataravind commented Aug 7, 2025 •

edited

Loading