Adds `BlockNumberProvider` in multisig, proxy and nft pallets by gupnik · Pull Request #5723 · paritytech/polkadot-sdk

gupnik · 2024-09-16T11:24:23Z

Step in #3268

This PR adds the ability for these pallets to specify their source of the block number. This is useful when these pallets are migrated from the relay chain to a parachain and vice versa.

This change is backwards compatible:

If the BlockNumberProvider continues to use the system pallet's block number
When a pallet deployed on the relay chain is moved to a parachain, but still uses the relay chain's block number

However, we would need migrations if the deployed pallets are upgraded on an existing parachain, and the BlockNumberProvider uses the relay chain block number.

substrate/frame/proxy/src/lib.rs

substrate/frame/multisig/src/lib.rs

prdoc/pr_5723.prdoc

kianenigma

LGTM as abstractions to add, excluding the possible need for a migration.

…polkadot-sdk into gupnik/block-number-provider

kianenigma · 2024-10-29T10:54:29Z

The metric through which you have chosen to migrate Nft pallet seems wrong btw -- this pallet is not priority as it is not on the relay chain.

…ik/block-number-provider

substrate/frame/multisig/src/lib.rs

substrate/frame/proxy/src/lib.rs

gui1117

Looks good to me,
Using different types make the change easier to check.

…tech#5723) Step in paritytech#3268 This PR adds the ability for these pallets to specify their source of the block number. This is useful when these pallets are migrated from the relay chain to a parachain and vice versa. This change is backwards compatible: 1. If the `BlockNumberProvider` continues to use the system pallet's block number 2. When a pallet deployed on the relay chain is moved to a parachain, but still uses the relay chain's block number However, we would need migrations if the deployed pallets are upgraded on an existing parachain, and the `BlockNumberProvider` uses the relay chain block number. --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Upstream commit: paritytech/polkadot-sdk#5723

paritytech/polkadot-sdk#6338 paritytech/polkadot-sdk#6623 paritytech/polkadot-sdk#6621 paritytech/polkadot-sdk#6715 paritytech/polkadot-sdk#6446 paritytech/polkadot-sdk#7441 paritytech/polkadot-sdk#5723

Upstream commit: paritytech/polkadot-sdk#5723

* fix visibility for pallet_nfts types used as call arguments Changes from the commit: paritytech/polkadot-sdk#3634 * [pallet-nfts, pallet_uniques] - Expose private structs Changes made from upstream: paritytech/polkadot-sdk#6087 * Adds BlockNumberProvider in multisig, proxy and nft pallets Upstream commit: paritytech/polkadot-sdk#5723 * Removed unused dependencies (partial progress) Upstream commit: paritytech/polkadot-sdk#7329 * implement DecodeWithMemTracking for frame pallets paritytech/polkadot-sdk#7598 * chore: bump pallet-nfts version to 34.1.0 * feat: adds BlockNumberProvider in nonfungbiles pallet * chore: update lock file of pop-api to sync nfts * chore: BlockNumberProvider for devnet nonfungibles * chore: fix benchmarking to use new BlockNumberFor * chore: revert changes * fix: missing DecodeWithMemTracking * chore: update weights of pallets * refactor(nonfungibles): remove unused BlockNumberProvider type * chore: remove unused Zero trait * chore: revert non-relevant changes * chore: revert non-relevant changes This reverts commit 182486a. * chore: benchmarking replace with BlockNumberProvider * chore(pallet-nfts): update weights

* fix visibility for pallet_nfts types used as call arguments Changes from the commit: paritytech/polkadot-sdk#3634 * [pallet-nfts, pallet_uniques] - Expose private structs Changes made from upstream: paritytech/polkadot-sdk#6087 * Adds BlockNumberProvider in multisig, proxy and nft pallets Upstream commit: paritytech/polkadot-sdk#5723 * Removed unused dependencies (partial progress) Upstream commit: paritytech/polkadot-sdk#7329 * implement DecodeWithMemTracking for frame pallets paritytech/polkadot-sdk#7598 * chore: bump pallet-nfts version to 34.1.0 * feat: adds BlockNumberProvider in nonfungbiles pallet * chore: update lock file of pop-api to sync nfts * chore: BlockNumberProvider for devnet nonfungibles * chore: fix benchmarking to use new BlockNumberFor * chore: revert changes * fix: missing DecodeWithMemTracking * chore: update weights of pallets * refactor(nonfungibles): remove unused BlockNumberProvider type * chore: remove unused Zero trait * chore: revert non-relevant changes * chore: revert non-relevant changes This reverts commit 182486a53e92a12db77fb53b5f9661c9a06b9762. * chore: benchmarking replace with BlockNumberProvider * chore(pallet-nfts): update weights

## Polkadot upgrade 2503 In this PR, we upgrade form Polkadot SDK 2412 to Polkadot SDK 2503. In order to upgrade the SDK we need to upgrade some dependencies : StorageHub and frontier simultaneously. ## What changes ### Trivial changes * paritytech/polkadot-sdk#7634 -> The new trait is required in all the pallets using scale encoding. * paritytech/polkadot-sdk#7043 -> Remove deprecated `sp-std` and replace with `alloc` or `core`. * paritytech/polkadot-sdk#6140 -> Accurate weight reclaim with frame_system::WeightReclaim ### Breaking changes * paritytech/polkadot-sdk#2072 -> There is a change in `pallet-referenda`. Now, the tracks are retrieved as a list of `Track`s. Also, the names of the tracks might have some trailing null values (`\0`). This means display representation of the tracks' names must be sanitized. * paritytech/polkadot-sdk#5723 -> adds the ability for these pallets to specify their source of the block number. This is useful when these pallets are migrated from the relay chain to a parachain and vice versa. (Not entirely sure it is breaking as it is being marked as backward compatible). * paritytech/polkadot-sdk#6338 -> Update Referenda to Support Block Number Provider ### Notable changes * paritytech/polkadot-sdk#5703 -> Not changes required in the codebase but impact fastSync mode. Should improve testing. * paritytech/polkadot-sdk#5842 -> Removes `libp2p` types in authority-discovery, and replace them with network backend agnostic types from `sc-network-types`. The `sc-network` interface is therefore updated accordingly. ## What changes in Frontier * polkadot-evm/frontier#1693 -> Add support for EIP 7702 which has been enable with Pectra. This EIP add a new field `AuthorizationList` in Ethereum transaction. Changes example : ```rust #[test] fn validate_transaction_fails_on_filtered_call() { ... pallet_evm::Call::<Runtime>::call { source: H160::default(), target: H160::default(), input: Vec::new(), value: sp_core::U256::zero(), gas_limit: 21000, max_fee_per_gas: sp_core::U256::zero(), max_priority_fee_per_gas: Some(sp_core::U256::zero()), nonce: None, access_list: Vec::new(), authorization_list: Vec::new(), } .into(), ``` ## ⚠️ Breaking Changes ⚠️ * Upgrade to Stirage hub v0.5.1 * Support for Ethereum latest upgrade (txs now have the `authoriation_list` for support EIP 7702) --------- Co-authored-by: Steve Degosserie <723552+stiiifff@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Uses BlockNumberProvider in multisig, proxy and nft palletS

53ae2c8

gupnik added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Sep 16, 2024

gupnik requested a review from a team as a code owner September 16, 2024 11:24

gupnik added 3 commits September 16, 2024 17:10

Minor fix

71a5e19

FMT

88629ee

Adds PrDoc

b46576f

franciscoaguirre reviewed Sep 17, 2024

View reviewed changes

substrate/frame/proxy/src/lib.rs Show resolved Hide resolved

kianenigma reviewed Sep 17, 2024

View reviewed changes

substrate/frame/multisig/src/lib.rs Show resolved Hide resolved

kianenigma reviewed Sep 17, 2024

View reviewed changes

prdoc/pr_5723.prdoc Outdated Show resolved Hide resolved

kianenigma mentioned this pull request Oct 3, 2024

[FRAME] Prepare pallets for dynamic block durations #3268

Closed

kianenigma approved these changes Oct 24, 2024

View reviewed changes

Merge branch 'master' into gupnik/block-number-provider

8753b81

gupnik mentioned this pull request Oct 26, 2024

Deprecate frame_system::block_number #6245

Open

gupnik added 2 commits October 26, 2024 11:35

Updates PrDoc

2d11e95

Merge branch 'gupnik/block-number-provider' of github.com:paritytech/…

7dbae6c

…polkadot-sdk into gupnik/block-number-provider

gupnik mentioned this pull request Oct 30, 2024

Adds BlockNumberProvider in alliance, collective and identity pallets #6282

Open

Merge branch 'master' of github.com:paritytech/polkadot-sdk into gupn…

f6c4862

…ik/block-number-provider

kianenigma reviewed Oct 30, 2024

View reviewed changes

substrate/frame/multisig/src/lib.rs Show resolved Hide resolved

gui1117 reviewed Nov 4, 2024

View reviewed changes

substrate/frame/proxy/src/lib.rs Outdated Show resolved Hide resolved

gui1117 mentioned this pull request Nov 6, 2024

Update Scheduler to Support Relay Chain Block Number Provider #6362

Closed

2 tasks

gupnik added 2 commits November 9, 2024 18:42

Addresses review comments

b5c361f

Fixes proxy benchmarks

9fac833

gupnik requested a review from gui1117 November 13, 2024 04:47

gui1117 approved these changes Nov 13, 2024

View reviewed changes

gui1117 mentioned this pull request Nov 13, 2024

Make pallet-recovery supports BlockNumberProvider #6446

Merged

pgherveou approved these changes Nov 15, 2024

View reviewed changes

Merge branch 'master' into gupnik/block-number-provider

2c16860

xermicus approved these changes Nov 21, 2024

View reviewed changes

gupnik added this pull request to the merge queue Nov 22, 2024

This was referenced Apr 23, 2025

chore: sync pop-node with polkadot-stable2503 r0gue-io/pop-node#514

Merged

chore: BlockNumberProvider for multisig, nfts & proxy r0gue-io/pop-node#517

Merged

chungquantin added a commit to r0gue-io/pop-node that referenced this pull request May 5, 2025

Adds BlockNumberProvider in multisig, proxy and nft pallets

5e79ddd

Upstream commit: paritytech/polkadot-sdk#5723

chungquantin added a commit to r0gue-io/pop-node that referenced this pull request May 5, 2025

Adds BlockNumberProvider in multisig, proxy and nft pallets

560ebbc

Upstream commit: paritytech/polkadot-sdk#5723

chungquantin added a commit to r0gue-io/pop-node that referenced this pull request May 7, 2025

Adds BlockNumberProvider in multisig, proxy and nft pallets

0c2e093

Upstream commit: paritytech/polkadot-sdk#5723

chungquantin added a commit to r0gue-io/pop-node that referenced this pull request May 7, 2025

Adds BlockNumberProvider in multisig, proxy and nft pallets

ae39b94

Upstream commit: paritytech/polkadot-sdk#5723

chungquantin added a commit to r0gue-io/pop-node that referenced this pull request May 7, 2025

Adds BlockNumberProvider in multisig, proxy and nft pallets

88ecea6

Upstream commit: paritytech/polkadot-sdk#5723

ggwpez mentioned this pull request Jun 4, 2025

Bump to stable2503 polkadot-fellows/runtimes#711

Merged

7 tasks

github-actions bot mentioned this pull request Jun 10, 2025

Update polkadot-sdk from stable2412 to stable2503 moondance-labs/tanssi#1087

Closed

This was referenced Jun 16, 2025

chore: upgrade to stable2503 r0gue-io/assets-parachain#17

Merged

chore: upgrade to 2503 r0gue-io/contracts-parachain#16

Merged

This was referenced Jul 16, 2025

Update polkadot-sdk from stable2412 to stable2503 moonbeam-foundation/moonbeam#3362

Closed

Update polkadot-sdk from stable2412 to stable2503-7 moonbeam-foundation/moonbeam#3363

Closed

This was referenced Dec 12, 2025

chore: Update to PolkadotSDK release stable2503 AstarNetwork/Astar#1571

Closed

chore: Update to PolkadotSDK release stable2506 AstarNetwork/Astar#1572

Merged

undercover-cactus mentioned this pull request Mar 3, 2026

feat: upgrade to polkadot SDK 2503 datahaven-xyz/datahaven#444

Merged

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 20, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

pgherveou added this to [preview] release tracker Mar 23, 2026

github-project-automation bot moved this to Done in [preview] release tracker Mar 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds `BlockNumberProvider` in multisig, proxy and nft pallets#5723

Adds `BlockNumberProvider` in multisig, proxy and nft pallets#5723
gupnik merged 11 commits intomasterfrom
gupnik/block-number-provider

gupnik commented Sep 16, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kianenigma left a comment

Uh oh!

kianenigma commented Oct 29, 2024

Uh oh!

Uh oh!

Uh oh!

gui1117 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

gupnik commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

kianenigma commented Oct 29, 2024

Uh oh!

Uh oh!

Uh oh!

gui1117 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

gupnik commented Sep 16, 2024 •

edited

Loading