feat: upgrade to polkadot SDK 2503 by undercover-cactus · Pull Request #444 · datahaven-xyz/datahaven

undercover-cactus · 2026-02-12T22:35:59Z

Polkadot upgrade 2503

In this PR, we upgrade form Polkadot SDK 2412 to Polkadot SDK 2503. In order to upgrade the SDK we need to upgrade some dependencies : StorageHub and frontier simultaneously.

What changes

Trivial changes

derive DecodeWithMemTracking for RuntimeCall paritytech/polkadot-sdk#7634 -> The new trait is required in all the pallets using scale encoding.
Remove usage of sp-std from Substrate paritytech/polkadot-sdk#7043 -> Remove deprecated sp-std and replace with alloc or core.
Implement cumulus StorageWeightReclaim as wrapping transaction extension + frame system ReclaimWeight paritytech/polkadot-sdk#6140 -> Accurate weight reclaim with frame_system::WeightReclaim

Breaking changes

Change pallet referenda TracksInfo::tracks to return an iterator paritytech/polkadot-sdk#2072 -> There is a change in pallet-referenda. Now, the tracks are retrieved as a list of Tracks. Also, the names of the tracks might have some trailing null values (\0). This means display representation of the tracks' names must be sanitized.
Adds BlockNumberProvider in multisig, proxy and nft pallets paritytech/polkadot-sdk#5723 -> adds the ability for these pallets to specify their source of the block number. This is useful when these pallets are migrated from the relay chain to a parachain and vice versa. (Not entirely sure it is breaking as it is being marked as backward compatible).
Update Pallet Referenda to support Block Number Provider paritytech/polkadot-sdk#6338 -> Update Referenda to Support Block Number Provider

Notable changes

Support block gap created by fast sync paritytech/polkadot-sdk#5703 -> Not changes required in the codebase but impact fastSync mode. Should improve testing.
Get rid of libp2p dependency in sc-authority-discovery paritytech/polkadot-sdk#5842 -> Removes libp2p types in authority-discovery, and replace them with network backend agnostic types from sc-network-types. The sc-network interface is therefore updated accordingly.

What changes in Frontier

Add support for EIP-7702 polkadot-evm/frontier#1693 -> Add support for EIP 7702 which has been enable with Pectra. This EIP add a new field AuthorizationList in Ethereum transaction.

Changes example :

#[test]
fn validate_transaction_fails_on_filtered_call() {
...
            pallet_evm::Call::<Runtime>::call {
                source: H160::default(),
                target: H160::default(),
                input: Vec::new(),
                value: sp_core::U256::zero(),
                gas_limit: 21000,
                max_fee_per_gas: sp_core::U256::zero(),
                max_priority_fee_per_gas: Some(sp_core::U256::zero()),
                nonce: None,
                access_list: Vec::new(),
                authorization_list: Vec::new(),
            }
            .into(),

⚠️ Breaking Changes ⚠️

Upgrade to Stirage hub v0.5.1
Support for Ethereum latest upgrade (txs now have the authoriation_list for support EIP 7702)

- Migrate pallet_referenda Track API: TracksInfo::tracks() now returns an Iterator<Item = Cow<Track>> instead of &[(Id, TrackInfo)]. Use .collect(), track.id / track.info.* access pattern throughout. - Convert TrackInfo.name from &str to [u8; 128] (str_array), using from_utf8() + trim_end_matches('\0') for string comparisons. - Add authorization_list field to pallet_evm::Call::call (EIP-7702). - Simplify ExistentialDeposit config: remove cfg split, use single ED=0 now that PR #7379 handles benchmarks with zero ED. - Re-enable pallet_identity benchmark_helper and benchmark entries across mainnet and stagenet runtimes. - Update pallet_collective alias comments re: PR #6435 status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…benchmark helper method.

operator/runtime/mainnet/src/lib.rs

operator/runtime/mainnet/src/configs/storagehub/client.rs

operator/precompiles/referenda/src/mock.rs

gonzamontiel · 2026-03-23T12:01:15Z

operator/runtime/mainnet/src/configs/governance/tracks.rs

+                let Ok(track_name) = from_utf8(&track.info.name) else {
+                    return false;
+                };
+                let track_name = track_name.trim_end_matches('\0');


I think this will break pallet referenda origin parsing, see my comment there.

I have picked this up from moonbeam (see https://github.com/moonbeam-foundation/moonbeam/blob/fee53eec42fa4ec134120c3cde321fd6a546a6f6/runtime/moonbase/src/governance/tracks.rs#L161).

How do you think it will break ?

the concern is that track_info.name is now a fixed-size NUL-padded array. So
str::from_utf8(&track_info.name) gives a string that can still contain trailing \0. Then GovOrigin::from_str(...) tries to parse that raw padded string, and for custom origins, "general_admin\0..." will not match the expected "general_admin".

So the precompile may fail to build the correct custom origin from a padded name, and therefore revert before dispatching to pallet_referenda

gonzamontiel · 2026-03-23T12:03:28Z

operator/precompiles/referenda/src/lib.rs

-                        .in_field("trackId")
-                })?
-                .into()
+            GovOrigin::from_str(str::from_utf8(&track_info.name).map_err(|_| {


This now parses the full buffer directly, but the runtime track code trims trailing \0, so this may fail when trying to decode values with trailing 0's.

I have added a call to trim_end_matches('\0') for the name. Having it in both places make sure we have properly sanitize the string.

operator/node/src/service.rs

gonzamontiel

I think most of the PR is okay, there are some potentially failing tests, we will see when the CI is green. After the requested changes are explained / fixed, I'll approve.

undercover-cactus self-assigned this Mar 3, 2026

undercover-cactus and others added 9 commits March 18, 2026 10:49

upgrade to polkadot SDK 2503

1fe1aa6

runtime compiling

68afceb

chore: ♻ Update Cargo.lock

b4b2c97

fix: 🔨 Get node to compile

0628796

fix: 🔨 Add missing imports, and temporarily remove Identity pallet's …

4a7c7c4

…benchmark helper method.

chore: ♻ cargo fmt

7f0aa68

fix Cargo.lock

f8fea11

add WeightReclaim transaction extension to all runtimes

b04d2e6

undercover-cactus force-pushed the feat/update-2503 branch from 3d62f36 to b04d2e6 Compare March 18, 2026 10:10

use main branhc of storage hub; compiling;

e36c1e1

stiiifff reviewed Mar 19, 2026

View reviewed changes

operator/runtime/mainnet/src/lib.rs Show resolved Hide resolved

operator/runtime/mainnet/src/configs/storagehub/client.rs Show resolved Hide resolved

use tag v0.5.0 for storage hub

0a0beab

gonzamontiel reviewed Mar 23, 2026

View reviewed changes

operator/node/src/service.rs Outdated Show resolved Hide resolved

update tag to v0.5.1

ede641c

gonzamontiel requested changes Mar 23, 2026

View reviewed changes

undercover-cactus added 7 commits March 23, 2026 13:53

remove the TODO waiting for the storageHub PR; uncomment the code;

69982e1

fix benchmark build

262657a

generated new files

b64ee71

fixing all the compilations errors for mock

6605faf

update gas for txs in test

dcddeee

fix proxy tests

0fdf0a2

fix moonwall tests (new ethereum tx struct)

8aca431

Merge branch 'main' into feat/update-2503

eabba59

undercover-cactus requested a review from gonzamontiel March 24, 2026 13:27

undercover-cactus marked this pull request as ready for review March 25, 2026 15:33

undercover-cactus requested review from a team as code owners March 25, 2026 15:33

undercover-cactus requested a review from snowmead March 25, 2026 19:34

gonzamontiel approved these changes Mar 26, 2026

View reviewed changes

gonzamontiel merged commit b8cc9ee into main Mar 26, 2026
27 of 29 checks passed

gonzamontiel deleted the feat/update-2503 branch March 26, 2026 09:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade to polkadot SDK 2503#444

feat: upgrade to polkadot SDK 2503#444
gonzamontiel merged 20 commits intomainfrom
feat/update-2503

undercover-cactus commented Feb 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gonzamontiel Mar 23, 2026

Uh oh!

undercover-cactus Mar 24, 2026

Uh oh!

gonzamontiel Mar 25, 2026

Uh oh!

gonzamontiel Mar 25, 2026

Uh oh!

gonzamontiel Mar 23, 2026

Uh oh!

undercover-cactus Mar 25, 2026

Uh oh!

Uh oh!

gonzamontiel left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

undercover-cactus commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Polkadot upgrade 2503

What changes

Trivial changes

Breaking changes

Notable changes

What changes in Frontier

⚠️ Breaking Changes ⚠️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gonzamontiel Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

undercover-cactus Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

gonzamontiel Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

gonzamontiel Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

gonzamontiel Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

undercover-cactus Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gonzamontiel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

undercover-cactus commented Feb 12, 2026 •

edited

Loading