Make pallet-recovery supports BlockNumberProvider

[aurexav]

Make pallet-recovery supports BlockNumberProvider.

Part of #6297.

---

Polkadot address: 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y

[gui1117]

It fails to compile:

   Using forklift, storage: gcs, compressor: zstd-3, uploader threads: 6
error[E0277]: the trait bound `ActiveRecovery<<<T as pallet::Config>::BlockNumberProvider as sp_runtime::traits::BlockNumberProvider>::BlockNumber, <<T as pallet::Config>::Currency as frame_support::traits::Currency<<T as frame_system::Config>::AccountId>>::Balance, _>: EncodeLike<ActiveRecovery<<<<T as frame_system::Config>::Block as sp_runtime::traits::Block>::Header as sp_runtime::traits::Header>::Number, <<T as pallet::Config>::Currency as frame_support::traits::Currency<<T as frame_system::Config>::AccountId>>::Balance, BoundedVec<<T as frame_system::Config>::AccountId, <T as pallet::Config>::MaxFriends>>>` is not satisfied
   --> substrate/frame/recovery/src/lib.rs:525:50
    |
525 |             <ActiveRecoveries<T>>::insert(&account, &who, recovery_status);
    |             -----------------------------                 ^^^^^^^^^^^^^^^ the trait `EncodeLike<ActiveRecovery<<<<T as frame_system::Config>::Block as sp_runtime::traits::Block>::Header as sp_runtime::traits::Header>::Number, <<T as pallet::Config>::Currency as frame_support::traits::Currency<<T as frame_system::Config>::AccountId>>::Balance, BoundedVec<<T as frame_system::Config>::AccountId, <T as pallet::Config>::MaxFriends>>>` is not implemented for `ActiveRecovery<<<T as Config>::BlockNumberProvider as BlockNumberProvider>::BlockNumber, ..., ...>`
    |             |
    |             required by a bound introduced by this call
    |
    = help: the trait `EncodeLike` is implemented for `ActiveRecovery<<<T as pallet::Config>::BlockNumberProvider as sp_runtime::traits::BlockNumberProvider>::BlockNumber, <<T as pallet::Config>::Currency as frame_support::traits::Currency<<T as frame_system::Config>::AccountId>>::Balance, _>`
note: required by a bound in `frame_support::pallet_prelude::StorageDoubleMap::<Prefix, Hasher1, Key1, Hasher2, Key2, Value, QueryKind, OnEmpty, MaxValues>::insert`
   --> /__w/polkadot-sdk/polkadot-sdk/substrate/frame/support/src/storage/types/double_map.rs:296:9
    |
292 |     pub fn insert<KArg1, KArg2, VArg>(k1: KArg1, k2: KArg2, val: VArg)
    |            ------ required by a bound in this associated function
...
296 |         VArg: EncodeLike<Value>,
    |               ^^^^^^^^^^^^^^^^^ required by this bound in `StorageDoubleMap::<Prefix, Hasher1, Key1, Hasher2, Key2, Value, QueryKind, OnEmpty, MaxValues>::insert`

error[E0308]: mismatched types
   --> substrate/frame/recovery/src/lib.rs:610:40
    |
610 |             ensure!(recoverable_block_number <= current_block_number, Error::<T>::DelayPeriod);
    |                                                 ^^^^^^^^^^^^^^^^^^^^ expected `sp_runtime::traits::Header::Number`, found `sp_runtime::traits::BlockNumberProvider::BlockNumber`
    |
    = note: expected associated type `<<<T as frame_system::Config>::Block as sp_runtime::traits::Block>::Header as sp_runtime::traits::Header>::Number`
               found associated type `<<T as pallet::Config>::BlockNumberProvider as sp_runtime::traits::BlockNumberProvider>::BlockNumber`
    = note: an associated type was expected, but a different one was found

[gui1117]

/cmd prdoc --audience runtime_dev --bump major

[gui1117]

ideally the prdoc should mention what is changing, and in which context a migration is needed.

You can take example on another PR:

      This PR adds the ability for the Scheduler pallet to specify its source of the block number.
      This is needed for the scheduler pallet to work on a parachain which does not produce blocks
      on a regular schedule, thus can use the relay chain as a block provider. Because blocks are
      not produced regularly, we cannot make the assumption that the block number increases 
      monotonically, and thus have a new logic via a `Queue` to handle multiple blocks with valid 
      agenda passed between them.

      This change only needs a migration for the `Queue`:
      1. If the `BlockNumberProvider` continues to use the system pallet's block number
      2. When a pallet deployed on the relay chain is moved to a parachain, but still uses the 
      relay chain's block number

      However, we would need migrations if the deployed pallets are upgraded on an existing parachain,
      and the `BlockNumberProvider` uses the relay chain block number.