Add support for EIP-7702 by manuelmauro · Pull Request #1693 · polkadot-evm/frontier

manuelmauro · 2025-06-16T15:48:01Z

Description

Adds support for EIP-7702.

librelois

The proof_size_base_cost function (in impl TransactionData) should be updated to account for the size of authorization_list. Remember that the proof size limit should reflect the entire transaction’s byte size.

manuelmauro · 2025-07-14T13:04:41Z

I am happy to add the BlockWrapper in a separate PR 👍

sorpaas

CI is failing due to a typo only triggered in try_runtime cfg. Otherwise LGTM.

RomarQ · 2025-07-15T11:58:05Z

Will try to have a final review in the next 2 hours.

RomarQ

Added a few remarks, the remaining changes look good to me.

client/rpc/src/eth/transaction.rs

frame/ethereum/src/lib.rs

frame/evm/src/runner/stack.rs

primitives/ethereum/src/lib.rs

…for in the encoding

template/runtime/src/lib.rs

frame/evm/src/lib.rs

RomarQ

We need to validate the signatures in the authorization_list

frame/evm/src/lib.rs

frame/ethereum/src/lib.rs

sorpaas · 2025-07-18T14:24:24Z

@librelois Do you still want to do another review or are the issues you mentioned already addressed?

librelois · 2025-07-22T12:34:51Z

@sorpaas I was just about to respond to your comment today. It appears my comments has been addressed correctly, but I would be grateful if you could allow a bit more time next time.

* feat: ✨ add support for EIP-7702 * chore: ⬆️ use temporary fork of ethereum crate * feat: ✨ update to ethereum crate v3 structs * feat: ⬆️ upgrade evm crate * feat: ✨ add EIP-7702 support to RPC * fix: ⬆️ upgrade evm crate * feat: ✨ upgrade evm crate * feat: ✨ add EIP-7702 support to EthDevSigner * test: 🔥 temporarily remove EIP-7702 tests * feat: ⬆️ upgrade ethereum and evm crates * fix: 🐛 properly convert authorization list to evm's data type * fix: 🔥 fix logic * fix: 🐛 fix usage of authorization list throughout the codebase * style: 🎨 fmt * fix: ⬆️ upgrade evm * refactor: 🚨 silence lint error * style: 🎨 fmt * refactor: 🔥 remove unused imports * fix: ⬆️ upgrade config to pectra * fix: 🐛 manage API v6 case in Eth::call * fix: 🐛 manage API v6 case in Eth::estimate_gas * chore: 🔥 remove unused dependencies * test: ✅ add unit tests for EIP-7702 * test: ✅ add integration tests for EIP-7702 * style: 🎨 fmt * refactor: ⬆️ upgrade evm crate * fix: 🐛 propagate std feature to ethereum-ext * refactor: ♻️ use upstream evm crate * refactor: 🔥 remove ethereum-ext temporary dependency * style: 🎨 format TS code * refactor: ♻️ ignore lint warning * feat: ⬆️ upgrade evm/ethereum dependencies * feat: ✨ add validation error for EIP-7702 empty authorization list * style: 🎨 format code * refactor: 🔥 remove unused const * test: 🧪 add failing test for EIP-7702 authoriations * fix: 🐛 fix authorization creation in tests * refactor: ⬆️ use evm release on crates.io * style: 🎨 format code * feat: ✨ record delegation resolution external operation * revert: 🔥 remove old TODOs * fix: 🐛 add missing semicolon * feat: add comprehensive EIP-7702 validation at Substrate level - Add chain ID validation for authorization tuples - Add maximum authorization list size validation (255 items) - Add new error types: InvalidAuthorizationChainId, AuthorizationListTooLarge - Map new validation errors to appropriate EVM pallet errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * feat: add documentation for EIP-7702 gas costs and improve error handling - Add documentation about EIP-7702 gas costs in runtime estimation - Add error handling for new validation errors in Ethereum pallet - Add user-friendly error messages for EIP-7702 validation failures in RPC 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: 🐛 add missing case in error conversion * fix: correct authorization signature format in TypeScript tests - Fix EIP-7702 authorization signature creation to use proper spec format - Use magic byte 0x05 and RLP encoding as per EIP-7702 specification - Rust tests already used correct format, only TS tests needed fixing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * test: add comprehensive EIP-7702 validation tests - Add tests for empty authorization list validation - Add tests for authorization list size limits (max 255 items) - Add tests for chain ID validation (must be 0 or match transaction chain ID) - Add tests for valid authorization list scenarios - Add tests for non-EIP-7702 transaction validation skipping - Add missing InvalidAuthorizationChainId error variant and mapping 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: add comprehensive documentation for EIP-7702 validation functions - Add detailed documentation for with_eip7702_authorization_list function - Document validation rules and responsibilities split between Substrate/EVM levels - Add comprehensive error type documentation with security rationale - Include usage examples and parameter descriptions - Clarify the distinction between Substrate and EVM-level validation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * revert: 🔥 remove InvalidAuthorizationChainId validation error * docs: 📝 digest docs * style: 🎨 format * fix: 🐛 account for authentication list items in the proof size base cost * refactor: ♻️ return error for unsupported API version * refactor: ♻️ refactor TransactionRequest to TransactionMessage conversion * style: 🎨 format * refactor: ♻️ reduce code duplication * fix: 🐛 fix delegation code length in test * test: ✅ actually check gas consumption in EIP-7702 * fix: 🐛 treat DelegationResolution just as a second AddressCodeRead * refactor: 🎨 use serde rename_all directive * docs: 📝 improve AuthorizationListTooLarge docs * fix: 🐛 add EIP7702 variant to TxType * feat: ⬆️ upgrade ethers.js * test: 🐛 first revision of the integration tests for EIP-7702 * fix: 🐛 second revision of the integration tests for EIP-7702 * fix: 🐛 upgrade evm * fix: 🐛 fix authorization nonce in test * feat: ✨ add EthereumBlockWrapper * refactor: 🔥 remove CurrentBlock v0 to v2 migrations * refactor: ♻️ clippy * refactor: ♻️ refactor EthereumBlockWrapper decoding * revert: ⏪ restore block migration functions * Revert "refactor: ♻️ refactor EthereumBlockWrapper decoding" This reverts commit c0923c7. * Revert "refactor: ♻️ clippy" This reverts commit 6521a03. * Revert "feat: ✨ add EthereumBlockWrapper" This reverts commit 88b8fbc. * feat: ✨ add block v2 to v3 migration methods * fix: 🐛 fix typo in post_migrate_block_v3 * refactor: ♻️ rename size_limit to create_contract_limit * fix: 🐛 account for empty authorization list cost in template * fix: 🐛 the base cost for the authorization list is already accounted for in the encoding * revert: ⏪ block v2 is still a valid block v3 * fix: 🔒 validate authorizations signatures on extrinsic call * fix: 🐛 add ethereum/std to std feature * fix: 🔒 properly validate authorization list --------- Co-authored-by: Claude <noreply@anthropic.com>

This reverts commit 54140ae

This reverts commit 54140ae.

## Polkadot upgrade 2503 In this PR, we upgrade form Polkadot SDK 2412 to Polkadot SDK 2503. In order to upgrade the SDK we need to upgrade some dependencies : StorageHub and frontier simultaneously. ## What changes ### Trivial changes * paritytech/polkadot-sdk#7634 -> The new trait is required in all the pallets using scale encoding. * paritytech/polkadot-sdk#7043 -> Remove deprecated `sp-std` and replace with `alloc` or `core`. * paritytech/polkadot-sdk#6140 -> Accurate weight reclaim with frame_system::WeightReclaim ### Breaking changes * paritytech/polkadot-sdk#2072 -> There is a change in `pallet-referenda`. Now, the tracks are retrieved as a list of `Track`s. Also, the names of the tracks might have some trailing null values (`\0`). This means display representation of the tracks' names must be sanitized. * paritytech/polkadot-sdk#5723 -> adds the ability for these pallets to specify their source of the block number. This is useful when these pallets are migrated from the relay chain to a parachain and vice versa. (Not entirely sure it is breaking as it is being marked as backward compatible). * paritytech/polkadot-sdk#6338 -> Update Referenda to Support Block Number Provider ### Notable changes * paritytech/polkadot-sdk#5703 -> Not changes required in the codebase but impact fastSync mode. Should improve testing. * paritytech/polkadot-sdk#5842 -> Removes `libp2p` types in authority-discovery, and replace them with network backend agnostic types from `sc-network-types`. The `sc-network` interface is therefore updated accordingly. ## What changes in Frontier * polkadot-evm/frontier#1693 -> Add support for EIP 7702 which has been enable with Pectra. This EIP add a new field `AuthorizationList` in Ethereum transaction. Changes example : ```rust #[test] fn validate_transaction_fails_on_filtered_call() { ... pallet_evm::Call::<Runtime>::call { source: H160::default(), target: H160::default(), input: Vec::new(), value: sp_core::U256::zero(), gas_limit: 21000, max_fee_per_gas: sp_core::U256::zero(), max_priority_fee_per_gas: Some(sp_core::U256::zero()), nonce: None, access_list: Vec::new(), authorization_list: Vec::new(), } .into(), ``` ## ⚠️ Breaking Changes ⚠️ * Upgrade to Stirage hub v0.5.1 * Support for Ethereum latest upgrade (txs now have the `authoriation_list` for support EIP 7702) --------- Co-authored-by: Steve Degosserie <723552+stiiifff@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

manuelmauro added 16 commits June 16, 2025 18:47

feat: ✨ add support for EIP-7702

9a9c15e

chore: ⬆️ use temporary fork of ethereum crate

0442de2

feat: ✨ update to ethereum crate v3 structs

d80ad5a

feat: ⬆️ upgrade evm crate

26cdab5

feat: ✨ add EIP-7702 support to RPC

1ad8f0d

fix: ⬆️ upgrade evm crate

45aabc6

feat: ✨ upgrade evm crate

c63ef24

feat: ✨ add EIP-7702 support to EthDevSigner

b2b7c6d

test: 🔥 temporarily remove EIP-7702 tests

e7671b1

feat: ⬆️ upgrade ethereum and evm crates

a1a929e

fix: 🐛 properly convert authorization list to evm's data type

c509516

fix: 🔥 fix logic

464cad8

fix: 🐛 fix usage of authorization list throughout the codebase

02fff86

style: 🎨 fmt

fc1c136

fix: ⬆️ upgrade evm

fffc7d1

refactor: 🚨 silence lint error

ceb6bf2

manuelmauro mentioned this pull request Jun 23, 2025

Ongoing development of the Pectra Upgrade #1648

Closed

manuelmauro added 6 commits June 23, 2025 12:27

style: 🎨 fmt

3d11e21

refactor: 🔥 remove unused imports

b4a3c46

fix: ⬆️ upgrade config to pectra

9b022f3

fix: 🐛 manage API v6 case in Eth::call

a7381c3

fix: 🐛 manage API v6 case in Eth::estimate_gas

f0a03de

chore: 🔥 remove unused dependencies

72717e2

manuelmauro marked this pull request as ready for review June 23, 2025 15:14

manuelmauro requested a review from sorpaas as a code owner June 23, 2025 15:14

librelois requested changes Jun 25, 2025

View reviewed changes

manuelmauro added 4 commits June 25, 2025 16:51

test: ✅ add unit tests for EIP-7702

a62f9a7

test: ✅ add integration tests for EIP-7702

2939872

style: 🎨 fmt

8822105

refactor: ⬆️ upgrade evm crate

3a10ef0

manuelmauro mentioned this pull request Jul 14, 2025

Add BlockWrapper #1712

Open

sorpaas reviewed Jul 14, 2025

View reviewed changes

fix: 🐛 fix typo in post_migrate_block_v3

6cf7f34

sorpaas approved these changes Jul 15, 2025

View reviewed changes

RomarQ reviewed Jul 15, 2025

View reviewed changes

manuelmauro added 3 commits July 16, 2025 11:12

refactor: ♻️ rename size_limit to create_contract_limit

4100b04

fix: 🐛 account for empty authorization list cost in template

53fdd34

fix: 🐛 the base cost for the authorization list is already accounted …

a4fec3c

…for in the encoding

manuelmauro mentioned this pull request Jul 16, 2025

Do not require additional cost calculations for access and authorization list in template code #1713

Open

RomarQ reviewed Jul 16, 2025

View reviewed changes

template/runtime/src/lib.rs Outdated Show resolved Hide resolved

RomarQ reviewed Jul 16, 2025

View reviewed changes

frame/evm/src/lib.rs Outdated Show resolved Hide resolved

RomarQ requested changes Jul 16, 2025

View reviewed changes

frame/evm/src/lib.rs Outdated Show resolved Hide resolved

manuelmauro added 3 commits July 16, 2025 12:15

revert: ⏪ block v2 is still a valid block v3

6f7541d

fix: 🔒 validate authorizations signatures on extrinsic call

aa6b207

fix: 🐛 add ethereum/std to std feature

d13400a

RomarQ reviewed Jul 16, 2025

View reviewed changes

frame/ethereum/src/lib.rs Outdated Show resolved Hide resolved

fix: 🔒 properly validate authorization list

fe647c2

RomarQ approved these changes Jul 16, 2025

View reviewed changes

manuelmauro requested a review from librelois July 16, 2025 10:58

sorpaas merged commit 54140ae into polkadot-evm:master Jul 22, 2025
4 checks passed

manuelmauro mentioned this pull request Jul 29, 2025

Add support for EIP-7702 moonbeam-foundation/moonbeam#3358

Merged

TarekkMA added a commit to moonbeam-foundation/frontier that referenced this pull request Aug 8, 2025

Revert "Add support for EIP-7702 (polkadot-evm#1693)"

1db789a

This reverts commit 54140ae

TarekkMA added a commit to moonbeam-foundation/frontier that referenced this pull request Aug 27, 2025

Revert "Add support for EIP-7702 (polkadot-evm#1693)"

6d7f293

This reverts commit 54140ae.

undercover-cactus mentioned this pull request Mar 3, 2026

feat: upgrade to polkadot SDK 2503 datahaven-xyz/datahaven#444

Merged

Conversation

manuelmauro commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

librelois left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manuelmauro commented Jul 14, 2025

Uh oh!

sorpaas left a comment

Choose a reason for hiding this comment

Uh oh!

RomarQ commented Jul 15, 2025

Uh oh!

RomarQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RomarQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sorpaas commented Jul 18, 2025

Uh oh!

Uh oh!

librelois commented Jul 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

manuelmauro commented Jun 16, 2025 •

edited

Loading

librelois left a comment •

edited

Loading