fix visibility for pallet_nfts types used as call arguments#3634
Merged
bkchr merged 3 commits intoparitytech:masterfrom Aug 15, 2024
Merged
fix visibility for pallet_nfts types used as call arguments#3634bkchr merged 3 commits intoparitytech:masterfrom
pallet_nfts types used as call arguments#3634bkchr merged 3 commits intoparitytech:masterfrom
Conversation
|
User @SailorSnoW, please sign the CLA here. |
bkchr
approved these changes
Mar 11, 2024
bkchr
added
the
R0-no-crate-publish-required
ggwpez
approved these changes
Aug 15, 2024
ordian
added a commit
that referenced
this pull request
Aug 16, 2024
* master: Remove redundant minimal template workspace (#5330) approval-distribution: Fix handling of conclude (#5375) More logs in `is_potential_spam` from `dispute-coordinator` (#5252) Fix zombienet bridges test (#5373) Update Readme of the `polkadot` crate (#5326) allow for `u8` to be used as hold/freeze reason (#5348) Moving cargo check for runtimes to GHA (#5340) Update links in the documentation (#5175) fix visibility for `pallet_nfts` types used as call arguments (#3634) Correct some typos in crates' descriptions (#5262) Aura: Ensure we are building on each relay chain fork (#5352) Update Identity pallet README.md (#5183) Bump trie-db from 0.29.0 to 0.29.1 (#5231) [Coretime] Always include UnpaidExecution, not just when revenue is > 0 (#5369) [Pools] fix derivation of pool account (#4999)
ordian
added a commit
that referenced
this pull request
Aug 16, 2024
* master: Remove redundant minimal template workspace (#5330) approval-distribution: Fix handling of conclude (#5375) More logs in `is_potential_spam` from `dispute-coordinator` (#5252) Fix zombienet bridges test (#5373) Update Readme of the `polkadot` crate (#5326) allow for `u8` to be used as hold/freeze reason (#5348) Moving cargo check for runtimes to GHA (#5340) Update links in the documentation (#5175) fix visibility for `pallet_nfts` types used as call arguments (#3634) Correct some typos in crates' descriptions (#5262) Aura: Ensure we are building on each relay chain fork (#5352) Update Identity pallet README.md (#5183) Bump trie-db from 0.29.0 to 0.29.1 (#5231) [Coretime] Always include UnpaidExecution, not just when revenue is > 0 (#5369) [Pools] fix derivation of pool account (#4999) Upgrade accidentally downgraded deps (#5365) [Pools] Fix issues with member migration to `DelegateStake` (#4822) Unify `no_genesis` check (#5360) [CI] Fix prdoc command (#5358) Beefy: add benchmarks for `report_fork_voting()` (#5188)
ordian
added a commit
that referenced
this pull request
Aug 16, 2024
…ct-candidate-weight * ao-fix-parainclusion-weight-overestimation: Remove redundant minimal template workspace (#5330) approval-distribution: Fix handling of conclude (#5375) More logs in `is_potential_spam` from `dispute-coordinator` (#5252) Fix zombienet bridges test (#5373) Update Readme of the `polkadot` crate (#5326) allow for `u8` to be used as hold/freeze reason (#5348) Moving cargo check for runtimes to GHA (#5340) Update links in the documentation (#5175) fix visibility for `pallet_nfts` types used as call arguments (#3634) Correct some typos in crates' descriptions (#5262) Aura: Ensure we are building on each relay chain fork (#5352) Update Identity pallet README.md (#5183) Bump trie-db from 0.29.0 to 0.29.1 (#5231) [Coretime] Always include UnpaidExecution, not just when revenue is > 0 (#5369) [Pools] fix derivation of pool account (#4999) Upgrade accidentally downgraded deps (#5365) [Pools] Fix issues with member migration to `DelegateStake` (#4822) Unify `no_genesis` check (#5360) [CI] Fix prdoc command (#5358) Beefy: add benchmarks for `report_fork_voting()` (#5188)
chungquantin
added a commit
to r0gue-io/pop-node
that referenced
this pull request
May 5, 2025
Changes from the commit: paritytech/polkadot-sdk#3634
chungquantin
added a commit
to r0gue-io/pop-node
that referenced
this pull request
May 5, 2025
Changes from the commit: paritytech/polkadot-sdk#3634
chungquantin
added a commit
to r0gue-io/pop-node
that referenced
this pull request
May 7, 2025
Changes from the commit: paritytech/polkadot-sdk#3634
chungquantin
added a commit
to r0gue-io/pop-node
that referenced
this pull request
May 7, 2025
Changes from the commit: paritytech/polkadot-sdk#3634
chungquantin
added a commit
to r0gue-io/pop-node
that referenced
this pull request
May 7, 2025
Changes from the commit: paritytech/polkadot-sdk#3634
chungquantin
added a commit
to r0gue-io/pop-node
that referenced
this pull request
May 8, 2025
* fix visibility for pallet_nfts types used as call arguments Changes from the commit: paritytech/polkadot-sdk#3634 * [pallet-nfts, pallet_uniques] - Expose private structs Changes made from upstream: paritytech/polkadot-sdk#6087 * Adds BlockNumberProvider in multisig, proxy and nft pallets Upstream commit: paritytech/polkadot-sdk#5723 * Removed unused dependencies (partial progress) Upstream commit: paritytech/polkadot-sdk#7329 * implement DecodeWithMemTracking for frame pallets paritytech/polkadot-sdk#7598 * chore: bump pallet-nfts version to 34.1.0 * feat: adds BlockNumberProvider in nonfungbiles pallet * chore: update lock file of pop-api to sync nfts * chore: BlockNumberProvider for devnet nonfungibles * chore: fix benchmarking to use new BlockNumberFor * chore: revert changes * fix: missing DecodeWithMemTracking * chore: update weights of pallets * refactor(nonfungibles): remove unused BlockNumberProvider type * chore: remove unused Zero trait * chore: revert non-relevant changes * chore: revert non-relevant changes This reverts commit 182486a. * chore: benchmarking replace with BlockNumberProvider * chore(pallet-nfts): update weights
chungquantin
added a commit
to r0gue-io/pop-node
that referenced
this pull request
May 16, 2025
* fix visibility for pallet_nfts types used as call arguments Changes from the commit: paritytech/polkadot-sdk#3634 * [pallet-nfts, pallet_uniques] - Expose private structs Changes made from upstream: paritytech/polkadot-sdk#6087 * Adds BlockNumberProvider in multisig, proxy and nft pallets Upstream commit: paritytech/polkadot-sdk#5723 * Removed unused dependencies (partial progress) Upstream commit: paritytech/polkadot-sdk#7329 * implement DecodeWithMemTracking for frame pallets paritytech/polkadot-sdk#7598 * chore: bump pallet-nfts version to 34.1.0 * feat: adds BlockNumberProvider in nonfungbiles pallet * chore: update lock file of pop-api to sync nfts * chore: BlockNumberProvider for devnet nonfungibles * chore: fix benchmarking to use new BlockNumberFor * chore: revert changes * fix: missing DecodeWithMemTracking * chore: update weights of pallets * refactor(nonfungibles): remove unused BlockNumberProvider type * chore: remove unused Zero trait * chore: revert non-relevant changes * chore: revert non-relevant changes This reverts commit 182486a. * chore: benchmarking replace with BlockNumberProvider * chore(pallet-nfts): update weights
nova-scripter603
added a commit
to nova-scripter603/pop-node
that referenced
this pull request
Sep 29, 2025
* fix visibility for pallet_nfts types used as call arguments Changes from the commit: paritytech/polkadot-sdk#3634 * [pallet-nfts, pallet_uniques] - Expose private structs Changes made from upstream: paritytech/polkadot-sdk#6087 * Adds BlockNumberProvider in multisig, proxy and nft pallets Upstream commit: paritytech/polkadot-sdk#5723 * Removed unused dependencies (partial progress) Upstream commit: paritytech/polkadot-sdk#7329 * implement DecodeWithMemTracking for frame pallets paritytech/polkadot-sdk#7598 * chore: bump pallet-nfts version to 34.1.0 * feat: adds BlockNumberProvider in nonfungbiles pallet * chore: update lock file of pop-api to sync nfts * chore: BlockNumberProvider for devnet nonfungibles * chore: fix benchmarking to use new BlockNumberFor * chore: revert changes * fix: missing DecodeWithMemTracking * chore: update weights of pallets * refactor(nonfungibles): remove unused BlockNumberProvider type * chore: remove unused Zero trait * chore: revert non-relevant changes * chore: revert non-relevant changes This reverts commit 182486a53e92a12db77fb53b5f9661c9a06b9762. * chore: benchmarking replace with BlockNumberProvider * chore(pallet-nfts): update weights
code-blade543ew
added a commit
to code-blade543ew/pop-node
that referenced
this pull request
Sep 30, 2025
* fix visibility for pallet_nfts types used as call arguments Changes from the commit: paritytech/polkadot-sdk#3634 * [pallet-nfts, pallet_uniques] - Expose private structs Changes made from upstream: paritytech/polkadot-sdk#6087 * Adds BlockNumberProvider in multisig, proxy and nft pallets Upstream commit: paritytech/polkadot-sdk#5723 * Removed unused dependencies (partial progress) Upstream commit: paritytech/polkadot-sdk#7329 * implement DecodeWithMemTracking for frame pallets paritytech/polkadot-sdk#7598 * chore: bump pallet-nfts version to 34.1.0 * feat: adds BlockNumberProvider in nonfungbiles pallet * chore: update lock file of pop-api to sync nfts * chore: BlockNumberProvider for devnet nonfungibles * chore: fix benchmarking to use new BlockNumberFor * chore: revert changes * fix: missing DecodeWithMemTracking * chore: update weights of pallets * refactor(nonfungibles): remove unused BlockNumberProvider type * chore: remove unused Zero trait * chore: revert non-relevant changes * chore: revert non-relevant changes This reverts commit 182486a53e92a12db77fb53b5f9661c9a06b9762. * chore: benchmarking replace with BlockNumberProvider * chore(pallet-nfts): update weights
cyber-smithmn
added a commit
to cyber-smithmn/pop-node
that referenced
this pull request
Nov 20, 2025
* fix visibility for pallet_nfts types used as call arguments Changes from the commit: paritytech/polkadot-sdk#3634 * [pallet-nfts, pallet_uniques] - Expose private structs Changes made from upstream: paritytech/polkadot-sdk#6087 * Adds BlockNumberProvider in multisig, proxy and nft pallets Upstream commit: paritytech/polkadot-sdk#5723 * Removed unused dependencies (partial progress) Upstream commit: paritytech/polkadot-sdk#7329 * implement DecodeWithMemTracking for frame pallets paritytech/polkadot-sdk#7598 * chore: bump pallet-nfts version to 34.1.0 * feat: adds BlockNumberProvider in nonfungbiles pallet * chore: update lock file of pop-api to sync nfts * chore: BlockNumberProvider for devnet nonfungibles * chore: fix benchmarking to use new BlockNumberFor * chore: revert changes * fix: missing DecodeWithMemTracking * chore: update weights of pallets * refactor(nonfungibles): remove unused BlockNumberProvider type * chore: remove unused Zero trait * chore: revert non-relevant changes * chore: revert non-relevant changes This reverts commit 182486a53e92a12db77fb53b5f9661c9a06b9762. * chore: benchmarking replace with BlockNumberProvider * chore(pallet-nfts): update weights
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3631
Types which are impacted and fixed here are
ItemTip,PriceWithDirection,PreSignedMint,PreSignedAttributes.