Contracts: update wasmi to 0.32 by pgherveou · Pull Request #3679 · paritytech/polkadot-sdk

pgherveou · 2024-03-13T14:31:16Z

take over #2941
Weights compare

pgherveou · 2024-03-13T15:25:59Z

bot help

command-bot · 2024-03-13T15:26:03Z

Here's a link to docs

pgherveou · 2024-03-13T15:27:43Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-03-13T15:27:49Z

"$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts was queued.

Comment bot cancel 12-b6340cf3-cf20-426e-8418-9ef2f2662dcc to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-13T15:28:33Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

pgherveou · 2024-03-13T15:30:06Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-03-13T15:30:11Z

"$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts was queued.

Comment bot cancel 13-1cdb3131-e249-4e7f-8d3d-fce894ed640e to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-13T15:30:49Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

mordamax · 2024-03-13T17:23:17Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-03-13T17:23:23Z

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5523429 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 16-f37b5da1-9691-4c81-a0fb-ce26fe0701c9 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-13T19:01:05Z

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5523429 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5523429/artifacts/download.

deuszx · 2024-03-15T08:17:52Z

Hey @pgherveou , I saw that the benchmarks have finished but I'm not sure how to interpret the results. Are there any findings regarding possible execution improvements here?

pgherveou · 2024-03-15T14:31:38Z

@Robbepop @athei not sure why we commented on the previous PR
#2941 (review)

We need to change the benchmarks to compile the code in its setup so that when executing the contract it is only execution.

Why would we want to do that when we benchmark the extrinsic that is suppose to measure the whole thing

substrate/frame/contracts/src/wasm/mod.rs

pgherveou · 2024-03-21T21:55:07Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-03-21T21:55:12Z

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5610549 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 26-9ce4acbb-15c8-4149-bb27-c5c0da14c727 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-21T21:57:36Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5610549 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5610549/artifacts/download.

pgherveou · 2024-03-22T08:38:56Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-03-22T08:39:01Z

@pgherveou "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5613353) was cancelled in #3679 (comment)

command-bot · 2024-05-30T14:06:53Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6353104 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6353104/artifacts/download.

paritytech-cicd-pr · 2024-06-03T11:17:21Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: build-runtime-assets
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6380091

pgherveou · 2024-06-03T13:58:30Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-06-03T13:58:36Z

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6384092 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-36fe60b9-3737-4d8c-aad8-53f3867831aa to cancel this command or bot cancel to cancel all commands in this pull request.

…nto HEAD

…=dev --target_dir=substrate --pallet=pallet_contracts

command-bot · 2024-06-03T14:53:48Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6384092 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6384092/artifacts/download.

Robbepop

LGTM

pgherveou · 2024-06-07T12:30:21Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-06-07T12:30:27Z

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6423067 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 14-15776375-cac2-40c9-9608-75a22280f575 to cancel this command or bot cancel to cancel all commands in this pull request.

…=dev --target_dir=substrate --pallet=pallet_contracts

command-bot · 2024-06-07T13:23:26Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6423067 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6423067/artifacts/download.

* master: (29 commits) Append overlay optimization. (#1223) finalization: Skip tree route calculation if no forks present (#4721) Remove unncessary call remove_from_peers_set (#4742) add pov-recovery unit tests and support for elastic scaling (#4733) approval-voting: Add no shows debug information (#4726) Revamp the Readme of the parachain template (#4713) Update README.md to move the PSVM link under a "Tooling" section under the "Releases" section (#4734) frame/proc-macro: Refactor code for better readability (#4712) Contracts: update wasmi to 0.32 (#3679) Backport style changes from P<>K bridge to R<>W bridge (#4732) New reference doc for Custom RPC V2 (#4654) Frame Pallets: Clean a lot of test setups (#4642) Fix occupied core handling (#4691) statement-distribution: Fix false warning (#4727) Update the README to include a link to the Polkadot SDK Version Manager (#4718) Cleanup PVF artifact by cache limit and stale time (#4662) Update link to a latest polkadot release (#4711) [CI] Delete cargo-deny config (#4677) fix build on MacOS: bump secp256k1 and secp256k1-sys to patched versions (#4709) Unify dependency aliases (#4633) ...

take over paritytech#2941 [Weights compare](https://weights.tasty.limo/compare?unit=weight&ignore_errors=true&threshold=10&method=asymptotic&repo=polkadot-sdk&old=master&new=pg%2Fwasmi-to-v0.32.0-beta.7&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs) --------- Co-authored-by: command-bot <> Co-authored-by: Alexander Theißen <[email protected]>

pgherveou requested a review from athei as a code owner March 13, 2024 14:31

pgherveou mentioned this pull request Mar 13, 2024

contracts: Cache compiled modules #3650

Closed

pgherveou added the T7-smart_contracts This PR/Issue is related to smart contracts. label Mar 13, 2024

Robbepop suggested changes Mar 21, 2024

View reviewed changes

substrate/frame/contracts/src/wasm/mod.rs Show resolved Hide resolved

pgherveou force-pushed the pg/wasmi-to-v0.32.0-beta.7 branch 6 times, most recently from 290e26f to c012d73 Compare March 21, 2024 21:28

pgherveou force-pushed the pg/wasmi-to-v0.32.0-beta.7 branch from 2a5936d to 056e5dd Compare March 22, 2024 08:35

pgherveou changed the base branch from master to pg/only-validate-when-uploading March 22, 2024 08:36

Bump wasmi

08ea90b

Remove transfer_surcharge from instantiate

ac9f81c

command-bot added 2 commits June 3, 2024 14:01

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

b960a6d

…nto HEAD

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

c2b7441

…=dev --target_dir=substrate --pallet=pallet_contracts

Robbepop approved these changes Jun 7, 2024

View reviewed changes

pgherveou added 2 commits June 7, 2024 14:26

Fix PR doc and bump wasmi one last time

7efe1e7

Merge branch 'master' into pg/wasmi-to-v0.32.0-beta.7

99cd79e

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

ee1a7ca

…=dev --target_dir=substrate --pallet=pallet_contracts

pgherveou enabled auto-merge June 7, 2024 13:41

athei approved these changes Jun 7, 2024

View reviewed changes

pgherveou added this pull request to the merge queue Jun 7, 2024

Merged via the queue into master with commit 48d875d Jun 7, 2024

pgherveou deleted the pg/wasmi-to-v0.32.0-beta.7 branch June 7, 2024 15:10

This was referenced Aug 16, 2024

chore: upgrade to v1.14.0 r0gue-io/base-parachain#41

Merged

chore: upgrade v1.14.0 r0gue-io/pop-node#198

Merged

github-actions bot mentioned this pull request Aug 21, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moondance-labs/tanssi#659

Closed

chungquantin mentioned this pull request Aug 21, 2024

chore: upgrade to polkadot v1.14.0 r0gue-io/contracts-parachain#9

Merged

github-actions bot mentioned this pull request Aug 22, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moonbeam-foundation/moonbeam#2912

Closed

Conversation

pgherveou commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgherveou commented Mar 13, 2024

Uh oh!

command-bot bot commented Mar 13, 2024

Uh oh!

pgherveou commented Mar 13, 2024

Uh oh!

command-bot bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 13, 2024

Uh oh!

pgherveou commented Mar 13, 2024

Uh oh!

command-bot bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 13, 2024

Uh oh!

mordamax commented Mar 13, 2024

Uh oh!

command-bot bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 13, 2024

Uh oh!

deuszx commented Mar 15, 2024

Uh oh!

pgherveou commented Mar 15, 2024

Uh oh!

Uh oh!

pgherveou commented Mar 21, 2024

Uh oh!

command-bot bot commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 21, 2024

Uh oh!

pgherveou commented Mar 22, 2024

Uh oh!

command-bot bot commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented May 30, 2024

Uh oh!

paritytech-cicd-pr commented Jun 3, 2024

Uh oh!

pgherveou commented Jun 3, 2024

Uh oh!

command-bot bot commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jun 3, 2024

Uh oh!

Robbepop left a comment

Choose a reason for hiding this comment

Uh oh!

pgherveou commented Jun 7, 2024

Uh oh!

command-bot bot commented Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pgherveou commented Mar 13, 2024 •

edited

Loading

command-bot bot commented Mar 13, 2024 •

edited

Loading

command-bot bot commented Mar 13, 2024 •

edited

Loading

command-bot bot commented Mar 13, 2024 •

edited

Loading

command-bot bot commented Mar 21, 2024 •

edited

Loading

command-bot bot commented Mar 22, 2024 •

edited

Loading

command-bot bot commented Jun 3, 2024 •

edited

Loading

command-bot bot commented Jun 7, 2024 •

edited

Loading