Merged
Conversation
3 tasks
al3mart
reviewed
Aug 20, 2024
Daanvdplas
requested changes
Aug 20, 2024
Collaborator
There was a problem hiding this comment.
I see dependencies that are bumped when looking at the Cargo.toml file of the SDK on release v1.14 (e.g. codec = 3.6.12), compared to the ones here. Please compare the ones above line 40 (#Substrate).
service.rs:
+use prometheus_endpoint::Registry;
-use substrate_prometheus_endpoint::Registry;
runtime/src/config/mod.rs:
message_queue
- type HeapSize = sp_core::ConstU32<{ 64 * 1024 }>;
+ type HeapSize = sp_core::ConstU32<{ 103 * 1024 }>;
xcm.rs
- type FeeManager = XcmFeeManagerFromComponents<
- WaivedLocations,
- // Delivery fees are sent to the treasury account.
- // These funds are not accessible without a module controlling such an account.
- // [pallet_treasury](https://github.com/paritytech/polkadot-sdk/tree/master/substrate/frame/treasury)
- // could be suitable option, configured using the same `TREASURY_PALLET_ID` used above as the pallet config's `PalletId`.
- XcmFeeToAccount<Self::AssetTransactor, AccountId, TreasuryAccount>,
- >;
+ type FeeManager = ();
- type XcmTeleportFilter = Nothing;
+ type XcmTeleportFilter = Everything;
Could be sensible to ship the template wiith MigrateToLatestXcmVersion baked into the runtime.
I see no harm in putting it in there.
al3mart
reviewed
Aug 20, 2024
Member
al3mart
left a comment
There was a problem hiding this comment.
Can't find anything more than what Daan has spotted.
Left a pair of super small nits.
Daanvdplas
approved these changes
Aug 20, 2024
Collaborator
Daanvdplas
left a comment
There was a problem hiding this comment.
Apart from ale's comments the chain runs smoothly and seems good to go!
al3mart
approved these changes
Aug 20, 2024
This was referenced Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: ✅ Compiled and built successfully
ISSUE: chore: upgrade polkadot version to v1.14.0 #39
Release: https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.14.0
Compare Parachain Template v1.13.0 vs Parachain Template v1.14.0
Direct changes
runtimemacroRuntimeFreezeReason: paritytech/polkadot-sdk@988103d