chore: upgrade v1.14.0

[chungquantin]

Status: ✅ Compiled and built successfully

• ISSUE: chore: upgrade polkadot version to v1.14.0 base-parachain#39
• Release: https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.14.0
• Prerequisite:
• chore: upgrade to v1.14.0 base-parachain#41
• chore: upgrade to 1.13.0 #194
• fix: migrate integration tests from paseo to polkadot runtimes #201

Direct changes

• Add POV reclaim feature (introduced in v1.9.0 but there is a fix PR in v1.14.0).
• Migrate XCMv5
• Introduce the construct runtime V2
• Use aggregated types for RuntimeFreezeReason: paritytech/polkadot-sdk@988103d
• [#4730]: rpc upgrade jsonrpsee to v0.23.1
• [#4769]: Use real rust type for pallet alias in runtime macro

Related changes

• [#3679]: [pallet-contracts] bump wasmi to 0.32
• [#4799]: network: Upgrade litep2p to v0.6.0

[Daanvdplas]

After comparing the runtime with the parachain template in the SDK on 1.14.

Runtime

• Missing pov reclaim signed extension (should have been added in 1.9)

Node

• ReclaimHostFunctions, should also have been added to 1.9.

See base-parachain 1.9 upgrade and pop node 1.9 upgrade.

[chungquantin]

@Daanvdplas The POV reclaim feature is not added to this upgrade on purpose because there was a problem as discussed.

[Daanvdplas]

Could we add that in the description please? So that we have a reference to it

[chungquantin]

As we discussed in the 1.10.0 upgrade PR: https://github.com/paritytech/polkadot-sdk/pull/5371/files to whether we should add back the POV reclaim. From my understanding, it is fair to say that we can add back the feature in this v1.14.0 upgrade because there is a PR to fix the feature in this version: https://github.com/paritytech/polkadot-sdk/pull/5371/files

Hence, we can reimplement that for both devnet and testnet. What do you think?

cc: @al3mart @Daanvdplas @peterwht

[Daanvdplas]

There is also this migration: https://github.com/paritytech/polkadot-sdk/blob/946afaabd8244f1256f3aecff75e23c02937bd38/polkadot/xcm/pallet-xcm/src/migration.rs#L84

And this change in 1.13 (search for type MaxPageSize = ConstU32<{ 103 * 1024 }>;)

Would love to hear @al3mart opinion on both before putting it in.

[al3mart]

About the PoV reclaim feature I think we are OK to include it as part of this PR if we want to have it.
It definitely seems beneficial!

MigrateToLatestXcmVersion seems something that we have been missing for longer than this migrations even, so including it now would be good.

On MaxPageSize; our only open channel for the testnet right now is using a configuration of maxMessageSize: 8,192, which is well under our current value of 1 << 16, so we should be OK.
Though, if deploying a local environment as in pop up parachain -f networks/devnet.toml that would spin a relay that can values for that message size up to 1,048,576, so using a config of type MaxPageSize = ConstU32<{ 103 * 1024 }>; for the devnet runtime should put us just above it 👌
For the sake of simplicity I'd say that updating the config on both runtimes to type MaxPageSize = ConstU32<{ 103 * 1024 }>; would be the better option.

[peterwht]

So close! Great job.

As this is the last PR in the upgrade to 1.14, we should make sure all migrations are added.

try-runtime says we need a migration for XcmpQueue and pallet-contracts.

• https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/runtimes/contracts/contracts-rococo/src/lib.rs#L113
• https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/runtimes/contracts/contracts-rococo/src/lib.rs#L116

[ERROR runtime::frame-support] XcmpQueue: On chain storage version StorageVersion(4) doesn't match in-code storage version StorageVersion(5).
[ERROR runtime::frame-support] Contracts: On chain storage version StorageVersion(15) doesn't match in-code storage version StorageVersion(16).

[peterwht]

Let's go ahead and just add PovReclaim now that it has fixes. Just to note, we may have some changes in the future paritytech/polkadot-sdk#5234

[chungquantin]

1. Migrations for contract, XCMP queue and XCM is added to the testnet runtime. Tested with try-runtime and works well.

	pallet_contracts::Migration<Runtime>,
	cumulus_pallet_xcmp_queue::migration::v5::MigrateV4ToV5<Runtime>,
	pallet_xcm::migration::MigrateToLatestXcmVersion<Runtime>,

2. POV reclaim feature is added for both devnet and testnet
3. Update the type parameter value of the HRMP channel max size

cc: @Daanvdplas @al3mart @peterwht

Before merging this PR, could you guys please help me to review this PR as well: #201 which fixes the integration tests.

[peterwht]

LGTM!!! Glad to see this so close being done.