Skip to content

Frame Pallets: Clean a lot of test setups#4642

Merged
kianenigma merged 16 commits intomasterfrom
kiz-clean-test-setups
Jun 7, 2024
Merged

Frame Pallets: Clean a lot of test setups#4642
kianenigma merged 16 commits intomasterfrom
kiz-clean-test-setups

Conversation

@kianenigma
Copy link
Copy Markdown
Contributor

@kianenigma kianenigma commented May 30, 2024

Screenshot 2024-05-30 at 10 30 41

@kianenigma kianenigma added R0-no-crate-publish-required The change does not require any crates to be re-published. T1-FRAME This PR/Issue is related to core FRAME, the framework. labels May 30, 2024
@kianenigma kianenigma requested a review from a team as a code owner May 30, 2024 02:31
@paritytech-review-bot paritytech-review-bot bot requested a review from a team May 30, 2024 02:31
seadanda
seadanda approved these changes May 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a few opportunities to remove things ;) already happy to approve as is though

substrate/frame/indices/src/mock.rs
type DbWeight = ();
type RuntimeOrigin = RuntimeOrigin;
type RuntimeCall = RuntimeCall;
type Nonce = u64;
Copy link
Copy Markdown
Contributor

@seadanda seadanda May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elsewhere you've removed this and converted the tests to use u32 - is it worth just doing this everywhere?

kianenigma and others added 4 commits May 31, 2024 10:11
@kianenigma kianenigma enabled auto-merge May 31, 2024 02:24
@gupnik gupnik mentioned this pull request Jun 4, 2024
Open
@paritytech-cicd-pr
Copy link
Copy Markdown

paritytech-cicd-pr commented Jun 7, 2024

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6417534

@kianenigma kianenigma disabled auto-merge June 7, 2024 07:40
@kianenigma kianenigma enabled auto-merge June 7, 2024 07:40
@kianenigma kianenigma added this pull request to the merge queue Jun 7, 2024
Merged via the queue into master with commit 9bb1f3f Jun 7, 2024
@kianenigma kianenigma deleted the kiz-clean-test-setups branch June 7, 2024 11:59
ordian added a commit that referenced this pull request Jun 13, 2024
@ordian
merge master and resolve conflicts
dff960c 
* master: (29 commits)
  Append overlay optimization. (#1223)
  finalization: Skip tree route calculation if no forks present (#4721)
  Remove unncessary call remove_from_peers_set (#4742)
  add pov-recovery unit tests and support for elastic scaling (#4733)
  approval-voting: Add no shows debug information (#4726)
  Revamp the Readme of the parachain template (#4713)
  Update README.md to move the PSVM link under a "Tooling" section under the "Releases" section (#4734)
  frame/proc-macro: Refactor code for better readability (#4712)
  Contracts:  update wasmi to 0.32 (#3679)
  Backport style changes from P<>K bridge to R<>W bridge (#4732)
  New reference doc for Custom RPC V2 (#4654)
  Frame Pallets: Clean a lot of test setups (#4642)
  Fix occupied core handling (#4691)
  statement-distribution: Fix false warning (#4727)
  Update the README to include a link to the Polkadot SDK Version Manager (#4718)
  Cleanup PVF artifact by cache limit and stale time (#4662)
  Update link to a latest polkadot release (#4711)
  [CI] Delete cargo-deny config (#4677)
  fix build on MacOS: bump secp256k1 and secp256k1-sys to patched versions (#4709)
  Unify dependency aliases (#4633)
  ...
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@kianenigma @seadanda @TarekkMA
Frame Pallets: Clean a lot of test setups (paritytech#4642)
9bcdb80 
<img width="484" alt="Screenshot 2024-05-30 at 10 30 41"
src="https://github.com/paritytech/polkadot-sdk/assets/5588131/92ece1d0-cda3-46cf-9f46-4026c565b52d">

---------

Co-authored-by: Dónal Murray <donal.murray@parity.io>
This was referenced Aug 21, 2024
Closed
Closed
@ayushmishra2005 ayushmishra2005 mentioned this pull request Nov 6, 2024
Closed
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
@kianenigma @seadanda
Frame Pallets: Clean a lot of test setups (paritytech#4642)
b7fd2be 
<img width="484" alt="Screenshot 2024-05-30 at 10 30 41"
src="https://github.com/paritytech/polkadot-sdk/assets/5588131/92ece1d0-cda3-46cf-9f46-4026c565b52d">

---------

Co-authored-by: Dónal Murray <donal.murray@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seadanda seadanda seadanda approved these changes

@bkontur bkontur bkontur approved these changes

@ggwpez ggwpez ggwpez approved these changes

@alindima alindima alindima approved these changes

+1 more reviewer

@gupnik gupnik gupnik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kianenigma @paritytech-cicd-pr @bkontur @ggwpez @alindima @seadanda @gupnik