Skip to content

frame/proc-macro: Refactor code for better readability#4712

Merged
gupnik merged 8 commits intomasterfrom
lexnv/frame-proc-refactor
Jun 8, 2024
Merged

frame/proc-macro: Refactor code for better readability#4712
gupnik merged 8 commits intomasterfrom
lexnv/frame-proc-refactor

Conversation

@lexnv
Copy link
Contributor

@lexnv lexnv commented Jun 5, 2024

Small refactoring PR to improve the readability of the proc macros.

  • small improvement in docs
  • use new let Some(..) else expression
  • removed extra indentations by early returns

Discovered during metadata v16 poc, extracted from: #4358

lexnv added 5 commits June 5, 2024 17:18
@lexnv
frame/proc: Refactor TraitItemType parsing
0e3e7af 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
frame/proc: Refactor itemTrait extraction
d2d7ccd 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
frame/proc: Refactor check_event_type
fbd3c0d 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
frame/constants: Improve documentation
8fe24b3 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
frame/helpers: Refactor take_first_item_pallet_attr
e9b0ff3 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-no-crate-publish-required The change does not require any crates to be re-published. I4-refactor Code needs refactoring. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Jun 5, 2024
@lexnv lexnv self-assigned this Jun 5, 2024
@lexnv lexnv requested a review from a team as a code owner June 5, 2024 14:23
bkchr
bkchr approved these changes Jun 6, 2024
View reviewed changes
@kianenigma kianenigma requested a review from gupnik June 7, 2024 06:53
@gupnik
Copy link
Contributor

gupnik commented Jun 8, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Jun 8, 2024 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6426854 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 15-3f139a32-3dc6-470a-b9f0-862aa9bd4453 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 8, 2024

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6426854 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6426854/artifacts/download.

@gupnik gupnik enabled auto-merge June 8, 2024 07:08
@gupnik gupnik added this pull request to the merge queue Jun 8, 2024
Merged via the queue into master with commit 07cfcf0 Jun 8, 2024
@gupnik gupnik deleted the lexnv/frame-proc-refactor branch June 8, 2024 08:14
ordian added a commit that referenced this pull request Jun 13, 2024
@ordian
merge master and resolve conflicts
dff960c 
* master: (29 commits)
  Append overlay optimization. (#1223)
  finalization: Skip tree route calculation if no forks present (#4721)
  Remove unncessary call remove_from_peers_set (#4742)
  add pov-recovery unit tests and support for elastic scaling (#4733)
  approval-voting: Add no shows debug information (#4726)
  Revamp the Readme of the parachain template (#4713)
  Update README.md to move the PSVM link under a "Tooling" section under the "Releases" section (#4734)
  frame/proc-macro: Refactor code for better readability (#4712)
  Contracts:  update wasmi to 0.32 (#3679)
  Backport style changes from P<>K bridge to R<>W bridge (#4732)
  New reference doc for Custom RPC V2 (#4654)
  Frame Pallets: Clean a lot of test setups (#4642)
  Fix occupied core handling (#4691)
  statement-distribution: Fix false warning (#4727)
  Update the README to include a link to the Polkadot SDK Version Manager (#4718)
  Cleanup PVF artifact by cache limit and stale time (#4662)
  Update link to a latest polkadot release (#4711)
  [CI] Delete cargo-deny config (#4677)
  fix build on MacOS: bump secp256k1 and secp256k1-sys to patched versions (#4709)
  Unify dependency aliases (#4633)
  ...
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@lexnv @bkchr
@gupnik @TarekkMA
frame/proc-macro: Refactor code for better readability (paritytech#4712)
8e6a0e2 
Small refactoring PR to improve the readability of the proc macros.
- small improvement in docs
- use new `let Some(..) else` expression
- removed extra indentations by early returns

Discovered during metadata v16 poc, extracted from:
paritytech#4358

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
Co-authored-by: gupnik <mail.guptanikhil@gmail.com>
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
@lexnv @bkchr @gupnik
frame/proc-macro: Refactor code for better readability (paritytech#4712)
c0d19b6 
Small refactoring PR to improve the readability of the proc macros.
- small improvement in docs
- use new `let Some(..) else` expression
- removed extra indentations by early returns

Discovered during metadata v16 poc, extracted from:
paritytech#4358

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
Co-authored-by: gupnik <mail.guptanikhil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

+1 more reviewer

@gupnik gupnik gupnik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lexnv lexnv

Labels

A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lexnv @gupnik @bkchr