- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.5k
feat: add Redis cluster mode support (Alpha) #25115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mohamed Elawadi <[email protected]>
Signed-off-by: Mohamed Elawadi <[email protected]>
Signed-off-by: Mohamed Elawadi <[email protected]>
Signed-off-by: Mohamed Elawadi <[email protected]>
| ❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment): 
 | 
…ter mode Signed-off-by: Erhhung Yuan <[email protected]>
…rs for Redis cluster mode Signed-off-by: Erhhung Yuan <[email protected]>
c14e4d4    to
    b1ce8b5      
    Compare
  
    Signed-off-by: Frederic Mereu <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…havior (argoproj#25024) Signed-off-by: Nitish Kumar <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Regina Voloshin <[email protected]>
Signed-off-by: rumstead <[email protected]>
Signed-off-by: shota3506 <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…dd08f76 (argoproj#25073) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
…proj#25086) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oj#25085) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…bac879 (argoproj#25091) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
…rgoproj#25099) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Afzal Ansari <[email protected]>
…roj#25068) Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Yusuke Abe <[email protected]>
Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Jonathan Winters <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…#22706) Signed-off-by: Afzal Ansari <[email protected]>
ff1901a    to
    5258c09      
    Compare
  
    Signed-off-by: Frederic Mereu <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…proj#25086) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oj#25085) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…bac879 (argoproj#25091) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Erhhung Yuan <[email protected]>
…rgoproj#25099) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Afzal Ansari <[email protected]>
…roj#25068) Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Yusuke Abe <[email protected]>
Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Jonathan Winters <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…#22706) Signed-off-by: Afzal Ansari <[email protected]>
5258c09    to
    37af32a      
    Compare
  
    | Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master   #25115      +/-   ##
==========================================
- Coverage   62.29%   62.18%   -0.11%     
==========================================
  Files         351      351              
  Lines       49213    49253      +40     
==========================================
- Hits        30656    30629      -27     
- Misses      15640    15687      +47     
- Partials     2917     2937      +20     ☔ View full report in Codecov by Sentry. | 
0223acf    to
    a9d9eff      
    Compare
  
    Signed-off-by: Frederic Mereu <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…havior (argoproj#25024) Signed-off-by: Nitish Kumar <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Regina Voloshin <[email protected]>
Signed-off-by: rumstead <[email protected]>
Signed-off-by: shota3506 <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…dd08f76 (argoproj#25073) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Erhhung Yuan <[email protected]>
…proj#25086) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oj#25085) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…bac879 (argoproj#25091) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Erhhung Yuan <[email protected]>
…rgoproj#25099) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Afzal Ansari <[email protected]>
…roj#25068) Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Yusuke Abe <[email protected]>
Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Jonathan Winters <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…#22706) Signed-off-by: Afzal Ansari <[email protected]>
Signed-off-by: Erhhung Yuan <[email protected]>
a9d9eff    to
    599a1f7      
    Compare
  
    | Sorry about all the duplicate rebase commits—didn't want to risk any issues by dropping any from history, so please perform a squash merge if the PR is acceptable. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sign all your commits? I also think you might need to bring a cleaner commit history here, it makes these more difficult to review an introduces risk.
I suggest starting with a new branch and applying your changes there first so you can bring in a clean history.
This PR is a revival or PR #14001 that has gone stale due to lack of follow-up by the original PR contributor @mie00. I have applied the original PR changes, rebased against the master branch, and changed the new CLI parameter and environment variable names to be consistent with existing names.
To re-iterate, this PR adds support for Redis running in cluster mode by:
redis.UniversalClientinterface abstraction--redis-cluster-modeCLI parameter andREDIS_CLUSTER_MODEenvironment variable (true/false) to useredis.ClusterClientinstead ofredis.ClientREDIS_CLUSTER_MODEenvironment variable using theredis.cluster.modevalue in theargocd-cmd-params-cmConfigMapChecklist: