-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore: remove unnecessary lock value copy in test #24939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unnecessary lock value copy in test #24939
Conversation
Signed-off-by: shota3506 <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24939 +/- ##
==========================================
- Coverage 60.79% 60.78% -0.02%
==========================================
Files 351 351
Lines 60439 60439
==========================================
- Hits 36745 36737 -8
- Misses 20772 20782 +10
+ Partials 2922 2920 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: shota3506 <[email protected]>
Signed-off-by: shota3506 <[email protected]>
Signed-off-by: shota3506 <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
Signed-off-by: shota3506 <[email protected]>
Signed-off-by: shota3506 <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
Signed-off-by: shota3506 <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
Signed-off-by: shota3506 <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
Signed-off-by: shota3506 <[email protected]>
This PR remove unnecessary lock value copy in test. It makes the native
go vet ./...command pass.The comment in the code is outdated - the deadlock is tested without accessing the lock from the test code.
Checklist: