-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(ui): overlapping UI elements and add resource units to tooltips #24717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): overlapping UI elements and add resource units to tooltips #24717
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
afzal442
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: choejwoo <[email protected]>
Signed-off-by: choejwoo <[email protected]>
8e2e0c5 to
5f67e3c
Compare
Signed-off-by: choejwoo <[email protected]>
Signed-off-by: choejwoo <[email protected]>
Signed-off-by: choejwoo <[email protected]>
Signed-off-by: choejwoo <[email protected]>
Signed-off-by: choejwoo <[email protected]>
5f67e3c to
0e2485b
Compare
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]>
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]>
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]>
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]> Signed-off-by: Erhhung Yuan <[email protected]>
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]>
|
@rumstead Can we cherry-pick this into 3.2? :) |
|
❌ Cherry-pick failed for 3.2. Please check the workflow logs for details. |
|
@mkilchhofer sure! can you create a cherry pick PR to the release-3.2 branch? |
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]>
|
I quickly tried but since I am not familiar with frontend stuff, I think have to give up. It seems that 3 other changes influence the cherry-pick of this PR:
Nevertheless, I created a Draft-PR (#25224) and picked all those 4 commit just to see what CI says. But I think normally we want to pick each PR individually, right? |
…rgoproj#24717) Signed-off-by: choejwoo <[email protected]>


Related to #20637, #11513
After the above changes, I noticed that as
nodeInfoincreased, theresource-tree viewUI started breaking.It seems to have been caused by the combination of the two previous changes. I fixed the issue without altering the results of those already completed tasks. Therefore, I adjusted the number of resources displayed on each node in the
resource-tree viewto two, and improved the readability of the tooltip information.I also noticed that the logic always showed a
morebutton even when exactly four resources fit perfectly. I updated this so that only up to two resources are shown, and themorebutton appears when there are three or more resources.The attached screenshots show the UI before and after the fix.
The issue only occurred in the
resource-tree view. No changes were required for thepod view.Additionally, to avoid duplicate code in
pod viewtooltips, I updated the resource unit display to reference a utility function I created.Thanks!
AS-IS
Even though I added the resource unit, the view was still rendered incorrectly.

TO-BE
Checklist: