Skip to content

fix: Only show apiVersion/kind when targetState is defined #25068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2025
Merged

fix: Only show apiVersion/kind when targetState is defined #25068

merged 2 commits into from
Oct 28, 2025

Conversation

@jsoref
Copy link
Member

@jsoref jsoref commented Oct 24, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jsoref jsoref requested a review from a team as a code owner October 24, 2025 18:33
@bunnyshell
Copy link

bunnyshell bot commented Oct 24, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@jsoref jsoref changed the title fix: Only show apiVersion/kind when targetState is defined fix: Only show apiVersion/kind when targetState is defined Oct 24, 2025
@jsoref @chansuke
chore: Drop optional bits from chain
b761810 
Co-authored-by: Yusuke Abe <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@blakepettersson
Copy link
Member

blakepettersson commented Oct 28, 2025

@jsoref do you want this backported to some version(s)?

@blakepettersson blakepettersson merged commit 0d0cec6 into argoproj:master Oct 28, 2025
24 checks passed
@jsoref jsoref deleted the issue-16643 branch October 28, 2025 11:08
@jsoref
Copy link
Member Author

jsoref commented Oct 28, 2025

That'd be nice. We haven't managed to upgrade to the new world...

erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 29, 2025
@jsoref @chansuke @erhhung
fix: Only show apiVersion/kind when targetState is defined (argop…
e80c4f9 
…roj#25068)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Co-authored-by: Yusuke Abe <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 29, 2025
@jsoref @chansuke @erhhung
fix: Only show apiVersion/kind when targetState is defined (argop…
62217ce 
…roj#25068)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Co-authored-by: Yusuke Abe <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
@jsoref @chansuke @erhhung
fix: Only show apiVersion/kind when targetState is defined (argop…
c221849 
…roj#25068)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Co-authored-by: Yusuke Abe <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
@jsoref @chansuke @erhhung
fix: Only show apiVersion/kind when targetState is defined (argop…
8900ca8 
…roj#25068)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Co-authored-by: Yusuke Abe <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
@jsoref @chansuke @erhhung
fix: Only show apiVersion/kind when targetState is defined (argop…
f543b7b 
…roj#25068)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Co-authored-by: Yusuke Abe <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
@jsoref @chansuke @erhhung
fix: Only show apiVersion/kind when targetState is defined (argop…
a53b5f0 
…roj#25068)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Co-authored-by: Yusuke Abe <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
@jsoref @chansuke @erhhung
fix: Only show apiVersion/kind when targetState is defined (argop…
32b5331 
…roj#25068)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Co-authored-by: Yusuke Abe <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
@jsoref @chansuke @erhhung
fix: Only show apiVersion/kind when targetState is defined (argop…
aebcf87 
…roj#25068)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Co-authored-by: Yusuke Abe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

@nitishfy nitishfy nitishfy approved these changes

+1 more reviewer

@chansuke chansuke chansuke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

undefined/undefined is wrong...

4 participants

@jsoref @blakepettersson @chansuke @nitishfy