Skip to content

Conversation

@fad3t
Copy link
Contributor

@fad3t fad3t commented Oct 22, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Aligns the name of the duration known type (meta/v1/Duration) with what's actually in the code.

Signed-off-by: Frederic Mereu <[email protected]>
@fad3t fad3t requested review from a team as code owners October 22, 2025 11:32
@bunnyshell
Copy link

bunnyshell bot commented Oct 22, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@nitishfy
Copy link
Member

can you please share the sources that made you propose these changes?

@reggie-k
Copy link
Member

Approved by mistake, waiting for the answer to Nitish's question.

@fad3t
Copy link
Contributor Author

fad3t commented Oct 22, 2025

can you please share the sources that made you propose these changes?

Yes, sorry here it is: https://github.com/argoproj/argo-cd/blob/master/util/argo/normalizers/knowntypes_normalizer.go#L36

Using meta/v1/duration as suggested in the doc throws the following warning message:

Failed to configure known field normalizer: type 'meta/v1/duration' is not supported

@reggie-k reggie-k merged commit 2f175fc into argoproj:master Oct 23, 2025
24 checks passed
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 29, 2025
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 29, 2025
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
Signed-off-by: Frederic Mereu <[email protected]>
Signed-off-by: Erhhung Yuan <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
Signed-off-by: Frederic Mereu <[email protected]>
Signed-off-by: Erhhung Yuan <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
Signed-off-by: Frederic Mereu <[email protected]>
Signed-off-by: Erhhung Yuan <[email protected]>
erhhung pushed a commit to erhhung/argo-cd that referenced this pull request Oct 30, 2025
Signed-off-by: Frederic Mereu <[email protected]>
Signed-off-by: Erhhung Yuan <[email protected]>
AvhiMaz pushed a commit to AvhiMaz/argo-cd that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants