fix(misconf): reduce log noise on incompatible check

[simar7]

Description

Related issues

• Close fix: ignore check compatibility warnings for dev releases #8944

Checklist

• I've read the guidelines for contributing to this repository.
• I've followed the conventions in the PR title.
• I've added tests that prove my fix is effective or that my feature works.
• I've updated the documentation with the relevant information (if needed).
• I've added usage information (if the PR introduces new options)
• I've included a "before" and "after" example to the description (if the PR is a user interface change).

[simar7]

I think we can have another logger method such as .WarnIf() where we could conditionally log messages based on a certain boolean condition.

[nikpivkin]

Maybe we should also move the parsing of the Trivy version outside the loop?

[simar7]

updated: 1fa3370

Since there's no "empty" type for semver, we have to pass the trivy version error around. It's kinda clunky so if you have a better way to solve it, I'm all ears.

[nikpivkin]

You can check for version validity before calling IsMinimumVersionSupported:

-func (s *Scanner) IsMinimumVersionSupported(metadata *StaticMetadata, module *ast.Module, tv semver.Version, tverr error) bool {
+func (s *Scanner) IsMinimumVersionSupported(metadata *StaticMetadata, module *ast.Module, tv semver.Version) bool {
        if metadata.MinimumTrivyVersion == "" { // to ensure compatibility with old modules without minimum trivy version
                return true
        }
 
-       if tverr != nil {
-               return true // if we cannot parse the current Trivy version, we cannot determine compatibility
-       }
-
        mmsv, err := semver.Parse(metadata.MinimumTrivyVersion)
        if err != nil {
                s.logger.Warn(
@@ -366,7 +362,8 @@ func (s *Scanner) filterModules() error {
                }
 
                if metadata != nil {
-                       if !s.IsMinimumVersionSupported(metadata, module, tv, tverr) {
+                       // if we cannot parse the current Trivy version, we cannot determine compatibility
+                       if tverr == nil && !s.IsMinimumVersionSupported(metadata, module, tv) {
                                continue
                        }

Or tv.Major() == nil && tv.Minor() == nil && tv.Path() == nil, but it's easier to check the error.

[simar7]

Actually I tried a similar approach, but the position of the check matters.

			if !s.IsMinimumVersionSupported(metadata, module, tv) && tverr == nil {

in this case, s.IsMinimumVersionSupported(metadata, module, tv) is called first which panics as tv is empty. But the below works as you suggested:

			if tverr == nil && !s.IsMinimumVersionSupported(metadata, module, tv) {

Updated: aed04e3

[nikpivkin]

This can be rewritten into 1 expression

[simar7]

updated afd0da1

[nikpivkin]

LGTM. Left 1 small comment