fix(misconf): correct Azure value-to-time conversion in AsTimeValue (#9015)

Signed-off-by: nikpivkin <[email protected]>

Author: nikpivkin

pkg/iac/scanners/azure/value.go

@@ -335,19 +335,28 @@ func (v Value) HasKey(key string) bool {
 	return ok
 }
 
-func (v Value) AsTimeValue(metadata types.Metadata) types.TimeValue {
+func (v Value) AsTimeValue(parentMeta types.Metadata) types.TimeValue {
 	v.Resolve()
-	if v.Kind != KindString {
-		return types.Time(time.Time{}, metadata)
-	}
-	if v.Kind == KindNumber {
-		return types.Time(time.Unix(int64(v.AsFloat()), 0), metadata)
-	}
-	t, err := time.Parse(time.RFC3339, v.rLit.(string))
-	if err != nil {
-		return types.Time(time.Time{}, metadata)
+
+	switch v.Kind {
+	case KindString:
+		t, err := time.Parse(time.RFC3339, v.rLit.(string))
+		if err != nil {
+			return types.Time(time.Time{}, parentMeta)
+		}
+		return types.Time(t, v.Metadata)
+	case KindNumber:
+		var tv int64
+		switch vv := v.rLit.(type) {
+		case float64:
+			tv = int64(vv)
+		case int64:
+			tv = vv
+		}
+		return types.Time(time.Unix(tv, 0), v.Metadata)
+	default:
+		return types.Time(time.Time{}, parentMeta)
 	}
-	return types.Time(t, metadata)
 }
 
 func (v Value) AsStringValuesList(defaultValue string) (stringValues []types.StringValue) {

pkg/iac/scanners/azure/value_test.go

@@ -2,6 +2,7 @@ package azure
 
 import (
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 
@@ -12,3 +13,40 @@ func Test_ValueAsInt(t *testing.T) {
 	val := NewValue(int64(10), types.NewTestMetadata())
 	assert.Equal(t, 10, val.AsInt())
 }
+
+func Test_ValueAsTime(t *testing.T) {
+	tests := []struct {
+		name     string
+		val      any
+		expected time.Time
+	}{
+		{
+			name:     "string",
+			val:      "2023-12-15T14:45:00Z",
+			expected: time.Date(2023, 12, 15, 14, 45, 0, 0, time.UTC),
+		},
+		{
+			name:     "int",
+			val:      int64(200),
+			expected: time.Unix(200, 0),
+		},
+		{
+			name:     "float",
+			val:      float64(100),
+			expected: time.Unix(100, 0),
+		},
+		{
+			name:     "invalid type",
+			val:      nil,
+			expected: time.Time{},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			val := NewValue(tt.val, types.NewTestMetadata())
+			got := val.AsTimeValue(types.NewTestMetadata()).Value()
+			assert.Equal(t, tt.expected, got)
+		})
+	}
+}