Skip to content

fix(misconf): reduce log noise on incompatible check #9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025
Merged

fix(misconf): reduce log noise on incompatible check #9029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81af823
fix(misconf): reduce log noise on incompatible check
simar7 Jun 11, 2025
1fa3370
refactor: move trivy version parsing outside of loop
simar7 Jun 17, 2025
aed04e3
refactor: check error early for trivy version
simar7 Jun 18, 2025
afd0da1
refactor: simplify expression
simar7 Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions pkg/iac/rego/load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,22 +344,23 @@ func moduleHasLegacyInputFormat(module *ast.Module) bool {
// filterModules filters the Rego modules based on metadata.
func (s *Scanner) filterModules() error {
filtered := make(map[string]*ast.Module)
tv, tverr := semver.Parse(s.trivyVersion)
if tverr != nil && s.trivyVersion != "dev" {
s.logger.Warn(
"Failed to parse Trivy version - cannot confirm if all modules will work with current version",
log.String("trivy_version", s.trivyVersion),
log.Err(tverr),
)
}

for name, module := range s.policies {
metadata, err := s.metadataForModule(context.Background(), name, module, nil)
if err != nil {
return fmt.Errorf("retrieve metadata for module %s: %w", name, err)
}

if metadata != nil {
tv, err := semver.Parse(s.trivyVersion)
if err != nil {
s.logger.Warn(
"Failed to parse Trivy version - cannot confirm if module will work with current version",
log.String("trivy_version", s.trivyVersion),
log.FilePath(module.Package.Location.File),
log.Err(err),
)
} else if !s.IsMinimumVersionSupported(metadata, module, tv) {
if tverr == nil && !s.IsMinimumVersionSupported(metadata, module, tv) {
continue
}

Expand Down
6 changes: 6 additions & 0 deletions pkg/iac/rego/load_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,12 @@ func TestIsMinimumTrivyVersion(t *testing.T) {
MinimumTrivyVersion: "",
expectedResults: 1,
},
{
name: "trivy version is dev",
trivyVersion: "dev",
MinimumTrivyVersion: "1.2.3",
expectedResults: 1,
},
}

for _, tc := range testCases {
Expand Down