Merged
Conversation
…issue TeamNewPipe#10030) - Previously, *.SRT files only contained timestamps and sequence numbers, without the actual text content. - Added recursive text extraction to handle nested tags in TTML files.(e.g.: <span> tags)
[Bug] Long-pressing Play All-button does nothing
- audioTrackTextView: layout_width=0dp + layout_weight=1 - Make it singleLine with ellipsize="end" - When not fullscreen, hide metadataView so an empty weighted container doesn’t reserve space - Result: controls stay visible on small screens; longer labels can use space on larger screens
Fix Long Audio/Dubs text label puses UI Controls on Player Off Screen in Portrait mode.
This reverts commit 1db1a00. The issue has been long resolved making this fix no longer required.
Ref: https://developer.android.com/build/migrate-to-kotlin-dsl Signed-off-by: Aayush Gupta <[email protected]>
Ref: https://developer.android.com/build/migrate-to-catalogs Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
…characters - Replaced `text()` with `getWholeText()`: - avoids losing whitespaces at the beginning, end, or within the text; - avoids merging two or more consecutive spaces into a single space ' '; - avoids converting '\r', '\n', and '\r\n' within the text into a single space ' '; For subtitle conversion, the goal is to preserve every character exactly as intended by the subtitle author. - Normalized tabs, line breaks, and other special characters for SRT-safe output. - Added comprehensive unit tests in `SrtFromTtmlWriterTest.java`, including cases for simple and nested tags.
…gs()` - Extracted child-node traversal logic from `extractText()` into a helper method `traverseChildNodesForNestedTags()`. - No functional change.
Specifying JDK toolchain in the java block lets us avoid specifying same version again and again for different options while ensuring everything is on the same version Ref: https://developer.android.com/build/jdks#toolchain Signed-off-by: Aayush Gupta <[email protected]>
Otherwise it constantly switches the attributes which makes (re) viewing changes next to impossible
This fulfills the following: * both should never push content outside of the view * there should be no wasted space * `audioTrackTextView` is always aligned to the right * both should grow equally but also respect their respective contents size first Caveats: * Currently the layout weight is distributed using "NestedWeights" which require a widget to be measured twice. According to Android Studio this might cause an exponential performane impact, however there is currently just a single nested component so the effect should be not noticeable
This is done by the parent
Updating checkstyle fixed a vulnerability and fixed a final class check in version 10.12.2 for local classes without constructor. Local classes without a constructor should be marked as final. That is done in this commit. For more info see https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.12.2
androidx.media:media:1.7.0 -> 1.7.1 androidx.viewpager2:viewpager2:1.1.0-beta02 -> 1.1.0 io.reactivex.rxjava3:rxjava:3.1.8 -> 3.1.12 org.jsoup:jsoup:1.17.2 -> 1.21.2
The comments were accidentally removed in TeamNewPipe#12706
…ayer-ui-elements-being-pushed-out
The lastUpdated parameter can be null, adjust return types to signal that too Signed-off-by: Aayush Gupta <[email protected]>
The defaults should be supplied to the image loading software not the database library. This would also break when we shrink resources as that would rename the resources. Signed-off-by: Aayush Gupta <[email protected]>
Fixes [ksp] app/src/main/java/org/schabi/newpipe/database/playlist/dao/PlaylistStreamDAO.kt:140: The columns returned by the query does not have the fields [thumbnailUrl,isThumbnailPermanent,thumbnailStreamId,displayIndex,orderingName] in org.schabi.newpipe.database.playlist.PlaylistDuplicatesEntry even though they are annotated as non-null or primitive. Columns returned by the query: [uid,streamCount,timesStreamIsContained] Signed-off-by: Aayush Gupta <[email protected]>
Migrate from KAPT to KSP
Currently translated at 50.0% (43 of 86 strings) Translated using Weblate (Hebrew) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Hebrew) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Spanish) Currently translated at 98.6% (754 of 764 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Lombard) Currently translated at 0.2% (2 of 764 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 72.0% (62 of 86 strings) Added translation using Weblate (Lombard) Translated using Weblate (Korean) Currently translated at 97.6% (84 of 86 strings) Translated using Weblate (Danish) Currently translated at 97.9% (748 of 764 strings) Translated using Weblate (Romanian) Currently translated at 97.9% (748 of 764 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Latvian) Currently translated at 95.6% (731 of 764 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 99.8% (763 of 764 strings) Translated using Weblate (Dutch (Belgium)) Currently translated at 73.8% (564 of 764 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Portuguese) Currently translated at 99.8% (763 of 764 strings) Translated using Weblate (Georgian) Currently translated at 92.8% (709 of 764 strings) Translated using Weblate (Georgian) Currently translated at 89.5% (77 of 86 strings) Translated using Weblate (Thai) Currently translated at 3.4% (3 of 86 strings) Translated using Weblate (Thai) Currently translated at 37.1% (284 of 764 strings) Translated using Weblate (Catalan) Currently translated at 96.3% (736 of 764 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Slovenian) Currently translated at 53.0% (405 of 764 strings) Translated using Weblate (Thai) Currently translated at 36.7% (281 of 764 strings) Translated using Weblate (Thai) Currently translated at 2.3% (2 of 86 strings) Translated using Weblate (Croatian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Belarusian) Currently translated at 98.9% (756 of 764 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Bulgarian) Currently translated at 5.8% (5 of 86 strings) Translated using Weblate (Bulgarian) Currently translated at 5.8% (5 of 86 strings) Translated using Weblate (Bosnian) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Bosnian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 90.6% (78 of 86 strings) Translated using Weblate (Serbian) Currently translated at 16.2% (14 of 86 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Croatian) Currently translated at 95.4% (729 of 764 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Arabic) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Serbian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Italian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Icelandic) Currently translated at 98.4% (752 of 764 strings) Translated using Weblate (Chinese (Traditional Han script, Hong Kong)) Currently translated at 36.0% (31 of 86 strings) Translated using Weblate (German) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Belarusian) Currently translated at 97.1% (742 of 764 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Hebrew) Currently translated at 99.0% (757 of 764 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Polish) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Czech) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Greek) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Portuguese) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Korean) Currently translated at 98.6% (754 of 764 strings) Translated using Weblate (Russian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Serbian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (French) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (German) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (French) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 69.7% (60 of 86 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (French) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Polish) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Czech) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Greek) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (French) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (German) Currently translated at 100.0% (759 of 759 strings) Translated using Weblate (Kabyle) Currently translated at 28.1% (212 of 754 strings) Translated using Weblate (Russian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Icelandic) Currently translated at 99.2% (748 of 754 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (German) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Vietnamese) Currently translated at 99.6% (751 of 754 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Italian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Vietnamese) Currently translated at 99.6% (751 of 754 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Russian) Currently translated at 99.3% (749 of 754 strings) Translated using Weblate (Tigrinya) Currently translated at 20.1% (152 of 754 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Tigrinya) Currently translated at 18.1% (137 of 754 strings) Translated using Weblate (Czech) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (German) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (German) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Tigrinya) Currently translated at 17.3% (131 of 754 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Polish) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Polish) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Greek) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (French) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (French) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (German) Currently translated at 99.8% (753 of 754 strings) Translated using Weblate (German) Currently translated at 99.8% (753 of 754 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Arabic) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Czech) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Tigrinya) Currently translated at 15.6% (118 of 754 strings) Translated using Weblate (English (United Kingdom)) Currently translated at 9.3% (8 of 86 strings) Translated using Weblate (English (United Kingdom)) Currently translated at 8.8% (67 of 754 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 98.8% (85 of 86 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Vietnamese) Currently translated at 79.0% (68 of 86 strings) Translated using Weblate (Portuguese) Currently translated at 98.8% (85 of 86 strings) Translated using Weblate (Greek) Currently translated at 36.0% (31 of 86 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Sardinian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Vietnamese) Currently translated at 97.3% (734 of 754 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 99.2% (748 of 754 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Polish) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Czech) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Czech) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Greek) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Greek) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (French) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (754 of 754 strings) Translated using Weblate (Russian) Currently translated at 100.0% (86 of 86 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (748 of 748 strings) Co-authored-by: 404px <[email protected]> Co-authored-by: 439JBYL80IGQTF25UXNR0X1BG <[email protected]> Co-authored-by: Agnieszka C <[email protected]> Co-authored-by: Ajeje Brazorf <[email protected]> Co-authored-by: Alex25820 <[email protected]> Co-authored-by: ButterflyOfFire <[email protected]> Co-authored-by: CJ Montero <[email protected]> Co-authored-by: DB L <[email protected]> Co-authored-by: Daniel Mantilla <[email protected]> Co-authored-by: Dizro <[email protected]> Co-authored-by: Drugi Sapog <[email protected]> Co-authored-by: EESF-2 <[email protected]> Co-authored-by: Emin Tufan Çetin <[email protected]> Co-authored-by: Femini <[email protected]> Co-authored-by: Fjuro <[email protected]> Co-authored-by: FrederikFinckh <[email protected]> Co-authored-by: Ghost of Sparta <[email protected]> Co-authored-by: Hasan <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Hoàng Sơn <[email protected]> Co-authored-by: Igor Rückert <[email protected]> Co-authored-by: Ihor Hordiichuk <[email protected]> Co-authored-by: J. Lavoie <[email protected]> Co-authored-by: Jeff Huang <[email protected]> Co-authored-by: Linerly <[email protected]> Co-authored-by: MS-PC <[email protected]> Co-authored-by: Maria Dimitrova <[email protected]> Co-authored-by: Matija Šuklje <[email protected]> Co-authored-by: Mickaël Binos <[email protected]> Co-authored-by: Milan <[email protected]> Co-authored-by: Mona Lisa <[email protected]> Co-authored-by: NEXI <[email protected]> Co-authored-by: Nick Wick <[email protected]> Co-authored-by: Nikoloz <[email protected]> Co-authored-by: Philip Goto <[email protected]> Co-authored-by: Priit Jõerüüt <[email protected]> Co-authored-by: Random <[email protected]> Co-authored-by: René <[email protected]> Co-authored-by: Rex_sa <[email protected]> Co-authored-by: Ricard Rodríguez <[email protected]> Co-authored-by: Sarah O <[email protected]> Co-authored-by: SecularSteve <[email protected]> Co-authored-by: Sveinn í Felli <[email protected]> Co-authored-by: ThaiWithNoBraincell <[email protected]> Co-authored-by: The Cats <[email protected]> Co-authored-by: Trunars <[email protected]> Co-authored-by: Tấn Lực Trương <[email protected]> Co-authored-by: Valer <[email protected]> Co-authored-by: Vasilis K <[email protected]> Co-authored-by: VfBFan <[email protected]> Co-authored-by: VisionR1 <[email protected]> Co-authored-by: Xiao Ping <[email protected]> Co-authored-by: Yaron Shahrabani <[email protected]> Co-authored-by: cat <[email protected]> Co-authored-by: delvani <[email protected]> Co-authored-by: fool <[email protected]> Co-authored-by: gbpu <[email protected]> Co-authored-by: ikanakova <[email protected]> Co-authored-by: justcontributor <[email protected]> Co-authored-by: late <[email protected]> Co-authored-by: nafanz <[email protected]> Co-authored-by: rehork <[email protected]> Co-authored-by: ssantos <[email protected]> Co-authored-by: sudo-py-dev <[email protected]> Co-authored-by: tct123 <[email protected]> Co-authored-by: yummysheepouo <[email protected]> Co-authored-by: Максим Горпиніч <[email protected]> Co-authored-by: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <[email protected]> Co-authored-by: 大王叫我来巡山 <[email protected]> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/bg/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/bs/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/el/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/en_GB/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/id/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ka/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ko/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pt/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pt_BR/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pt_PT/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ru/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sv/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/th/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/tr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/vi/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hant_HK/ Translation: NewPipe/Metadata
Added a note to target the 'refactor' branch for features.
Signed-off-by: Aayush Gupta <[email protected]>
The StreamHistoryDao one isn't used, so remove it and streamline the logic Signed-off-by: Aayush Gupta <[email protected]>
java.lang.IllegalStateException: Cannot access database on the main thread since it may potentially lock the UI for a long period of time. Signed-off-by: Aayush Gupta <[email protected]>
Minor fixes for database
…tures Update PR template to specify target branch for features
statesaver has been deprecated for ~ 6 years and incompatible with KSP Signed-off-by: Aayush Gupta <[email protected]>
Partial-revert: Migrate from KAPT to KSP
Also update the wrapper using the ./gradlew wrapper command Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
androidx has bumped minSdk to API 23 which makes us unable to use latest version of: * room * workmanager Signed-off-by: Aayush Gupta <[email protected]>
Fixes build errors after Gradle 9.x upgrade Ref: https://docs.gradle.org/current/userguide/implementing_custom_tasks.html Signed-off-by: Aayush Gupta <[email protected]>
Disable all new rules to avoid massive file-changes. All new rules should be enabled one by one as per requirements in separate commit to make review easier. Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
5 tasks
TobiGr
approved these changes
Nov 29, 2025
ShareASmile
added
the
codequality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This merges dev back to refactor after the big amount of changes that happened to
devrecently (e.g. #12706 #12746 #12776 ). I had to basically rewritelibs.versions.tomlin the merge commit because the two files in the two branches had different naming and formatting. I did not push this directly as it's quite a huge commit, but there's not much to review, so feel free to merge directly after the CI succeeds.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence