Update all included dependencies #12776
Conversation
Also update the wrapper using the ./gradlew wrapper command Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
|
I will make a separate PR to enable new ktlint rules as well as to enable android's default lint which is currently set to ignore errors. |
|
Some of the dependencies updated here such as kotlin are already updated in refactor branch but not all. I am hoping to have all dependencies on latest stable release as they might contain fixes for compose, kotlin or ksp in general. |
theimpulson
force-pushed
the
depUpdate
branch
2 times, most recently
from
1aea837 to
16b21f0
Compare
There was a problem hiding this comment.
Thank you for the PR! Usually when we do dependency updates we try to look into the changelogs to make sure there are no regressions, I left a comment about this below.
Uff what a shame that androidx is dropping support for API 21... we can keep an outdated library for some time, but we'll have to switch at some point I guess. We'll lose 0.6% of devices (see below) when bumping to API 23 (or possibly more since many users install newpipe on old phones). For now, please add a comment to the two versions that we can't update in libs.versions.toml, so we don't forget.
I tested the debug APK for some time and everything seems to still work, except for a subtle bug: when importing a database which contains a channel group feed in the main page, its icon turns into three dots. This does not happen on nightly.
There was a problem hiding this comment.
I am a bit worried by all of these upgrades at once. Have you gone through the various changelogs to see if there's anything to worry about? In particular, I'm worried about exoplayer, okhttp.
There was a problem hiding this comment.
I have. In particular exoplayer has been deprecated with replacement being media3 which we already are using the latest version. okhttp's major change was support for happy eyeballs and improving kotlin APIs which aren't breaking ones. The most major change was with ktlint which has a separate commit disabling all the new rules to enable them one by one in different PR.
theimpulson
force-pushed
the
depUpdate
branch
from
16b21f0 to
68360b0
Compare
github-actions
bot
added
size/large
Done. I think we can bump up the minSdk after the next release to import compose libs as that has more frequent releases every month and are part of androidx framework too which will make it a blocker.
I am unable to reproduce this on my side. is it possible to change the feed icon manually? Maybe there is something related to that? |
androidx has bumped minSdk to API 23 which makes us unable to use latest version of: * room * workmanager Signed-off-by: Aayush Gupta <[email protected]>
Fixes build errors after Gradle 9.x upgrade Ref: https://docs.gradle.org/current/userguide/implementing_custom_tasks.html Signed-off-by: Aayush Gupta <[email protected]>
Disable all new rules to avoid massive file-changes. All new rules should be enabled one by one as per requirements in separate commit to make review easier. Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
The StreamHistoryDao one isn't used, so remove it and streamline the logic Signed-off-by: Aayush Gupta <[email protected]>
theimpulson
force-pushed
the
depUpdate
branch
from
f863dc6 to
c399fd9
Compare
java.lang.IllegalStateException: Cannot access database on the main thread since it may potentially lock the UI for a long period of time. Signed-off-by: Aayush Gupta <[email protected]>
|
I noticed a crash during exporting database due to checkpoint being called on main thread so made a commit to fix that. This probably should have been part of the database migration to kotlin PR. |
|
Marking as draft to allow database related fixes go first to avoid polluting this PR |
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence