Skip to content

Minor fixes for database#12816

Merged
Stypox merged 3 commits intodevfrom
dbFix
Nov 18, 2025
Merged

Minor fixes for database#12816
Stypox merged 3 commits intodevfrom
dbFix

Conversation

@theimpulson
Copy link
Copy Markdown
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Makes latestEntry of history nullable
  • Fixes the issue of creating checkpoint in database being called from main thread

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
The StreamHistoryDao one isn't used, so remove it and streamline the logic

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
java.lang.IllegalStateException: Cannot access database on the main thread since it may potentially lock the UI for a long period of time.

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
@theimpulson theimpulson requested review from Stypox and TobiGr November 18, 2025 04:13
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Nov 18, 2025
@theimpulson
Copy link
Copy Markdown
Member Author

These changes are required after #12746. I discovered them while working on #12776 and decided to separate them as they are unrelated.

Copy link
Copy Markdown
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Stypox Stypox merged commit 153e482 into dev Nov 18, 2025
6 checks passed
@TobiGr TobiGr deleted the dbFix branch November 18, 2025 08:20
@TobiGr TobiGr mentioned this pull request Dec 21, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants