Conversation
Stypox
requested changes
Nov 19, 2025
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thanks! Yeah it seems like there is no drop-in replacement for evernote.statesaver available online, so we need to keep it until we finish migrating everything to Compose.
Could you add comments explaining why we are still using kapt there?
statesaver has been deprecated for ~ 6 years and incompatible with KSP Signed-off-by: Aayush Gupta <[email protected]>
Member
Author
Done, also added a TODO reminder to drop statesaver library |
TobiGr
approved these changes
Nov 19, 2025
| rxjava = "3.1.12" | ||
| sonarqube = "4.0.0.2929" | ||
| statesaver = "1.4.1" | ||
| statesaver = "1.4.1" # TODO: Drop because it is deprecated and incompatible with KSP2 |
Contributor
There was a problem hiding this comment.
Please open an issue for that and add it to the rewrite project so that we do not forget about it.
Stypox
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence