[Bug] Long-pressing Play All-button does nothing#12692
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Oct 10, 2025
Merged
[Bug] Long-pressing Play All-button does nothing#12692TobiGr merged 1 commit intoTeamNewPipe:devfrom
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Conversation
Contributor
|
Hello and welcome! I assume by looking at your fork's name that your contribution is part of the anual ANU comp2120 OSS assignement. Is that correct? |
TobiGr
approved these changes
Oct 10, 2025
Contributor
TobiGr
left a comment
There was a problem hiding this comment.
Happy contributing and thank you for the fix! That was a good catch. Well done! It looks like this was forgotten during a refactoring. The code looks good and works as expected.
If you are familiar with git, please reword your commit to follow the conventional commits specification.
Contributor
Author
|
Hello TobiGr, I've made an appropriate modification for the commit. |
Contributor
|
Thank you. Please squash your three commits into a single one and force-push that commit to your branch. After that, we are good to go. |
Contributor
Author
|
Hi TobiGr, I have combined my commits as your request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… nothing
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence