Skip to content

[Bug] Long-pressing Play All-button does nothing#12692

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Zer0tier:issue#12433
Oct 10, 2025
Merged

[Bug] Long-pressing Play All-button does nothing#12692
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Zer0tier:issue#12433

Conversation

@Zer0tier
Copy link
Contributor

@Zer0tier Zer0tier commented Oct 9, 2025

… nothing

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Added the long click listener in the relevant class, which resolved the bug of "Long-pressing does not work".

Before/After Screenshots/Screen Record

  • Before: long pressing does not work on enqueuing
3b34c7868a8c8e9d285e5c689accf1c
  • After: long pressing will enqueue the whole playlist
885e4112318aa32a25752b6d1251672

Fixes the following issue(s)

Relies on the following changes

  • Added relevant modification in 'PlayerButtonHelper.java' to recover the implementation of long click listener.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Oct 9, 2025
@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Oct 9, 2025
@TobiGr
Copy link
Contributor

TobiGr commented Oct 9, 2025

Hello and welcome!

I assume by looking at your fork's name that your contribution is part of the anual ANU comp2120 OSS assignement. Is that correct?

@TobiGr TobiGr changed the title issue#12433 has now been resolved: Long-pressing Play All-button does… Fixed: Long-pressing Play All-button does nothing Oct 9, 2025
@TobiGr TobiGr changed the title Fixed: Long-pressing Play All-button does nothing [Bug] Long-pressing Play All-button does nothing Oct 9, 2025
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy contributing and thank you for the fix! That was a good catch. Well done! It looks like this was forgotten during a refactoring. The code looks good and works as expected.

If you are familiar with git, please reword your commit to follow the conventional commits specification.

@Zer0tier
Copy link
Contributor Author

Hello TobiGr, I've made an appropriate modification for the commit.

@TobiGr
Copy link
Contributor

TobiGr commented Oct 10, 2025

Thank you. Please squash your three commits into a single one and force-push that commit to your branch. After that, we are good to go.

@Zer0tier
Copy link
Contributor Author

Hi TobiGr, I have combined my commits as your request.

@TobiGr TobiGr enabled auto-merge October 10, 2025 15:05
@TobiGr TobiGr merged commit eee1172 into TeamNewPipe:dev Oct 10, 2025
5 checks passed
@TobiGr TobiGr self-assigned this Oct 11, 2025
@TobiGr TobiGr mentioned this pull request Dec 21, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug GUI Issue is related to the graphical user interface size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long-pressing "Play All"-button does nothing

2 participants