Skip to content

Conversation

@David-Henner
Copy link
Contributor

@David-Henner David-Henner commented Dec 5, 2025

TaskWPB-22227 [iOS] Remove `cryptoboxMigrationManager`

Issue

This PR is part of a larger effort to remove cryptobox and rely only on core crypto.

  1. chore(cryptobox): retire ProteusProvider - WPB-21821 #3903
  2. chore(cryptobox): remove proteusViaCoreCrypto flag - WPB-14604 #3954
  3. chore(cryptobox): remove keyStore - WPB-7393 #3955
  4. chore(cryptobox): remove cryptobox framework - WPB-7394 #3965

In this PR we remove the CryptoboxMigrationManager


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

…wireapp/wire-ios into chore/retire-proteus-provider-WPB-21821
# Conflicts:
#	wire-ios-request-strategy/Tests/Sources/Notifications/PushNotifications/ZMLocalNotificationTests_Message.swift
# Conflicts:
#	wire-ios-data-model/Tests/Source/Model/UserClient/UserClientKeyStoreTests.swift
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Test Results

    5 files    647 suites   20m 15s ⏱️
5 345 tests 5 344 ✅ 0 💤 1 ❌
5 346 runs  5 346 ✅ 0 💤 0 ❌

For more details on these failures, see this check.

Results for commit 7f9f2bf.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@samwyndham samwyndham removed their request for review December 12, 2025 13:25
Base automatically changed from chore/remove-cryptobox-framework-WPB-7394 to develop December 14, 2025 19:27
…WPB-22227

# Conflicts:
#	WireDomain/Sources/WireDomain/Notifications/Components/Legacy/PullEventsStep.swift
#	WireDomain/Sources/WireDomain/Notifications/Components/Legacy/SyncEventsStep.swift
#	WireDomain/Sources/WireDomain/Notifications/Components/NSEUserScope.swift
#	WireMessaging/Sources/WireMessagingDomain/WireCells/Protocols/WireCellsEditingURLRepositoryProtocol.swift
#	WireMessaging/Sources/WireMessagingDomain/WireCells/Protocols/WireCellsRestoreNodesUseCaseProtocol.swift
#	WireMessaging/Sources/WireMessagingDomain/WireCells/UseCases/WireCellsNodesCollection.swift
#	WireMessaging/Sources/WireMessagingUI/WireCells/Components/Common/WireCellsNode+Convenience.swift
#	WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/CreateFolderCTA.swift
#	wire-ios-data-model/Source/Proteus/CryptoboxMigrationManager.swift
#	wire-ios-data-model/Tests/Core Crypto/CoreCryptoConfigProviderTests.swift
#	wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj
#	wire-ios-notification-engine/Sources/LegacyNotificationSessionLoader.swift
#	wire-ios-notification-engine/Sources/NotificationSession.swift
#	wire-ios-notification-engine/WireNotificationEngine.xcodeproj/project.pbxproj
#	wire-ios-notification-engine/WireNotificationEngineTests/BaseNotificationSessionTests.swift
#	wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoder.swift
#	wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoderTest.swift
#	wire-ios-request-strategy/Tests/Helpers/MessagingTestBase.swift
#	wire-ios-request-strategy/Tests/Helpers/ProteusClientSimulator.swift
#	wire-ios-request-strategy/Tests/Sources/Notifications/PushNotifications/ZMLocalNotificationTests_Event.swift
#	wire-ios-utilities/Source/DeveloperFlag.swift
#	wire-ios/Wire-iOS.xcodeproj/project.pbxproj
#	wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/Content/Text/ConversationTextMessageCell.swift
@David-Henner David-Henner added this pull request to the merge queue Dec 15, 2025
Merged via the queue into develop with commit a7c40dc Dec 15, 2025
14 checks passed
@David-Henner David-Henner deleted the chore/remove-cryptobox-migration-manager-WPB-22227 branch December 15, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants