chore(cryptobox): remove keyStore - WPB-7393 #3955
Merged
+91
−879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wireapp/wire-ios into chore/retire-proteus-provider-WPB-21821
# Conflicts: # wire-ios-request-strategy/Tests/Sources/Notifications/PushNotifications/ZMLocalNotificationTests_Message.swift
Contributor
Test Results 3 files 515 suites 23m 12s ⏱️ For more details on these failures, see this check. Results for commit 766591e. ♻️ This comment has been updated with latest results. |
KaterinaWire
reviewed
Dec 1, 2025
...-strategy/Tests/Sources/Notifications/PushNotifications/ZMLocalNotificationTests_Event.swift
Outdated
Show resolved
Hide resolved
KaterinaWire
reviewed
Dec 1, 2025
wire-ios-data-model/Tests/Core Crypto/CoreCryptoConfigProviderTests.swift
Outdated
Show resolved
Hide resolved
netbe
approved these changes
Dec 2, 2025
Collaborator
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
looks good, left a question though
KaterinaWire
approved these changes
Dec 2, 2025
3 tasks
3 tasks
Base automatically changed from
chore/remove-proteusViaCoreCrypto-flag-WPB-14604
to
develop
December 11, 2025 14:26
# Conflicts: # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Common/WireCellsNode+Convenience.swift # wire-ios-data-model/Source/Proteus/CryptoboxMigrationManager.swift # wire-ios-data-model/Tests/Proteus/CryptoboxMigrationManagerTests.swift # wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoder.swift # wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoderTest.swift # wire-ios-utilities/Source/DeveloperFlag.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR is part of a larger effort to remove cryptobox and rely only on core crypto.
ProteusProvider- WPB-21821 #3903, we remove the ProteusProvider.proteusViaCorCryptoFlagIn this PR we remove the
UserClientKeyStoreChecklist
[WPB-XXX].