chore(cryptobox): remove cryptobox framework - WPB-7394 #3965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wireapp/wire-ios into chore/retire-proteus-provider-WPB-21821
# Conflicts: # wire-ios-request-strategy/Tests/Sources/Notifications/PushNotifications/ZMLocalNotificationTests_Message.swift
# Conflicts: # wire-ios-data-model/Tests/Source/Model/UserClient/UserClientKeyStoreTests.swift
Contributor
Test Results 7 files 980 suites 21m 55s ⏱️ For more details on these failures, see this check. Results for commit f79a37c. ♻️ This comment has been updated with latest results. |
3 tasks
netbe
approved these changes
Dec 9, 2025
Collaborator
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
looks good, although left a couple questions
wire-ios-data-model/Source/ManagedObjectContext/NSManagedObjectContext+EncryptionAtRest.swift
Show resolved
Hide resolved
...figurationMessageCell/Components/ConversationCannotDecryptSystemMessageCellDescription.swift
Show resolved
Hide resolved
KaterinaWire
approved these changes
Dec 11, 2025
# Conflicts: # WireMessaging/Sources/WireMessagingDomain/WireCells/Protocols/WireCellsEditingURLRepositoryProtocol.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Common/WireCellsNode+Convenience.swift # wire-ios-data-model/Source/ManagedObjectContext/NSManagedObjectContext+AccountDirectory.swift # wire-ios-data-model/Source/Proteus/CryptoboxMigrationManager.swift # wire-ios-data-model/Tests/Core Crypto/CoreCryptoConfigProviderTests.swift # wire-ios-data-model/Tests/Proteus/CryptoboxMigrationManagerTests.swift # wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoder.swift # wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoderTest.swift # wire-ios-request-strategy/Tests/Sources/Notifications/PushNotifications/ZMLocalNotificationTests_Event.swift # wire-ios-utilities/Source/DeveloperFlag.swift
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
David-Henner
commented
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR is part of a larger effort to remove cryptobox and rely only on core crypto.
ProteusProvider- WPB-21821 #3903Changes in this PR:
wire-ios-cryptoboxframeworkChecklist
[WPB-XXX].