Skip to content

chore(cryptobox): remove proteusViaCoreCrypto flag - WPB-14604 - #3954

Merged
David-Henner merged 33 commits into
developfrom
chore/remove-proteusViaCoreCrypto-flag-WPB-14604
Dec 11, 2025
Merged

chore(cryptobox): remove proteusViaCoreCrypto flag - WPB-14604#3954
David-Henner merged 33 commits into
developfrom
chore/remove-proteusViaCoreCrypto-flag-WPB-14604

Conversation

@David-Henner

@David-Henner David-Henner commented Nov 28, 2025

Copy link
Copy Markdown
Contributor
TaskWPB-14604 [iOS] Remove DeveloperFlags.proteusViaCoreCrypto

Issue

This PR is part of a larger effort to remove cryptobox and rely only on core crypto. The first PR of the series is #3903, where we remove the ProteusProvider.

Here we remove the proteusViaCoreCrypto flag


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@github-actions

github-actions Bot commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

Test Results

    7 files    871 suites   23m 53s ⏱️
7 043 tests 7 015 ✅ 27 💤 1 ❌
7 054 runs  7 027 ✅ 27 💤 0 ❌

For more details on these failures, see this check.

Results for commit 5658cb2.

♻️ This comment has been updated with latest results.

@netbe netbe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wire-ios-build-assets submodule should be changed, left some minor todos

Comment thread wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoderTest.swift Outdated
Comment thread wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoderTest.swift Outdated
Comment thread wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoderTest.swift Outdated
Comment thread wire-ios-request-strategy/Sources/Synchronization/Decoding/EventDecoderTest.swift Outdated
Comment thread wire-ios/Configuration/Developer-Flags.xcconfig
Base automatically changed from chore/retire-proteus-provider-WPB-21821 to develop December 4, 2025 17:31

@netbe netbe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 5, 2025
@David-Henner
David-Henner added this pull request to the merge queue Dec 5, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 5, 2025
@David-Henner
David-Henner added this pull request to the merge queue Dec 8, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 8, 2025
@David-Henner
David-Henner added this pull request to the merge queue Dec 8, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 8, 2025
@David-Henner
David-Henner added this pull request to the merge queue Dec 9, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@David-Henner
David-Henner added this pull request to the merge queue Dec 9, 2025
@David-Henner
David-Henner removed this pull request from the merge queue due to a manual request Dec 9, 2025
@David-Henner
David-Henner added this pull request to the merge queue Dec 11, 2025
Merged via the queue into develop with commit 60851dc Dec 11, 2025
16 checks passed
@David-Henner
David-Henner deleted the chore/remove-proteusViaCoreCrypto-flag-WPB-14604 branch December 11, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants