chore(cryptobox): remove proteusViaCoreCrypto flag - WPB-14604

wire-ios-data-model/Source/ManagedObjectContext/CoreDataStack.swift

@@ -369,7 +369,7 @@
 
     func configureViewContext(_ context: NSManagedObjectContext) async {
         context.markAsUIContext()
         await context.perform {
             context.localDomain = self.localDomain
             context.isFederationEnabled = self.isFederationEnabled
             context.createDispatchGroups()
@@ -381,17 +381,17 @@
     }
 
     func configureContextReferences() async {
         await viewContext.perform {
             self.viewContext.zm_sync = self.syncContext
         }
         await syncContext.perform {
             self.syncContext.zm_userInterface = self.viewContext
         }
     }
 
     func configureSyncContext(_ context: NSManagedObjectContext) async {
         context.markAsSyncContext()
         await context.perform {
             context.localDomain = self.localDomain
             context.isFederationEnabled = self.isFederationEnabled
             context.createDispatchGroups()
@@ -401,13 +401,6 @@
             context.accountDirectoryURL = self.accountContainer
             context.applicationContainerURL = self.applicationContainer
 
-            if !DeveloperFlag.proteusViaCoreCrypto.isOn {
-                context.setupUserKeyStore(
-                    accountDirectory: self.accountContainer,
-                    applicationContainer: self.applicationContainer
-                )
-            }
-
             context.undoManager = nil
             context.mergePolicy = NSMergePolicy(merge: .mergeByPropertyObjectTrumpMergePolicyType)
 
@@ -417,7 +410,7 @@
 
     func configureSearchContext(_ context: NSManagedObjectContext) async {
         context.markAsSearch()
         await context.perform {
             context.localDomain = self.localDomain
             context.isFederationEnabled = self.isFederationEnabled
             context.createDispatchGroups()
@@ -430,7 +423,7 @@
 
     func configureEventContext(_ context: NSManagedObjectContext) async {
         await context.perform {
             context.createDispatchGroups()
             self.dispatchGroup.map(context.addGroup(_:))
         }
     }
@@ -559,7 +552,7 @@
 }
 
 // MARK: -
 
 public class PersistentContainer: NSPersistentContainer {
 
     var storeURL: URL? {

wire-ios-data-model/Source/Proteus/CryptoboxMigrationManager.swift

@@ -60,9 +60,8 @@ public class CryptoboxMigrationManager: CryptoboxMigrationManagerInterface {
     // MARK: - Methods
 
     public func isMigrationNeeded(accountDirectory: URL) -> Bool {
-        guard DeveloperFlag.proteusViaCoreCrypto.isOn else { return false }
-        let cryptoboxDirectory = fileManager.cryptoboxDirectory(in: accountDirectory)
-        return fileManager.fileExists(atPath: cryptoboxDirectory.path)
+        // disabling migration. This will be removed completely in https://wearezeta.atlassian.net/browse/WPB-22227
+        false
     }
 
     public func performMigration(

wire-ios-data-model/Tests/Source/Model/Conversation/ZMConversationLastMessagesTest.swift

@@ -23,19 +23,6 @@ import XCTest
 
 class ZMConversationLastMessagesTest: ZMBaseManagedObjectTest {
 
-    override class func setUp() {
-        DeveloperFlag.storage = UserDefaults(suiteName: UUID().uuidString)!
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = false
-
-        super.setUp()
-    }
-
-    override class func tearDown() {
-        super.tearDown()
-        DeveloperFlag.storage = UserDefaults.standard
-    }
-
     func createConversation(on moc: NSManagedObjectContext? = nil) -> ZMConversation {
         let conversation = ZMConversation.insertNewObject(in: moc ?? uiMOC)
         conversation.remoteIdentifier = UUID()

wire-ios-data-model/Tests/Source/Model/Messages/CacheAssetTests.swift

@@ -21,18 +21,6 @@ import XCTest
 
 class CacheAssetTests: BaseZMAssetClientMessageTests {
 
-    override class func setUp() {
-        super.setUp()
-        DeveloperFlag.storage = UserDefaults(suiteName: UUID().uuidString)!
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = false
-    }
-
-    override class func tearDown() {
-        super.tearDown()
-        DeveloperFlag.storage = UserDefaults.standard
-    }
-
     // MARK: - Fixtures
 
     func fileAsset() -> WireDataModel.CacheAsset {

wire-ios-data-model/Tests/Source/Model/Messages/ZMClientMessageTests+MLSEncryptedPayloadGenerator.swift

@@ -23,19 +23,6 @@ import GenericMessageProtocol
 
 final class ZMClientMessageTests_MLSEncryptedPayloadGenerator: BaseZMClientMessageTests {
 
-    override func setUp() {
-        DeveloperFlag.storage = UserDefaults(suiteName: UUID().uuidString)!
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = true
-
-        super.setUp()
-    }
-
-    override func tearDown() {
-        super.tearDown()
-        DeveloperFlag.storage = UserDefaults.standard
-    }
-
     let encryptionFunction: (Data) throws -> Data = {
         $0.zmSHA256Digest()
     }

wire-ios-data-model/Tests/Source/Model/Messages/ZMClientMessageTests.swift

@@ -23,18 +23,6 @@ import XCTest
 
 final class ClientMessageTests: BaseZMClientMessageTests {
 
-    override static func setUp() {
-        super.setUp()
-        DeveloperFlag.storage = UserDefaults(suiteName: UUID().uuidString)!
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = false
-    }
-
-    override static func tearDown() {
-        super.tearDown()
-        DeveloperFlag.storage = UserDefaults.standard
-    }
-
     func testThatItDoesNotCreateTextMessagesFromUpdateEventIfThereIsAlreadyAClientMessageWithTheSameNonce() {
         // given
         let nonce = UUID.create()

wire-ios-data-model/Tests/Source/Model/PermissionsTests.swift

@@ -21,18 +21,6 @@ import WireTesting
 
 class PermissionsTests: BaseZMClientMessageTests {
 
-    override class func setUp() {
-        super.setUp()
-        DeveloperFlag.storage = UserDefaults(suiteName: UUID().uuidString)!
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = false
-    }
-
-    override class func tearDown() {
-        super.tearDown()
-        DeveloperFlag.storage = UserDefaults.standard
-    }
-
     private let allPermissions: Permissions = [
         .createConversation,
         .deleteConversation,

wire-ios-data-model/Tests/Source/Model/TeamDeletionRuleTests.swift

@@ -21,18 +21,6 @@ import WireTesting
 
 class TeamDeletionRuleTests: BaseZMClientMessageTests {
 
-    override class func setUp() {
-        super.setUp()
-        DeveloperFlag.storage = UserDefaults(suiteName: UUID().uuidString)!
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = false
-    }
-
-    override class func tearDown() {
-        super.tearDown()
-        DeveloperFlag.storage = UserDefaults.standard
-    }
-
     func testThatItDoesntDeleteConversationsWhichArePartOfATeamWhenTeamGetsDeleted() {
         // given
         let team = Team.insertNewObject(in: uiMOC)

wire-ios-data-model/Tests/Source/Model/TextSearchQueryTests.swift

@@ -32,18 +32,6 @@ private class MockTextSearchQueryDelegate: TextSearchQueryDelegate {
 
 class TextSearchQueryTests: BaseZMClientMessageTests {
 
-    override class func setUp() {
-        super.setUp()
-        DeveloperFlag.storage = UserDefaults(suiteName: UUID().uuidString)!
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = false
-    }
-
-    override class func tearDown() {
-        super.tearDown()
-        DeveloperFlag.storage = UserDefaults.standard
-    }
-
     func testThatItOnlyReturnsResultFromTheCorrectConversationNotYetIndexed() {
         // Given
         let conversation = ZMConversation.insertNewObject(in: uiMOC)

wire-ios-data-model/Tests/Source/Model/User/ZMUserLegalHoldTests.swift

@@ -24,18 +24,6 @@ import XCTest
 @preconcurrency
 class ZMUserLegalHoldTests: ModelObjectsTests {
 
-    override func setUp() {
-        DeveloperFlag.storage = .temporary()
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = false
-        super.setUp()
-    }
-
-    override func tearDown() {
-        DeveloperFlag.storage = .standard
-        super.tearDown()
-    }
-
     func testThatLegalHoldStatusIsDisabled_ByDefault() {
         // GIVEN
         let selfUser = ZMUser.selfUser(in: uiMOC)

wire-ios-data-model/Tests/Source/Model/UserClient/UserClientTests.swift

@@ -16,7 +16,6 @@
 // along with this program. If not, see http://www.gnu.org/licenses/.
 //
 
-import WireCryptobox
 import WireUtilities
 import XCTest
 
@@ -25,18 +24,6 @@ import XCTest
 
 final class UserClientTests: ZMBaseManagedObjectTest {
 
-    override static func setUp() {
-        super.setUp()
-        DeveloperFlag.storage = UserDefaults(suiteName: UUID().uuidString)!
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = false
-    }
-
-    override static func tearDown() {
-        super.tearDown()
-        DeveloperFlag.storage = UserDefaults.standard
-    }
-
     func clientWithTrustedClientCount(
         _ trustedCount: UInt,
         ignoredClientCount: UInt,
@@ -169,8 +156,6 @@ final class UserClientTests: ZMBaseManagedObjectTest {
 
     func testThatItDeletesASession() async throws {
         // Given
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = true
         var otherClient: UserClient!
         let mockProteusService = MockProteusServiceInterface()
         mockProteusService.deleteSessionId_MockMethod = { _ in
@@ -195,13 +180,10 @@ final class UserClientTests: ZMBaseManagedObjectTest {
         }
 
         XCTAssert(waitForAllGroupsToBeEmpty(withTimeout: 0.5))
-        flag.isOn = false
     }
 
     func testThatItDeletesASessionWhenDeletingAClient() async {
         // Given
-        var flag = DeveloperFlag.proteusViaCoreCrypto
-        flag.isOn = true
         var otherClient: UserClient!
         var otherClientSessionID: ProteusSessionID!
         let mockProteusService = MockProteusServiceInterface()
@@ -230,7 +212,6 @@ final class UserClientTests: ZMBaseManagedObjectTest {
         }
 
         XCTAssert(waitForAllGroupsToBeEmpty(withTimeout: 0.5))
-        flag.isOn = false
     }
 
     func testThatItUpdatesConversationSecurityLevelWhenDeletingClient() async {