Definition Popover #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression on nightly introduced in zed-industries#36714 Release Notes: - N/A
Release Notes: - N/A
Related zed-industries#4642 Compatible with zed-industries#34136 Release Notes: - Helix: `Shift+R` works as Paste instead of taking you to ReplaceMode - Helix: `g .` goes to last modification place (similar to `. in vim)
…ffective (zed-industries#36760) Closes #ISSUE Release Notes: - The environment of original remote dev cannot be changed without sudo because of the behavior of "sh -c". This PR changes "sh -c" to "sh -lc" to let the shell source $HOME/.profile and support customized environment like customized $PATH variable.
Fixes one more case where I incorrectly tried to use a `\n` escape sequence for a newline in sqlite. Release Notes: - N/A
Release Notes: - N/A
Previously, we wouldn't finalize the diff if an error occurred during editing or the tool call was canceled. Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <[email protected]>
Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <[email protected]>
…ed-industries#36926) Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <[email protected]>
Release Notes: - N/A
Closes zed-industries#29746 | Action | New Key | Old Key | Former Conflict | | - | - | - | - | | `edit_prediction::ToggleMenu` | `ctrl-alt-shift-i` | `ctrl-shift-i` | `editor::Format` | | `editor::ToggleEditPrediction` | `ctrl-alt-shift-e` | `ctrl-shift-e` | `project_panel::ToggleFocus` | These aren't great keys and I'm open to alternate suggestions, but the will work out of the box without conflict. Release Notes: - N/A
Release Notes:
- Added setting for disabling drag and drop in project panel. `{
"project_panel": {"drag_and_drop": false } }`
…36523) `zed::OpenProjectTasks` without an existing tasks.json will recreate it from the template. This file will immediately show a warning. <img width="810" height="168" alt="Screenshot 2025-08-19 at 17 16 07" src="https://github.com/user-attachments/assets/bbc8c7a0-7036-4927-8e85-b81b79aeaacb" /> Release Notes: - N/A
This commit maps `editor::FindAllReferences` to Alt+? in the Emacs keymap. Release Notes: - N/A
…stries#36932) Reverts zed-industries#36722 Release Notes: - N/A
Release Notes: - N/A --------- Co-authored-by: Bennet Bo Fenner <[email protected]>
…es#36917) ## Fix: Preserve Helix mode when using search ### Problem When using `buffer search: deploy` in Helix mode, pressing Enter to dismiss the search incorrectly returned to Vim NORMAL mode instead of Helix NORMAL mode. ### Root Cause The `search_deploy` function was resetting the entire `SearchState` to default values when buffer search: deploy was activated. Since the default `Mode` is `Normal`, this caused `prior_mode` to be set to Vim's Normal mode regardless of the actual mode before search. ### Solution Modified `search_deploy` to preserve the current mode when resetting search state: - Store the current mode before resetting - Reset search state to default - Restore the saved mode to `prior_mode` This ensures the editor returns to the correct mode (Helix NORMAL or Vim NORMAL) after dismissing buffer search. ### Settings I was able to reproduce and then test the fix was successful with the following config and have also tested with vim: default_mode commented out to ensure that's not influencing the mode selection flow: ``` "helix_mode": true, "vim_mode": true, "vim": { "default_mode": "helix_normal" }, ``` This is on Kubuntu 24.04. The following test combinations pass locally: - `cargo test -p search` - `cargo test -p vim` - `cargo test -p editor` - `cargo test -p workspace` - `cargo test -p gpui -- vim` - `cargo test -p gpui -- helix` Release Notes: - Fixed Helix mode switching to Vim normal mode after using `buffer search: deploy` to search Closes zed-industries#36872
…ries#36946) Fixes another case where the sqlite migration could fail, reported by @SomeoneToIgnore. Release Notes: - N/A
Closes zed-industries#36300 This PR follows Windows conventions by introducing `KeybindingKeystroke`, so shortcuts now show up as `ctrl-shift-4` instead of `ctrl-$`. It also fixes issues with keyboard layouts: when `use_key_equivalents` is set to true, keys are remapped based on their virtual key codes. For example, `ctrl-\` on a standard English layout will be mapped to `ctrl-ё` on a Russian layout. Release Notes: - N/A --------- Co-authored-by: Kate <[email protected]>
Release Notes: - N/A --------- Co-authored-by: Conrad Irwin <[email protected]>
Release Notes: - N/A --------- Co-authored-by: Bennet Bo Fenner <[email protected]>
Release Notes: - N/A Co-authored-by: Conrad Irwin <[email protected]>
Release Notes: - Add the `grok-code-fast-1` model to xAI's list of available models.
Release Notes: - N/A
Release Notes: - N/A
…s#36967) This is a pure refactor that consolidates all SSH remoting logic such that it should be straightforward to add another transport to the remoting system. Release Notes: - N/A --------- Co-authored-by: Mikayla Maki <[email protected]>
Release Notes: - N/A
Release Notes: - N/A
Closes zed-industries#36439 and zed-industries#32999 ## C++20 modules: Before (Zed Preview v0.201.3): <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/8eaaf77f-4e27-4a5a-9e87-4e5ba7293990" /> After: <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/df8d0b2c-f2d0-4b0e-9a52-495e6be5a8c0" /> ## C++20 coroutines: Before (Zed Preview v0.201.3): <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/652191ec-a653-444d-a239-da3e4e4b661e" /> After: <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/36947eb5-8997-483a-b36c-8af84872b158" /> ## Logical operators: Before (Zed Preview v0.201.3): <img width="511" height="102" alt="image" src="https://github.com/user-attachments/assets/9bf95bac-b076-4edd-a1f3-c3dfee98c2fd" /> After: <img width="511" height="102" alt="image" src="https://github.com/user-attachments/assets/82c7564d-b94d-41f5-9c48-e39fe3ba3b3e" /> ## Operator keyword: Before (Zed Preview v0.201.3): <img width="591" height="381" alt="image" src="https://github.com/user-attachments/assets/1d9dad05-2d86-4566-97f4-aff440dcd1df" /> After: <img width="591" height="381" alt="image" src="https://github.com/user-attachments/assets/a1ca289a-8a5d-4ffd-96db-0d511405da4b" /> ## Goto: Before (Zed Preview v0.201.3): <img width="610" height="430" alt="image" src="https://github.com/user-attachments/assets/2d00382b-d1ad-4e36-a3ee-88e06ec528ed" /> After: <img width="610" height="430" alt="image" src="https://github.com/user-attachments/assets/de887b21-66f0-4a70-9ed2-e18dbb3c81c9" /> Release Notes: - Enhance keyword highlighting for C++
- **Pass --engine-strict to gemini install command** - **Make it clearer that if upgrading fails, you need to fix i** Closes #ISSUE Release Notes: - N/A
…map (zed-industries#36939) Closes zed-industries#33725 The default bindings for the `editor::NewlineAbove` and `editor::NewlineBelow` actions in the default keymap were accidentally swapped some time ago. This causes confusion, as normally these are the other way around. This PR fixes this by swapping these back, which also matches what [VSCode does by default](https://code.visualstudio.com/shortcuts/keyboard-shortcuts-linux.pdf). Release Notes: - Swapped the default bindings for `editor::NewlineBelow` and `editor::NewlineAbove` for Linux and Windows to align more with other editors.
…ons doesn't exist (zed-industries#36984) Closes zed-industries#36938 Follow up to zed-industries#36554 When `registerOptions` is `None`, we should fall back instead of skipping capability registration. 1. `Option<OneOf<bool, T>>`, where `T` is struct – handled in the attached PR ✅ 2. `Option<T>`, where `T` is an enum that can be `Simple(bool)` or `Options(S)` – this PR ✅ 3. `Option<T>`, where `T` is struct – we should fall back to default values for these options⚠️ Release Notes: - Fixed an issue where hover popovers would not appear in language servers like Java.
Release Notes: - N/A Co-authored-by: Bennet Bo Fenner <[email protected]>
…6995) Release Notes: - N/A
Release Notes: - N/A --------- Co-authored-by: Conrad Irwin <[email protected]> Co-authored-by: Bennet Bo Fenner <[email protected]> Co-authored-by: Antonio Scandurra <[email protected]> Co-authored-by: Matt Miller <[email protected]>
Within our hosted docs, we are missing documentation for quite a lot of settings - sometimes for newer settings, sometimes for settings that are more than two years old. This leads (amongst other things) to feature requests for features that are already supported, false issue reports (because people couldn't find the setting for what caused the issue within the documentation) and generally just takes time for for both these affected by the missing documentation as well as these handling the questions around it. This change here takes a stab at the problem by adding more documentation for a lot supported setting (not all of it) as well as reorganizing some settings so that some stuff can (hopefully) be found more easily. Eventually, we should find a better method for this, but it's still better than informing people for the n-th time that we e.g. have `agent_font_size` for the agent panel. Manually audited twice but I'll take another thorough look before merging. Release Notes: - N/A
…s#36997) Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <[email protected]> Co-authored-by: Cole Miller <[email protected]> Co-authored-by: Joseph T. Lyons <[email protected]> Co-authored-by: Katie Geer <[email protected]>
Closes zed-industries#36992 Release Notes: - N/A
…geWorkspaceFolders" (zed-industries#37005) Fixes missing capability registration for "workspace/didChangeWorkspaceFolders". ``` WARN [project::lsp_store] unhandled capability registration: Registration { id: "e288546c-4458-401a-a029-bbba759d5a71", method: "workspace/didChangeWorkspaceFolders", register_options: Some(Object {}) } ``` We already correctly send back events to server on workspace add and remove by checking this capability. https://github.com/zed-industries/zed/blob/cf89691b85e4652093548c0bf8b79d881e26562b/crates/lsp/src/lsp.rs#L1353 https://github.com/zed-industries/zed/blob/cf89691b85e4652093548c0bf8b79d881e26562b/crates/lsp/src/lsp.rs#L1388 Release Notes: - N/A
…7006) Release Notes: - acp: Fix an issue where the model selector would sometimes be empty --------- Co-authored-by: Antonio Scandurra <[email protected]>
Release Notes: - acp: Fixed a bug that caused external agent server subprocesses to be leaked. --------- Co-authored-by: Agus Zubiaga <[email protected]> Co-authored-by: Bennet Bo Fenner <[email protected]> Co-authored-by: Antonio Scandurra <[email protected]>
…zed-industries#37008) Gemini cli - 0.2.0 is no longer in preview it's the latest version and released as of today. Release Notes: - N/A Signed-off-by: Umesh Yadav <[email protected]>
Fixes zed-industries#37010 Release Notes: - N/A
…s#36859) Add support to disable both window resizing and minimizing. | | macOS | Windows | | - | - | - | | **Unresizable** | <img width="412" height="440" alt="SCR-20250822-qpea" src="https://github.com/user-attachments/assets/d6d45510-dc4b-436f-a9fa-ce9cb0b0c411" /> | <img width="276" height="298" alt="2025-08-22 110757" src="https://github.com/user-attachments/assets/9deff498-e903-4173-9c26-072dd9409fc1" /> | | **Unminimizable** | <img width="412" height="440" alt="SCR-20250822-qpfl" src="https://github.com/user-attachments/assets/e1d5f9eb-6de5-4908-8b52-38ccb2e65689" /> | <img width="276" height="298" alt="2025-08-22 110814" src="https://github.com/user-attachments/assets/da94b006-3544-4274-8b02-1cab7ca8dd70" /> | Release Notes: - N/A
Follow-up to: zed-industries#37019 See also: zed-industries#37010 Before/After: <img width="418" height="402" alt="Screenshot 2025-08-27 at 13 54 52" src="https://github.com/user-attachments/assets/1b2e02dd-c216-4372-b23e-5a3a619d2b77" /> Release Notes: - N/A
…37023) Release Notes: - N/A
Enables LSP log tracing in both remote collab and remote ssh environments. Server logs and server RPC traces can now be viewed remotely, and the LSP button is now shown in such projects too. Closes zed-industries#28557 Co-Authored-By: Kirill <[email protected]> Co-Authored-By: Lukas <[email protected]> Release Notes: - Enabled LSP log tracing in both remote collab and remote ssh environments --------- Co-authored-by: Kirill Bulatov <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
This PR links users to the FAQ on the release channels, which has more in-depth coverage of the process. Release Notes: - N/A
Release Notes: - N/A
…orktree and current pyproject.toml (zed-industries#37037) cc @michael-ud - if you can build Zed, I'd appreciate it if you could give this a go with your project. Otherwise I can provide a link to download of current nightly via an e-mail for you to try out (if you want). This change will land in Preview (if merged) on next Wednesday and then it'll be in Stable a week after that. Related to: zed-industries#20402 Release Notes: - python: Zed now searches for virtual environments in intermediate directories between a root of the worktree and the location of pyproject.toml applicable to the currently focused file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.