project: Handle capabilities parse for more methods when registerOptions doesn't exist #36984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
tidely
pushed a commit
to tidely/zed
that referenced
this pull request
Sep 10, 2025
…ons doesn't exist (zed-industries#36984) Closes zed-industries#36938 Follow up to zed-industries#36554 When `registerOptions` is `None`, we should fall back instead of skipping capability registration. 1. `Option<OneOf<bool, T>>`, where `T` is struct – handled in the attached PR ✅ 2. `Option<T>`, where `T` is an enum that can be `Simple(bool)` or `Options(S)` – this PR ✅ 3. `Option<T>`, where `T` is struct – we should fall back to default values for these options⚠️ Release Notes: - Fixed an issue where hover popovers would not appear in language servers like Java.
FrGoIs
pushed a commit
to FrGoIs/zed
that referenced
this pull request
Sep 29, 2025
…ons doesn't exist (zed-industries#36984) Closes zed-industries#36938 Follow up to zed-industries#36554 When `registerOptions` is `None`, we should fall back instead of skipping capability registration. 1. `Option<OneOf<bool, T>>`, where `T` is struct – handled in the attached PR ✅ 2. `Option<T>`, where `T` is an enum that can be `Simple(bool)` or `Options(S)` – this PR ✅ 3. `Option<T>`, where `T` is struct – we should fall back to default values for these options⚠️ Release Notes: - Fixed an issue where hover popovers would not appear in language servers like Java.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36938
Follow up to #36554
When
registerOptionsisNone, we should fall back instead of skipping capability registration.Option<OneOf<bool, T>>, whereTis struct – handled in the attached PR ✅Option<T>, whereTis an enum that can beSimple(bool)orOptions(S)– this PR ✅Option<T>, whereTis struct – we should fall back to default values for these optionsRelease Notes: