Enhance syntax highlight for C++20 keywords #36817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have @caiopiccirillo on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
maxdeviant
changed the title
osiewicz
reviewed
Aug 25, 2025
| (module_name | ||
| (identifier) @module))) | ||
|
|
||
| (co_await_expression |
Contributor
There was a problem hiding this comment.
Right now co_await and company get different highlights than return; I don't believe that's desirable given that co_await is a control flow construct. Can we have them share the highlights with return, as it is today?
Contributor
Author
There was a problem hiding this comment.
Sure, it makes much more sense. Here it is:
Contributor
|
Thanks! |
tidely
pushed a commit
to tidely/zed
that referenced
this pull request
Sep 10, 2025
Closes zed-industries#36439 and zed-industries#32999 ## C++20 modules: Before (Zed Preview v0.201.3): <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/8eaaf77f-4e27-4a5a-9e87-4e5ba7293990" /> After: <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/df8d0b2c-f2d0-4b0e-9a52-495e6be5a8c0" /> ## C++20 coroutines: Before (Zed Preview v0.201.3): <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/652191ec-a653-444d-a239-da3e4e4b661e" /> After: <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/36947eb5-8997-483a-b36c-8af84872b158" /> ## Logical operators: Before (Zed Preview v0.201.3): <img width="511" height="102" alt="image" src="https://github.com/user-attachments/assets/9bf95bac-b076-4edd-a1f3-c3dfee98c2fd" /> After: <img width="511" height="102" alt="image" src="https://github.com/user-attachments/assets/82c7564d-b94d-41f5-9c48-e39fe3ba3b3e" /> ## Operator keyword: Before (Zed Preview v0.201.3): <img width="591" height="381" alt="image" src="https://github.com/user-attachments/assets/1d9dad05-2d86-4566-97f4-aff440dcd1df" /> After: <img width="591" height="381" alt="image" src="https://github.com/user-attachments/assets/a1ca289a-8a5d-4ffd-96db-0d511405da4b" /> ## Goto: Before (Zed Preview v0.201.3): <img width="610" height="430" alt="image" src="https://github.com/user-attachments/assets/2d00382b-d1ad-4e36-a3ee-88e06ec528ed" /> After: <img width="610" height="430" alt="image" src="https://github.com/user-attachments/assets/de887b21-66f0-4a70-9ed2-e18dbb3c81c9" /> Release Notes: - Enhance keyword highlighting for C++
FrGoIs
pushed a commit
to FrGoIs/zed
that referenced
this pull request
Sep 29, 2025
Closes zed-industries#36439 and zed-industries#32999 ## C++20 modules: Before (Zed Preview v0.201.3): <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/8eaaf77f-4e27-4a5a-9e87-4e5ba7293990" /> After: <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/df8d0b2c-f2d0-4b0e-9a52-495e6be5a8c0" /> ## C++20 coroutines: Before (Zed Preview v0.201.3): <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/652191ec-a653-444d-a239-da3e4e4b661e" /> After: <img width="1048" height="704" alt="image" src="https://github.com/user-attachments/assets/36947eb5-8997-483a-b36c-8af84872b158" /> ## Logical operators: Before (Zed Preview v0.201.3): <img width="511" height="102" alt="image" src="https://github.com/user-attachments/assets/9bf95bac-b076-4edd-a1f3-c3dfee98c2fd" /> After: <img width="511" height="102" alt="image" src="https://github.com/user-attachments/assets/82c7564d-b94d-41f5-9c48-e39fe3ba3b3e" /> ## Operator keyword: Before (Zed Preview v0.201.3): <img width="591" height="381" alt="image" src="https://github.com/user-attachments/assets/1d9dad05-2d86-4566-97f4-aff440dcd1df" /> After: <img width="591" height="381" alt="image" src="https://github.com/user-attachments/assets/a1ca289a-8a5d-4ffd-96db-0d511405da4b" /> ## Goto: Before (Zed Preview v0.201.3): <img width="610" height="430" alt="image" src="https://github.com/user-attachments/assets/2d00382b-d1ad-4e36-a3ee-88e06ec528ed" /> After: <img width="610" height="430" alt="image" src="https://github.com/user-attachments/assets/de887b21-66f0-4a70-9ed2-e18dbb3c81c9" /> Release Notes: - Enhance keyword highlighting for C++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36439 and #32999
C++20 modules:
Before (Zed Preview v0.201.3):
After:
C++20 coroutines:
Before (Zed Preview v0.201.3):
After:
Logical operators:
Before (Zed Preview v0.201.3):
After:
Operator keyword:
Before (Zed Preview v0.201.3):
After:
Goto:
Before (Zed Preview v0.201.3):
After:
Release Notes: