Skip to content

Remote LSP logs #36709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 27, 2025
Merged

Remote LSP logs #36709

merged 18 commits into from
Aug 27, 2025

Conversation

@probably-neb
Copy link
Collaborator

@probably-neb probably-neb commented Aug 21, 2025 •
edited by SomeoneToIgnore
Loading

Enables LSP log tracing in both remote collab and remote ssh environments.
Server logs and server RPC traces can now be viewed remotely, and the LSP button is now shown in such projects too.

Closes #28557

Co-Authored-By: Kirill [email protected]
Co-Authored-By: Lukas [email protected]

Release Notes:

  • Enabled LSP log tracing in both remote collab and remote ssh environments

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 21, 2025
@SomeoneToIgnore SomeoneToIgnore force-pushed the remote-lsp-logs branch 6 times, most recently from 9e5add8 to 03ba256 Compare August 26, 2025 07:43
@SomeoneToIgnore SomeoneToIgnore self-assigned this Aug 26, 2025
@SomeoneToIgnore SomeoneToIgnore force-pushed the remote-lsp-logs branch 3 times, most recently from 4ba48ab to 8e19ab8 Compare August 27, 2025 08:49
@github-actions
Copy link

github-actions bot commented Aug 27, 2025 •
edited
Loading

Squawk Report

✅ 0 violations across 1 file(s)

crates/collab/migrations/20250827084812_worktree_in_servers.sql

ALTER TABLE language_servers
    ADD COLUMN worktree_id BIGINT;

✅ Rule Violations (0)

No violations found.

📚 More info on rules

⚡️ Powered by Squawk (0.26.0), a linter for PostgreSQL, focused on migrations

@SomeoneToIgnore SomeoneToIgnore force-pushed the remote-lsp-logs branch 5 times, most recently from 157bcdb to 53a6c7a Compare August 27, 2025 11:53
probably-neb and others added 12 commits August 27, 2025 19:24
@probably-neb @SomeoneToIgnore
wip
22cf340
@SomeoneToIgnore
Add messages and handlers for RPC log toggling
922e0e5 
Co-authored-by: Ben Kunkle <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>

# Conflicts:
#	crates/language_tools/src/lsp_log.rs
#	crates/remote_server/src/headless_project.rs
@SomeoneToIgnore @Veykril @probably-neb
Disable log storing in the remote LspLog storage
ba9fc07 
Co-authored-by: Lukas Wirth <[email protected]>
Co-authored-by: Ben Kunkle <[email protected]>
@SomeoneToIgnore @probably-neb @Veykril
Properly show the binary stats
d64e026 
Co-authored-by: Ben Kunkle <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>
@probably-neb @SomeoneToIgnore
fix handling of verbose
bfbe840
@SomeoneToIgnore
Register log-related actions for all kinds of projects
088997a
@SomeoneToIgnore
Move call into a separate feature in the workspace
e2f8eb2
@SomeoneToIgnore
cfg-out call-related workspace functionality
e5d0759
@SomeoneToIgnore
One less remote usage
3d7d7d5
@SomeoneToIgnore
Pass LSP RPC logs up to ssh log store
08c8d17
@SomeoneToIgnore
Simplify
ebd4b3b
@SomeoneToIgnore
Fix ssh message sending
4b50c9d
@SomeoneToIgnore SomeoneToIgnore marked this pull request as ready for review August 27, 2025 18:52
@maxdeviant maxdeviant changed the title Remote lsp logs Remote LSP logs Aug 27, 2025
@SomeoneToIgnore
Copy link
Contributor

SomeoneToIgnore commented Aug 27, 2025

Protobuf migration CI failure is due to LanguageServerLog message change, which was, before this, used exclusively for SSH project interchange — SSH headless client will get updated along with the new Zed version, so this is not really breaking anything.

@SomeoneToIgnore SomeoneToIgnore merged commit e2bf8e5 into main Aug 27, 2025
23 of 24 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the remote-lsp-logs branch August 27, 2025 18:55
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Aug 27, 2025
Closed
SomeoneToIgnore added a commit that referenced this pull request Aug 27, 2025
@SomeoneToIgnore
Revert "Remote LSP logs (#36709)"
aa33723 
This reverts commit e2bf8e5.
SomeoneToIgnore added a commit that referenced this pull request Aug 27, 2025
@SomeoneToIgnore
Revert "Remote LSP logs (#36709)" (#37051)
b233df8 
This reverts commit e2bf8e5.

See
#37050 (comment)
for the context: musl builds started to fail and the amount of `cfg!`s
to fix this is too large.

Instead, the lsp_log.rs has to be split and repurposed better for the
remote headless server.

Release Notes:

- N/A
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Aug 28, 2025
Merged
SomeoneToIgnore added a commit that referenced this pull request Aug 28, 2025
@SomeoneToIgnore @probably-neb @Veykril
Remote LSP logs (#37083)
f127ba8 
Take 2: #36709 but without the
very bad `cfg`-based approach for storing the RPC logs.

--------------

Enables LSP log tracing in both remote collab and remote ssh
environments.
Server logs and server RPC traces can now be viewed remotely, and the
LSP button is now shown in such projects too.

Closes #28557

Co-Authored-By: Kirill <[email protected]>
Co-Authored-By: Lukas <[email protected]>

Release Notes:

- Enabled LSP log tracing in both remote collab and remote ssh
environments

---------

Co-authored-by: Ben Kunkle <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>
notpeter pushed a commit that referenced this pull request Sep 3, 2025
@SomeoneToIgnore @probably-neb
@Veykril @notpeter
Remote LSP logs (#37083)
a605bb5 
Take 2: #36709 but without the
very bad `cfg`-based approach for storing the RPC logs.

--------------

Enables LSP log tracing in both remote collab and remote ssh
environments.
Server logs and server RPC traces can now be viewed remotely, and the
LSP button is now shown in such projects too.

Closes #28557

Co-Authored-By: Kirill <[email protected]>
Co-Authored-By: Lukas <[email protected]>

Release Notes:

- Enabled LSP log tracing in both remote collab and remote ssh
environments

---------

Co-authored-by: Ben Kunkle <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>
tidely pushed a commit to tidely/zed that referenced this pull request Sep 10, 2025
@probably-neb @SomeoneToIgnore
@Veykril @tidely
Remote LSP logs (zed-industries#36709)
1aa61a5 
Enables LSP log tracing in both remote collab and remote ssh
environments.
Server logs and server RPC traces can now be viewed remotely, and the
LSP button is now shown in such projects too.

Closes zed-industries#28557

Co-Authored-By: Kirill <[email protected]>
Co-Authored-By: Lukas <[email protected]>

Release Notes:

- Enabled LSP log tracing in both remote collab and remote ssh
environments

---------

Co-authored-by: Kirill Bulatov <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>
tidely pushed a commit to tidely/zed that referenced this pull request Sep 10, 2025
@SomeoneToIgnore @tidely
Revert "Remote LSP logs (zed-industries#36709)" (zed-industries#37051)
4d8f12d 
This reverts commit e2bf8e5.

See
zed-industries#37050 (comment)
for the context: musl builds started to fail and the amount of `cfg!`s
to fix this is too large.

Instead, the lsp_log.rs has to be split and repurposed better for the
remote headless server.

Release Notes:

- N/A
tidely pushed a commit to tidely/zed that referenced this pull request Sep 10, 2025
@SomeoneToIgnore @probably-neb
@Veykril @tidely
Remote LSP logs (zed-industries#37083)
13dd4de 
Take 2: zed-industries#36709 but without the
very bad `cfg`-based approach for storing the RPC logs.

--------------

Enables LSP log tracing in both remote collab and remote ssh
environments.
Server logs and server RPC traces can now be viewed remotely, and the
LSP button is now shown in such projects too.

Closes zed-industries#28557

Co-Authored-By: Kirill <[email protected]>
Co-Authored-By: Lukas <[email protected]>

Release Notes:

- Enabled LSP log tracing in both remote collab and remote ssh
environments

---------

Co-authored-by: Ben Kunkle <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>
FrGoIs pushed a commit to FrGoIs/zed that referenced this pull request Sep 29, 2025
@probably-neb @SomeoneToIgnore
@Veykril @FrGoIs
Remote LSP logs (zed-industries#36709)
a060d2b 
Enables LSP log tracing in both remote collab and remote ssh
environments.
Server logs and server RPC traces can now be viewed remotely, and the
LSP button is now shown in such projects too.

Closes zed-industries#28557

Co-Authored-By: Kirill <[email protected]>
Co-Authored-By: Lukas <[email protected]>

Release Notes:

- Enabled LSP log tracing in both remote collab and remote ssh
environments

---------

Co-authored-by: Kirill Bulatov <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>
FrGoIs pushed a commit to FrGoIs/zed that referenced this pull request Sep 29, 2025
@SomeoneToIgnore @FrGoIs
Revert "Remote LSP logs (zed-industries#36709)" (zed-industries#37051)
6e2c320 
This reverts commit e2bf8e5.

See
zed-industries#37050 (comment)
for the context: musl builds started to fail and the amount of `cfg!`s
to fix this is too large.

Instead, the lsp_log.rs has to be split and repurposed better for the
remote headless server.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SomeoneToIgnore SomeoneToIgnore

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Language server logs not showing up in remote development

3 participants

@probably-neb @SomeoneToIgnore