Broadcast Unknown-multicast and Unknown-unicast Storm-control by mohan-selvaraj · Pull Request #928 · sonic-net/sonic-utilities

mohan-selvaraj · 2020-06-01T07:59:38Z

Broadcast, Unknown-multicast and Unknown-unicast storm-control on Ethernet interfaces.

configuration commands

config interface storm-control broadcast add Ethernet0 10000
config interface storm-control unknown-multicast add Ethernet0 10000
config interface storm-control unknown-unicast add Ethernet0 10000

config interface storm-control broadcast del Ethernet0
config interface storm-control unknown-multicast del Ethernet0
config interface storm-control unknown-unicast del Ethernet0

show commands

show storm-control all
show storm-control interface Ethernet0

Sample output

show storm-control interface Ethernet0
+------------------+-------------------+---------------+
| Interface Name | Storm Type | Rate (kbps) |
+==================+===================+===============+
| Ethernet0 | broadcast | 10000 |
+------------------+-------------------+---------------+
| Ethernet0 | unknown-unicast | 10000 |
+------------------+-------------------+---------------+
| Ethernet0 | unknown-multicast | 10000 |
+------------------+-------------------+---------------+

- What I did
Added configuration and show commands for BUM Storm-control feature.
- How I did it
modified the config and show scripts to add the commands.
- How to verify it
pytest script test_storm_control.py
- Previous command output (if the output of a command-line utility has changed)
New commands are added. Existing commands unaffected.
- New command output (if the output of a command-line utility has changed)
New commands are added. Existing commands unaffected.

…ture. configuration commands ---------------------- config interface storm-control broadcast add Ethernet0 10000 config interface storm-control unknown-multicast add Ethernet0 10000 config interface storm-control unknown-unicast add Ethernet0 10000 config interface storm-control broadcast del Ethernet0 config interface storm-control unknown-multicast del Ethernet0 config interface storm-control unknown-unicast del Ethernet0 show commands ------------- show storm-control all show storm-control interface Ethernet0 Sample output ------------- show storm-control interface Ethernet0 +------------------+-------------------+---------------+ | Interface Name | Storm Type | Rate (kbps) | +==================+===================+===============+ | Ethernet0 | broadcast | 10000 | +------------------+-------------------+---------------+ | Ethernet0 | unknown-unicast | 10000 | +------------------+-------------------+---------------+ | Ethernet0 | unknown-multicast | 10000 | +------------------+-------------------+---------------+

config/main.py

show/main.py

neethajohn · 2020-08-17T17:59:43Z

@mohan-selvaraj, please resolve the merge conflicts as well

neethajohn · 2020-08-24T18:40:22Z

@mohan-selvaraj, can you address the review comments?

…m-control (sonic-net#928) CLICK CLI - Configuration and show commands for BUM Storm-control feature. configuration commands ---------------------- config interface storm-control broadcast add Ethernet0 10000 config interface storm-control unknown-multicast add Ethernet0 10000 config interface storm-control unknown-unicast add Ethernet0 10000 config interface storm-control broadcast del Ethernet0 config interface storm-control unknown-multicast del Ethernet0 config interface storm-control unknown-unicast del Ethernet0 show commands ------------- show storm-control all show storm-control interface Ethernet0 Sample output ------------- show storm-control interface Ethernet0 +------------------+-------------------+---------------+ | Interface Name | Storm Type | Rate (kbps) | +==================+===================+===============+ | Ethernet0 | broadcast | 10000 | +------------------+-------------------+---------------+ | Ethernet0 | unknown-unicast | 10000 | +------------------+-------------------+---------------+ | Ethernet0 | unknown-multicast | 10000 | +------------------+-------------------+---------------+

…o Azure-master

lgtm-com · 2021-11-02T06:27:17Z

This pull request introduces 2 alerts when merging 6be166a into 474bdbf - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

…lid APIs

srj102 · 2021-11-04T08:09:51Z

/azpw run

mohan-selvaraj · 2021-11-08T10:08:31Z

/azpw run

mssonicbld · 2021-11-08T10:08:32Z

/AzurePipelines run

azure-pipelines · 2021-11-08T10:08:45Z

Azure Pipelines successfully started running 1 pipeline(s).

lgtm-com · 2021-11-09T08:23:49Z

This pull request introduces 7 alerts when merging f5b354e into 63a5257 - view on LGTM.com

new alerts:

5 for Unused import
1 for Unused local variable
1 for Implicit string concatenation in a list

lgtm-com · 2021-11-09T08:58:40Z

This pull request introduces 6 alerts when merging 55768bd into 63a5257 - view on LGTM.com

new alerts:

5 for Unused import
1 for Unused local variable

lgtm-com · 2021-11-09T09:19:37Z

This pull request introduces 1 alert when merging 7542172 into 63a5257 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2021-11-15T06:29:50Z

This pull request introduces 1 alert when merging 4c9945f into 00b6045 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2021-11-17T04:45:45Z

This pull request introduces 1 alert when merging 8147999 into e7535ae - view on LGTM.com

new alerts:

1 for Unused import

venkatmahalingam · 2021-11-22T23:09:50Z

Can we have the CLI commands like below?

OLD
config interface storm-control broadcast add/del Ethernet0 10000
config interface storm-control unknown-multicast add/del Ethernet0 10000
config interface storm-control unknown-unicast add/del Ethernet0 10000

NEW
config interface storm-control add/del Ethernet0 broadcast 10000
config interface storm-control add/del Ethernet0 unknown-multicast 10000
config interface storm-control add/del Ethernet0 unknown-unicast 10000

venkatmahalingam · 2021-11-22T23:11:06Z

What I did
How I did it
How to verify it
The above sections are not filled in the description.

gechiang · 2021-11-22T23:36:31Z

config/main.py

+    pass
+
+@broadcast.command('add')
+@click.argument('port_name', metavar='<port_name>', required=True)


Please also include support for Multi-ASIC platform. ASIC name space support is required

Please point me to an example on how to include ASIC name space.

look into the following PR which supports multi-asic:
#1574

@gechiang Please review

lgtm-com · 2022-05-05T10:37:46Z

This pull request introduces 2 alerts when merging 991210c into 1143869 - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Unused import

Conflicts: tests/mock_tables/config_db.json

…ic-utilities into storm_control Conflicts: tests/mock_tables/config_db.json

lgtm-com · 2022-05-05T10:51:34Z

This pull request introduces 2 alerts when merging 93c01c3 into 1143869 - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-05T12:54:58Z

This pull request introduces 2 alerts when merging d288b08 into 1143869 - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-05T15:30:48Z

This pull request introduces 2 alerts when merging 9a85aad into 1143869 - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-05T16:08:12Z

This pull request introduces 2 alerts when merging 5b63779 into 1143869 - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-05T16:22:57Z

This pull request introduces 2 alerts when merging f1bb1cb into 1143869 - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-05T17:31:25Z

This pull request introduces 2 alerts when merging e4389e5 into 1143869 - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-09T09:22:33Z

This pull request introduces 2 alerts when merging afe1122 into 6ab1c51 - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-11T09:51:55Z

This pull request introduces 2 alerts when merging f2c32ca into 288c2d8 - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Unused import

prsunny · 2022-05-17T18:51:24Z

@venkatmahalingam , @neethajohn , can you please uncheck "change requested" and signoff?

Update sonic-utilities submodule pointer to include the following: * [GCU] Handling type1 lists ([sonic-net#2171](sonic-net/sonic-utilities#2171)) * [yang] extend ConfigMgmt constructor to pass YANG options ([sonic-net#2118](sonic-net/sonic-utilities#2118)) * [dump] implement ACL modules ([sonic-net#2153](sonic-net/sonic-utilities#2153)) * show commands for SYSTEM READY ([sonic-net#1851](sonic-net/sonic-utilities#1851)) * [GCU] Handling non-compliant leaf-list with string values ([sonic-net#2174](sonic-net/sonic-utilities#2174)) * Add sonic-delayed.target to Application Extension .timer file generator ([sonic-net#2176](sonic-net/sonic-utilities#2176)) * [portconfig] Allow to configure interface mtu for physical ports ([#l](https://github.com/Azure/sonic-utilities/pull/l)) * Broadcast Unknown-multicast and Unknown-unicast Storm-control ([sonic-net#928](sonic-net/sonic-utilities#928)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel ([sonic-net#2151](sonic-net/sonic-utilities#2151)) * Modify override testcase to cover PORT admin_status ([sonic-net#2165](sonic-net/sonic-utilities#2165)) * [GCU] Validate peer_group_range ip_range are correct ([sonic-net#2145](sonic-net/sonic-utilities#2145)) * [auto-ts] add memory check ([sonic-net#2116](sonic-net/sonic-utilities#2116)) * support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 ([sonic-net#2167](sonic-net/sonic-utilities#2167)) * [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition ([sonic-net#2150](sonic-net/sonic-utilities#2150)) * [config reload] Fix invalid rstrip. ([sonic-net#2157](sonic-net/sonic-utilities#2157)) * Accept 0 for queue and dscp ([sonic-net#2162](sonic-net/sonic-utilities#2162)) Signed-off-by: dprital <[email protected]>

mohan-selvaraj mentioned this pull request Jul 10, 2020

Broadcast Unknown-multicast and Unknown-unicast Storm-control sonic-net/sonic-swss#1306

Merged

neethajohn requested changes Aug 17, 2020

View reviewed changes

mohan-selvaraj mentioned this pull request Nov 1, 2021

SONIC broadcast, unknown-unicast and unknown-multicast (BUM) storm-control HLD sonic-net/SONiC#441

Merged

mohan-selvaraj added 2 commits November 1, 2021 23:10

Merge branch 'master' of https://github.com/Azure/sonic-utilities int…

c5385d5

…o Azure-master

Merge branch 'Azure-master' into storm_control

6be166a

mohan-selvaraj added 2 commits November 1, 2021 23:47

Update parameters to interface_alias_to_name and interface_name_is_va…

a073d93

…lid APIs

addressed review comments.

37b41f0

mohan-selvaraj requested a review from neethajohn November 8, 2021 18:43

utilities test code for storm-control

f5b354e

55768bd

7542172

Merge branch 'Azure:master' into storm_control

4c9945f

Merge branch 'master' into storm_control

8147999

gechiang reviewed Nov 22, 2021

View reviewed changes

mohan-selvaraj added 2 commits May 5, 2022 03:40

Merge branch 'master' into storm_control

1ed0c15

Conflicts: tests/mock_tables/config_db.json

Merge branch 'storm_control' of https://github.com/mohan-selvaraj/son…

93c01c3

…ic-utilities into storm_control Conflicts: tests/mock_tables/config_db.json

storm-control config/show test code

d288b08

9a85aad

5b63779

f1bb1cb

e4389e5

Merge branch 'master' into storm_control

afe1122

Merge branch 'Azure:master' into storm_control

f2c32ca

mohan-selvaraj requested a review from gechiang May 13, 2022 10:54

prsunny approved these changes May 17, 2022

View reviewed changes

venkatmahalingam approved these changes May 17, 2022

View reviewed changes

gechiang approved these changes May 18, 2022

View reviewed changes

neethajohn approved these changes May 18, 2022

View reviewed changes

prsunny merged commit 9881f3e into sonic-net:master May 18, 2022

dprital mentioned this pull request May 25, 2022

[submodule] Update sonic-utilities submodule sonic-net/sonic-buildimage#10928

Closed

6 tasks

This was referenced Jun 9, 2022

[submodule] Update sonic-utilities submodule ayurkiv-nvda/sonic-buildimage#22

Closed

[submodule] Update sonic-utilities submodule sonic-net/sonic-buildimage#11103

Closed

Conversation

mohan-selvaraj commented Jun 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

configuration commands

show commands

Sample output

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neethajohn commented Aug 17, 2020

Uh oh!

neethajohn commented Aug 24, 2020

Uh oh!

lgtm-com bot commented Nov 2, 2021

Uh oh!

srj102 commented Nov 4, 2021

Uh oh!

mohan-selvaraj commented Nov 8, 2021

Uh oh!

mssonicbld commented Nov 8, 2021

Uh oh!

azure-pipelines bot commented Nov 8, 2021

Uh oh!

lgtm-com bot commented Nov 9, 2021

Uh oh!

lgtm-com bot commented Nov 9, 2021

Uh oh!

lgtm-com bot commented Nov 9, 2021

Uh oh!

lgtm-com bot commented Nov 15, 2021

Uh oh!

lgtm-com bot commented Nov 17, 2021

Uh oh!

venkatmahalingam commented Nov 22, 2021

Uh oh!

venkatmahalingam commented Nov 22, 2021

Uh oh!

gechiang Nov 22, 2021

Choose a reason for hiding this comment

Uh oh!

mohan-selvaraj Nov 23, 2021

Choose a reason for hiding this comment

Uh oh!

gechiang Nov 23, 2021

Choose a reason for hiding this comment

Uh oh!

mohan-selvaraj May 11, 2022

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented May 5, 2022

Uh oh!

lgtm-com bot commented May 5, 2022

Uh oh!

lgtm-com bot commented May 5, 2022

Uh oh!

lgtm-com bot commented May 5, 2022

Uh oh!

lgtm-com bot commented May 5, 2022

Uh oh!

lgtm-com bot commented May 5, 2022

Uh oh!

lgtm-com bot commented May 5, 2022

Uh oh!

lgtm-com bot commented May 9, 2022

Uh oh!

lgtm-com bot commented May 11, 2022

Uh oh!

prsunny commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

mohan-selvaraj commented Jun 1, 2020 •

edited

Loading