Fix validation of input of config mirror_session add#2162
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom May 12, 2022
Merged
Conversation
Signed-off-by: bingwang <[email protected]>
arfeigin
approved these changes
May 11, 2022
lolyu
approved these changes
May 12, 2022
judyjoseph
pushed a commit
that referenced
this pull request
May 16, 2022
Signed-off-by: bingwang <[email protected]>
Contributor
|
@bingwang-ms In future when you merge, please make sure copy PR title to commit title. |
Contributor
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
May 25, 2022
Update sonic-utilities submodule pointer to include the following: * [GCU] Handling type1 lists ([sonic-net#2171](sonic-net/sonic-utilities#2171)) * [yang] extend ConfigMgmt constructor to pass YANG options ([sonic-net#2118](sonic-net/sonic-utilities#2118)) * [dump] implement ACL modules ([sonic-net#2153](sonic-net/sonic-utilities#2153)) * show commands for SYSTEM READY ([sonic-net#1851](sonic-net/sonic-utilities#1851)) * [GCU] Handling non-compliant leaf-list with string values ([sonic-net#2174](sonic-net/sonic-utilities#2174)) * Add sonic-delayed.target to Application Extension .timer file generator ([sonic-net#2176](sonic-net/sonic-utilities#2176)) * [portconfig] Allow to configure interface mtu for physical ports ([#l](https://github.com/Azure/sonic-utilities/pull/l)) * Broadcast Unknown-multicast and Unknown-unicast Storm-control ([sonic-net#928](sonic-net/sonic-utilities#928)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel ([sonic-net#2151](sonic-net/sonic-utilities#2151)) * Modify override testcase to cover PORT admin_status ([sonic-net#2165](sonic-net/sonic-utilities#2165)) * [GCU] Validate peer_group_range ip_range are correct ([sonic-net#2145](sonic-net/sonic-utilities#2145)) * [auto-ts] add memory check ([sonic-net#2116](sonic-net/sonic-utilities#2116)) * support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 ([sonic-net#2167](sonic-net/sonic-utilities#2167)) * [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition ([sonic-net#2150](sonic-net/sonic-utilities#2150)) * [config reload] Fix invalid rstrip. ([sonic-net#2157](sonic-net/sonic-utilities#2157)) * Accept 0 for queue and dscp ([sonic-net#2162](sonic-net/sonic-utilities#2162)) Signed-off-by: dprital <[email protected]>
6 tasks
Collaborator
|
@qiluo-msft - Can you please cherry pick this PR to 202012 ? |
Contributor
|
Check my above comment. |
Collaborator
Thanks. |
Contributor
Author
Sure, will file another PR. |
Contributor
Author
|
cherry-pick PR created https://github.com/Azure/sonic-utilities/pull/2187/files |
This was referenced Jun 9, 2022
Contributor
|
@bingwang-ms looks like there is merge conflict in 202205 as well. Can you open an PR for 202205? |
Contributor
Author
Sure, opened another PR for 202205 branch #2494 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
What I did
FIX sonic-net/sonic-buildimage#10795
queue = 0is not accepted by the validation of input because the follow checkhttps://github.com/Azure/sonic-utilities/blob/bce4694d3ad4454fc7181b99433457e76ab9e0a0/config/main.py#L2028-L2029
When addressing the issue, I saw similar issue in the logic of handling
gre_type. The issue is also fixed.How I did it
Change
if queuetoif queue is not NoneHow to verify it
Verified by UT
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)