show commands for SYSTEM READY by sg893052 · Pull Request #1851 · sonic-net/sonic-utilities

sg893052 · 2021-10-01T17:53:04Z

What I did

show command support for System Ready Feature Implementation .
Also sonic-package-manager support for app readiness.

"show system-health sysready-status"
"show system-health sysready-status detail"
"show system-health sysready-status brief"

How I did it

Introduce "show system-health sysready-status" click CLI with options.

How to verify it

Check the click CLIs introduced.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# show system-health sysready-status
System is ready

Service-Name                      Service-Status    App-Ready-Status    Down-Reason
--------------------------------  ----------------  ------------------  -------------
as7326-56x-pddf-platform-monitor  OK                OK                  -
auditd                            OK                OK                  -
bgp                               OK                OK                  -
caclmgrd                          OK                OK                  -
config-chassisdb                  OK                OK                  -
config-setup                      OK                OK                  -
containerd                        OK                OK                  -
cron                              OK                OK                  -
database                          OK                OK                  -
docker                            OK                OK                  -
kdump-tools                       OK                OK                  -
lldp                              OK                OK                  -
mgmt-framework                    OK                OK                  -
netfilter-persistent              OK                OK                  -
ntp                               OK                OK                  -
opennsl-modules                   OK                OK                  -
pddf-platform-init                OK                OK                  -
pmon                              OK                OK                  -
procdockerstatsd                  OK                OK                  -
radv                              OK                OK                  -
ras-mc-ctl                        OK                OK                  -
rsyslog                           OK                OK                  -
smartmontools                     OK                OK                  -
snmp                              OK                OK                  -
ssh                               OK                OK                  -
swss                              OK                OK                  -
syncd                             OK                OK                  -
teamd                             OK                OK                  -
telemetry                         OK                OK                  -
root@sonic:/home/admin#

root@sonic:/home/admin# show system-health sysready-status detail
System is ready

Service-Name                      Service-Status    App-Ready-Status    Down-Reason    AppStatus-UpdateTime
--------------------------------  ----------------  ------------------  -------------  ----------------------
as7326-56x-pddf-platform-monitor  OK                OK                  -              -
auditd                            OK                OK                  -              -
bgp                               OK                OK                  -              -
caclmgrd                          OK                OK                  -              -
config-chassisdb                  OK                OK                  -              -
config-setup                      OK                OK                  -              -
containerd                        OK                OK                  -              -
cron                              OK                OK                  -              -
database                          OK                OK                  -              -
docker                            OK                OK                  -              -
kdump-tools                       OK                OK                  -              -
lldp                              OK                OK                  -              -
mgmt-framework                    OK                OK                  -              -
netfilter-persistent              OK                OK                  -              -
ntp                               OK                OK                  -              -
opennsl-modules                   OK                OK                  -              -
pddf-platform-init                OK                OK                  -              -
pmon                              OK                OK                  -              -
procdockerstatsd                  OK                OK                  -              -
radv                              OK                OK                  -              -
ras-mc-ctl                        OK                OK                  -              -
rsyslog                           OK                OK                  -              -
smartmontools                     OK                OK                  -              -
snmp                              OK                OK                  -              -
ssh                               OK                OK                  -              -
swss                              OK                OK                  -              -
syncd                             OK                OK                  -              -
teamd                             OK                OK                  -              -
telemetry                         OK                OK                  -              -
root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin# show system-health sysready-status brief
System is ready

root@sonic:/home/admin#

root@sonic:/home/admin# systemctl stop bgp
root@sonic:/home/admin#
Apr 05 14:49:40.859589 System is not ready - one or more services are not up

root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin# show system-health sysready-status detail
System is not ready - one or more services are not up

Service-Name                      Service-Status    App-Ready-Status    Down-Reason    AppStatus-UpdateTime
--------------------------------  ----------------  ------------------  -------------  ----------------------
as7326-56x-pddf-platform-monitor  OK                OK                  -              -
auditd                            OK                OK                  -              -
bgp                               Down              Down                Inactive       -
caclmgrd                          OK                OK                  -              -
config-chassisdb                  OK                OK                  -              -
config-setup                      OK                OK                  -              -
containerd                        OK                OK                  -              -
cron                              OK                OK                  -              -
database                          OK                OK                  -              -
docker                            OK                OK                  -              -
kdump-tools                       OK                OK                  -              -
lldp                              OK                OK                  -              -
mgmt-framework                    OK                OK                  -              -
netfilter-persistent              OK                OK                  -              -
ntp                               OK                OK                  -              -
opennsl-modules                   OK                OK                  -              -
pddf-platform-init                OK                OK                  -              -
pmon                              OK                OK                  -              -
procdockerstatsd                  OK                OK                  -              -
radv                              OK                OK                  -              -
ras-mc-ctl                        OK                OK                  -              -
rsyslog                           OK                OK                  -              -
smartmontools                     OK                OK                  -              -
snmp                              OK                OK                  -              -
ssh                               OK                OK                  -              -
swss                              OK                OK                  -              -
syncd                             OK                OK                  -              -
teamd                             OK                OK                  -              -
telemetry                         OK                OK                  -              -
root@sonic:/home/admin#

root@sonic:/home/admin# systemctl start bgp
root@sonic:/home/admin#
Apr 05 14:50:23.718643 System is ready

root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin# show system-health sysready-status detail
System is ready

Service-Name                      Service-Status    App-Ready-Status    Down-Reason    AppStatus-UpdateTime
--------------------------------  ----------------  ------------------  -------------  ----------------------
as7326-56x-pddf-platform-monitor  OK                OK                  -              -
auditd                            OK                OK                  -              -
bgp                               OK                OK                  -              -
caclmgrd                          OK                OK                  -              -
config-chassisdb                  OK                OK                  -              -
config-setup                      OK                OK                  -              -
containerd                        OK                OK                  -              -
cron                              OK                OK                  -              -
database                          OK                OK                  -              -
docker                            OK                OK                  -              -
kdump-tools                       OK                OK                  -              -
lldp                              OK                OK                  -              -
mgmt-framework                    OK                OK                  -              -
netfilter-persistent              OK                OK                  -              -
ntp                               OK                OK                  -              -
opennsl-modules                   OK                OK                  -              -
pddf-platform-init                OK                OK                  -              -
pmon                              OK                OK                  -              -
procdockerstatsd                  OK                OK                  -              -
radv                              OK                OK                  -              -
ras-mc-ctl                        OK                OK                  -              -
rsyslog                           OK                OK                  -              -
smartmontools                     OK                OK                  -              -
snmp                              OK                OK                  -              -
ssh                               OK                OK                  -              -
swss                              OK                OK                  -              -
syncd                             OK                OK                  -              -
teamd                             OK                OK                  -              -
telemetry                         OK                OK                  -              -
root@sonic:/home/admin#

ghost · 2021-10-01T17:53:16Z

All CLA requirements met.

lgtm-com · 2021-10-01T18:07:14Z

This pull request introduces 1 alert when merging a488880a0b9ed6c8e2b9210b6697519b34a600e0 into 5bdf270 - view on LGTM.com

new alerts:

1 for Unreachable code

lgtm-com · 2021-10-04T12:55:46Z

This pull request introduces 1 alert when merging 68a3d1fc5a76be11e1189619226cc89e8caf9804 into 5bdf270 - view on LGTM.com

new alerts:

1 for Unreachable code

lgtm-com · 2021-10-27T05:54:04Z

This pull request introduces 1 alert when merging 201203d4fe7e6962e6cb5e273dff754a14795e27 into f53baac - view on LGTM.com

new alerts:

1 for Unreachable code

Kalimuthu-Velappan · 2021-10-27T15:04:08Z

retest this please

venkatmahalingam · 2021-11-02T05:56:55Z

Can we please capture all show commands output as well?

lgtm-com · 2021-11-05T12:58:37Z

This pull request introduces 1 alert when merging 5b9ff62 into efbe1f4 - view on LGTM.com

new alerts:

1 for Unreachable code

sg893052 · 2021-11-05T13:41:54Z

Can we please capture all show commands output as well?

Have updated "New command output" section with all the show commands output and also attached the UT log file.

system_ready_ut.pdf

liat-grozovik

@zhangyanzhao please don't merge this PR.
the HLD is now reverted and the other referenced PR should also be reverted until we agree on the HLD approach.

lgtm-com · 2022-04-06T09:07:45Z

This pull request introduces 5 alerts when merging 434fcf2 into 9e2fbf4 - view on LGTM.com

new alerts:

4 for Unused local variable
1 for Unused import

lgtm-com · 2022-04-25T14:42:32Z

This pull request introduces 1 alert when merging 288b748 into d012be9 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-04-30T08:16:15Z

This pull request introduces 1 alert when merging 7e0529d into fdb79b8 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-04-30T08:52:16Z

This pull request introduces 1 alert when merging 48a468d into fdb79b8 - view on LGTM.com

new alerts:

1 for Unused import

…ready support

lgtm-com · 2022-04-30T09:21:56Z

This pull request introduces 1 alert when merging bdbfe85 into fdb79b8 - view on LGTM.com

new alerts:

1 for Unused import

scripts/sysreadyshow

sonic_package_manager/service_creator/feature.py

lizhuhuams

Senthil Kumar Guruswamy, could you please merge this PR?

lgtm-com · 2022-05-17T07:38:40Z

This pull request introduces 1 alert when merging 86e3aea into d7953d2 - view on LGTM.com

new alerts:

1 for Unused import

sg893052 · 2022-05-17T07:58:55Z

Senthil Kumar Guruswamy, could you please merge this PR?
Have addressed the new comments and pushed the change. Thanks!

lgtm-com · 2022-05-20T04:22:30Z

This pull request introduces 1 alert when merging 350cf66 into 4fc09b1 - view on LGTM.com

new alerts:

1 for Unused import

Update sonic-utilities submodule pointer to include the following: * [GCU] Handling type1 lists ([sonic-net#2171](sonic-net/sonic-utilities#2171)) * [yang] extend ConfigMgmt constructor to pass YANG options ([sonic-net#2118](sonic-net/sonic-utilities#2118)) * [dump] implement ACL modules ([sonic-net#2153](sonic-net/sonic-utilities#2153)) * show commands for SYSTEM READY ([sonic-net#1851](sonic-net/sonic-utilities#1851)) * [GCU] Handling non-compliant leaf-list with string values ([sonic-net#2174](sonic-net/sonic-utilities#2174)) * Add sonic-delayed.target to Application Extension .timer file generator ([sonic-net#2176](sonic-net/sonic-utilities#2176)) * [portconfig] Allow to configure interface mtu for physical ports ([#l](https://github.com/Azure/sonic-utilities/pull/l)) * Broadcast Unknown-multicast and Unknown-unicast Storm-control ([sonic-net#928](sonic-net/sonic-utilities#928)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel ([sonic-net#2151](sonic-net/sonic-utilities#2151)) * Modify override testcase to cover PORT admin_status ([sonic-net#2165](sonic-net/sonic-utilities#2165)) * [GCU] Validate peer_group_range ip_range are correct ([sonic-net#2145](sonic-net/sonic-utilities#2145)) * [auto-ts] add memory check ([sonic-net#2116](sonic-net/sonic-utilities#2116)) * support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 ([sonic-net#2167](sonic-net/sonic-utilities#2167)) * [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition ([sonic-net#2150](sonic-net/sonic-utilities#2150)) * [config reload] Fix invalid rstrip. ([sonic-net#2157](sonic-net/sonic-utilities#2157)) * Accept 0 for queue and dscp ([sonic-net#2162](sonic-net/sonic-utilities#2162)) Signed-off-by: dprital <[email protected]>

yxieca · 2022-07-05T16:15:45Z

@sg893052 this change cannot be cherry-picked to 202205 branch cleanly, please create separate PR.

sg893052 · 2022-07-06T09:46:23Z

this change cannot be cherry-picked to 202205 branch cleanly, please create separate PR.
Could you please elaborate on the conflict ?

yxieca · 2022-07-07T22:03:43Z

this change cannot be cherry-picked to 202205 branch cleanly, please create separate PR.
Could you please elaborate on the conflict ?

If you checkout 202205 branch and cherry-pick this change in, you will see the conflict.

What I did show command support for System Ready Feature Implementation . Also sonic-package-manager support for app readiness. "show system-health sysready-status" "show system-health sysready-status detail" "show system-health sysready-status brief" How I did it Introduce "show system-health sysready-status" click CLI with options. How to verify it Check the click CLIs introduced.

sg893052 · 2022-07-08T05:59:22Z

@yxieca I have created a new PR post resolving the conflict to be merged to 202205 branch. Thanks!
#2261

What I did show command support for System Ready Feature Implementation . Also sonic-package-manager support for app readiness. "show system-health sysready-status" "show system-health sysready-status detail" "show system-health sysready-status brief" How I did it Introduce "show system-health sysready-status" click CLI with options. How to verify it Check the click CLIs introduced.

This reverts commit a6404b7.

Yuval-Mellanox · 2022-10-27T14:28:35Z

@sg893052 When do you expect to merge it?
if no plans please remove the show cli part from the HLD.

sg893052 mentioned this pull request Oct 1, 2021

SYSTEM READY sonic-net/SONiC#875

Merged

sg893052 force-pushed the SYSTEM_READY branch from a488880 to 68a3d1f Compare October 4, 2021 12:43

sg893052 force-pushed the SYSTEM_READY branch from 68a3d1f to 201203d Compare October 27, 2021 05:42

sg893052 force-pushed the SYSTEM_READY branch from 201203d to 5b9ff62 Compare November 5, 2021 12:48

venkatmahalingam previously approved these changes Nov 10, 2021

View reviewed changes

liat-grozovik reviewed Nov 11, 2021

View reviewed changes

sg893052 dismissed venkatmahalingam’s stale review via 434fcf2 April 6, 2022 08:58

sg893052 force-pushed the SYSTEM_READY branch from 5b9ff62 to 434fcf2 Compare April 6, 2022 08:58

sg893052 mentioned this pull request Apr 6, 2022

SYSTEM READY sonic-net/SONiC#977

Merged

sg893052 force-pushed the SYSTEM_READY branch from 434fcf2 to 288b748 Compare April 25, 2022 14:33

sg893052 force-pushed the SYSTEM_READY branch 3 times, most recently from f609301 to 7e0529d Compare April 30, 2022 08:07

sg893052 force-pushed the SYSTEM_READY branch 2 times, most recently from 9a8efea to 48a468d Compare April 30, 2022 08:43

show commands for system ready and application extension package app …

bdbfe85

…ready support

sg893052 force-pushed the SYSTEM_READY branch from 48a468d to bdbfe85 Compare April 30, 2022 09:04

saiarcot895 reviewed May 16, 2022

View reviewed changes

scripts/sysreadyshow Outdated Show resolved Hide resolved

saiarcot895 reviewed May 16, 2022

View reviewed changes

sonic_package_manager/service_creator/feature.py Show resolved Hide resolved

lizhuhuams reviewed May 16, 2022

View reviewed changes

sg893052 dismissed Junchao-Mellanox’s stale review via f8619a1 May 17, 2022 07:23

sg893052 force-pushed the SYSTEM_READY branch from f8619a1 to 3466dd2 Compare May 17, 2022 07:28

Address new comments

86e3aea

sg893052 force-pushed the SYSTEM_READY branch from 3466dd2 to 86e3aea Compare May 17, 2022 07:30

Merge branch 'master' into SYSTEM_READY

350cf66

sujinmkang approved these changes May 20, 2022

View reviewed changes

sujinmkang merged commit 494dd62 into sonic-net:master May 20, 2022

dprital mentioned this pull request May 25, 2022

[submodule] Update sonic-utilities submodule sonic-net/sonic-buildimage#10928

Closed

6 tasks

This was referenced Jun 9, 2022

[submodule] Update sonic-utilities submodule ayurkiv-nvda/sonic-buildimage#22

Closed

[submodule] Update sonic-utilities submodule sonic-net/sonic-buildimage#11103

Closed

sujinmkang added the Request for 202205 Branch label Jul 1, 2022

yxieca added the Cherry Pick Conflict_202205 label Jul 5, 2022

yxieca removed the Request for 202205 Branch label Jul 17, 2022

yxieca added a commit that referenced this pull request Jul 22, 2022

Revert "show commands for SYSTEM READY (#1851) (#2261)"

dc5c492

This reverts commit a6404b7.

yxieca added a commit that referenced this pull request Jul 22, 2022

Revert "show commands for SYSTEM READY (#1851) (#2261)" (#2274)

886f612

This reverts commit a6404b7.

Conversation

sg893052 commented Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

ghost commented Oct 1, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Oct 1, 2021

Uh oh!

lgtm-com bot commented Oct 4, 2021

Uh oh!

lgtm-com bot commented Oct 27, 2021

Uh oh!

Kalimuthu-Velappan commented Oct 27, 2021

Uh oh!

venkatmahalingam commented Nov 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Nov 5, 2021

Uh oh!

sg893052 commented Nov 5, 2021

Uh oh!

liat-grozovik left a comment

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Apr 6, 2022

Uh oh!

lgtm-com bot commented Apr 25, 2022

Uh oh!

lgtm-com bot commented Apr 30, 2022

Uh oh!

lgtm-com bot commented Apr 30, 2022

Uh oh!

lgtm-com bot commented Apr 30, 2022

Uh oh!

Uh oh!

Uh oh!

lizhuhuams left a comment

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented May 17, 2022

Uh oh!

sg893052 commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented May 20, 2022

Uh oh!

yxieca commented Jul 5, 2022

Uh oh!

sg893052 commented Jul 6, 2022

Uh oh!

yxieca commented Jul 7, 2022

Uh oh!

sg893052 commented Jul 8, 2022

Uh oh!

Yuval-Mellanox commented Oct 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

sg893052 commented Oct 1, 2021 •

edited

Loading

ghost commented Oct 1, 2021 •

edited by ghost

Loading

venkatmahalingam commented Nov 2, 2021 •

edited

Loading

sg893052 commented May 17, 2022 •

edited

Loading