SONIC broadcast, unknown-unicast and unknown-multicast (BUM) storm-control HLD by mohan-selvaraj · Pull Request #441 · sonic-net/SONiC

mohan-selvaraj · 2019-08-16T18:58:43Z

…oadcast, unknown-unicast and unknown-multicast storm-control feature in SONiC

PR Tracking Table

Repo	PR title	State
sonic-swss	Orchestration Agent changes for BUM Storm-Control
sonic-utilities	CLI changes for BUM Storm-Control
sonic-swss-common	CONFIG_DB Table changes for BUM Storm-Control
sonic-swss-common	STATE_DB Table changes for BUM Storm-Control

…oadcast, unknown-unicast and unknown-multicast storm-control feature in SONiC

msftclas · 2019-08-16T18:58:57Z

All CLA requirements met.

…ntrol HLD

lguohan · 2021-04-06T15:30:05Z

doc/bum_storm_control/bum_storm_control_hld.md

+
+### 3.2.1 CONFIG_DB
+A new table CFG_PORT_STORM_CONTROL_TABLE is introduced in the configuration database for the purpose of storing storm-control configuration parameters. This table is filled by the management framework. 
+#### CFG_PORT_STORM_CONTROL_TABLE


missing yang model

sonic-net/sonic-buildimage#7355

Please correct the table name as PORT_STORM_CONTROL and use "|" has key separators in config-DB.

Updated Table Name.

lguohan · 2021-05-12T21:34:51Z

@prsunny to review

doc/bum_storm_control/bum_storm_control_hld.md

venkatmahalingam · 2021-05-13T00:08:53Z

doc/bum_storm_control/bum_storm_control_hld.md

+BUM storm control 
+- Configuration is not supported on VLAN and port-channel interfaces. User can configure on physical port which is part of a VLAN / port-channel.
+- Statistics is not supported. 
+- User is expected to remove all storm-control configurations from interface before doing a breakout from Click CLI. 


I think, we do force delete configs during breakout..right?

Yes. will remove this comment. breakout to be handled in code.

venkatmahalingam · 2021-05-13T00:09:42Z

doc/bum_storm_control/bum_storm_control_hld.md

+
+__Figure 1: Storm Control High Level Architecture__
+
+1) Storm-control configurations are parsed and stored in CFG_PORT_STORM_CONTROL_TABLE in Configuration database by the Management Framework.


Update this section to capture SONiC CLI update as well.

The flow from CONFIG_DB update to backend is already captured.

venkatmahalingam · 2021-05-13T00:14:05Z

doc/bum_storm_control/bum_storm_control_hld.md

+This section lists down the Click commands.
+BUM storm-control can be configured only on physical interfaces.  
+**switch# config interface storm-control {broadcast | unknown-unicast | unknown-multicast} {add|del} \<interface_name\> {\<kilo_bits_per_second\>}**
+


Suggest to change the SONiC CLI command as follows,
config interface storm-control { add | del } {broadcast | unknown-unicast | unknown-multicast} <kilo_bits_per_second>

storm-control policer types are keywords. add/del are operations. Keywords are kept in the beginning of the command.
user might want to know the type before performing the operation.

venkatmahalingam · 2021-05-13T00:15:36Z

doc/bum_storm_control/bum_storm_control_hld.md

+### 3.5.3 Show Commands
+The following show command displays storm-control configurations. 
+
+**show storm-control {all | interface \<interface_name\>}**


Suggest to use the following format,
show storm-control [interface <interface_name>]

zhangyanzhao · 2021-10-12T16:49:21Z

Can we add the code PRs by referring to #806 ?
@mohan-selvaraj

mdivyamohan · 2021-10-12T19:25:40Z

doc/bum_storm_control/bum_storm_control_hld.md

+
+### 1.1.1 Functional Requirements
+ 1. Support configuration of Broadcast, Unknown-unicast and unknown-Multicast storm-control independently on physical interfaces.
+ 2. Support threshold rate configuration in kilo bits per second (kbps) in the range of 0 kbps to 100,000,000 kbps (100Gbps). 


Could unit packets per second (pps) also supported along with kilo bits per second (kbps).

Will try to accomodate the change in the future.

zhangyanzhao · 2021-10-26T15:43:17Z

@mohan-selvaraj would you please update the code PRs by following template of #806 ? Thanks.

adyeung · 2021-11-04T22:30:39Z

@zhangyanzhao Review is done, pls help push for merge

stephenxs · 2025-04-08T05:01:32Z

doc/bum_storm_control/bum_storm_control_hld.md

+| CIR (bps)                | SAI_POLICER_ATTR_CIR                                   |
+| Unknown-unicast policer  | SAI_PORT_ATTR_FLOOD_STORM_CONTROL_POLICER_ID           |
+| Broadcast policer        | SAI_PORT_ATTR_BROADCAST_STORM_CONTROL_POLICER_ID       |
+| Unknown-Multicast policer| SAI_PORT_ATTR_MULTICAST_STORM_CONTROL_POLICER_ID       |


Hi
This policer types doesn't seem accurate...
According to SAI attribute definition,

SAI_PORT_ATTR_FLOOD_STORM_CONTROL_POLICER_ID represents unknown unicast and multicast instead of unknown unicast

SAI_PORT_ATTR_MULTICAST_STORM_CONTROL_POLICER_ID represents known multicast instead of unknown multicast.

Should we adjust the CLI according to the SAI attribute definition?

This document describes the functionality and high level desigh of br…

1e05640

…oadcast, unknown-unicast and unknown-multicast storm-control feature in SONiC

mohan-selvaraj changed the title ~~This document describes the functionality and high level desigh of br…~~ SONIC broadcast, unknown-unicast and unknown-multicast storm-control HLD Aug 19, 2019

mohan-selvaraj changed the title ~~SONIC broadcast, unknown-unicast and unknown-multicast storm-control HLD~~ SONIC broadcast, unknown-unicast and unknown-multicast (BUM) storm-control HLD Aug 19, 2019

SONIC broadcast, unknown-unicast and unknown-multicast (BUM) storm-co…

9819493

…ntrol HLD

mohan-selvaraj mentioned this pull request Jul 10, 2020

Broadcast Unknown-multicast and Unknown-unicast Storm-control sonic-net/sonic-swss#1306

Merged

lguohan reviewed Apr 6, 2021

View reviewed changes

Updated few of the comments based on HLD review

453ca2a

venkatmahalingam reviewed May 13, 2021

View reviewed changes

doc/bum_storm_control/bum_storm_control_hld.md Show resolved Hide resolved

venkatmahalingam reviewed May 13, 2021

View reviewed changes

doc/bum_storm_control/bum_storm_control_hld.md Outdated Show resolved Hide resolved

venkatmahalingam reviewed May 13, 2021

View reviewed changes

mohan-selvaraj added 2 commits August 2, 2021 05:33

update config DB table name and key separator

f619c03

Update revision number and date, supported configuration modes

7f22539

mdivyamohan reviewed Oct 12, 2021

View reviewed changes

Updated statement on breakout handling. Minor correction.

11d5eb5

venkatmahalingam approved these changes Nov 4, 2021

View reviewed changes

zhangyanzhao merged commit decc8eb into sonic-net:master Nov 9, 2021

stephenxs reviewed Apr 8, 2025

View reviewed changes


		__Figure 1: Storm Control High Level Architecture__

		1) Storm-control configurations are parsed and stored in CFG_PORT_STORM_CONTROL_TABLE in Configuration database by the Management Framework.

Conversation

mohan-selvaraj commented Aug 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msftclas commented Aug 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan commented May 12, 2021

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhangyanzhao commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhangyanzhao commented Oct 26, 2021

Uh oh!

adyeung commented Nov 4, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mohan-selvaraj commented Aug 16, 2019 •

edited

Loading

msftclas commented Aug 16, 2019 •

edited

Loading

zhangyanzhao commented Oct 12, 2021 •

edited

Loading