Disable pfcwd forward action config for cisco-8000.#1848
Merged
neethajohn merged 1 commit intosonic-net:202012from Sep 30, 2021
alpeshspatel:alpesh/cisco-8000-pfcwd-forward
Merged
Disable pfcwd forward action config for cisco-8000.#1848neethajohn merged 1 commit intosonic-net:202012from alpeshspatel:alpesh/cisco-8000-pfcwd-forward
neethajohn merged 1 commit intosonic-net:202012from
alpeshspatel:alpesh/cisco-8000-pfcwd-forward
Conversation
Do not configure pfcwd if pfc is not configured on a port Signed-off-by: Alpesh S Patel <alpesh@cisco.com>
neethajohn
approved these changes
Sep 30, 2021
Contributor
Author
|
@neethajohn Can you please double commit/cherry-pick to the master branch as well. |
Contributor
Author
|
@neethajohn Once you merge this in master, what is the process/cadence of putting that in azure sonic-buildimage/master. |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
d29a49a [ACL] Match TCP protocol while matching TCP_FLAG (sonic-net#1854) 2569ad9 Fix sFlow sampling-rate and admin-state (sonic-net#1728) 8908a8f Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net#1848) b42c2fb [VS Test] Skip flaky tests (sonic-net#1875) Signed-off-by: bingwang <bingwang@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
* 647f01f 2021-09-30 | [fstrim] limit smartctl execution time to 30 seconds (sonic-net#1850) (HEAD -> 202012, github/202012) [Ying Xie] * 371970e 2021-09-30 | [202012][show techsupport] address show techsupport return none zero code issue (sonic-net#1847) [Ying Xie] * 81a8386 2021-09-30 | Disable pfcwd forward action config for cisco-8000. (sonic-net#1848) [Alpesh Patel] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in association with: sonic-net/sonic-swss#1748 where PFC-WD forward action is disabled for cisco-8000 platform.
Signed-off-by: Alpesh S Patel alpesh@cisco.com
What I did
There are two changes of interest:
and subsequently pfcwd is configured, swss/orchagent throws an error logs
How I did it
How to verify it
for atleast 1 port.
without this change, see the logs in syslog. With this change, there will just be a log on console.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)