[202012][show techsupport] address show techsupport return none zero code issue#1847
Merged
yxieca merged 1 commit intosonic-net:202012from Oct 1, 2021
Merged
[202012][show techsupport] address show techsupport return none zero code issue#1847yxieca merged 1 commit intosonic-net:202012from
yxieca merged 1 commit intosonic-net:202012from
Conversation
…code issue Some bash syntax is correct without error handler on $?. With the error handler, they need to use different syntax to avoid false positives. Signed-off-by: Ying Xie <[email protected]>
lguohan
approved these changes
Oct 1, 2021
praveen-li
pushed a commit
to praveen-li/sonic-utilities
that referenced
this pull request
Feb 8, 2022
…code issue (sonic-net#1847) What I did Some bash syntax is correct without error handler on $?. With the error handler, they need to use different syntax to avoid false positives. How I did it Update bash syntax. How to verify it tested with show techsuppor test. Signed-off-by: Ying Xie [email protected] Signed-off-by: Sangita Maity <[email protected]> RB=2916738 G=lnos-reviewers R=pchaudhary,pmao,stexu,samaity,zxu A=stexu
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
* 647f01f 2021-09-30 | [fstrim] limit smartctl execution time to 30 seconds (sonic-net#1850) (HEAD -> 202012, github/202012) [Ying Xie] * 371970e 2021-09-30 | [202012][show techsupport] address show techsupport return none zero code issue (sonic-net#1847) [Ying Xie] * 81a8386 2021-09-30 | Disable pfcwd forward action config for cisco-8000. (sonic-net#1848) [Alpesh Patel] Signed-off-by: Ying Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Some bash syntax is correct without error handler on $?. With the error handler, they need to use different syntax to avoid false positives.
How I did it
Update bash syntax.
How to verify it
tested with show techsuppor test.
Signed-off-by: Ying Xie [email protected]