Skip to content

Disable pfcwd forward action config for cisco-8000. #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neethajohn merged 1 commit into from
Sep 30, 2021
Merged

Disable pfcwd forward action config for cisco-8000. #1848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pfcwd/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from tabulate import tabulate
from utilities_common import multi_asic as multi_asic_util
from utilities_common import constants
from sonic_py_common import logger
from sonic_py_common import device_info, logger

SYSLOG_IDENTIFIER = "config"

Expand Down Expand Up @@ -59,6 +59,7 @@

CONFIG_DB_PFC_WD_TABLE_NAME = 'PFC_WD'
PORT_QOS_MAP = "PORT_QOS_MAP"
UNSUPPORTED_FORWARD_ACTION_ASICS = ["cisco-8000"]

# Main entrypoint
@click.group()
Expand Down Expand Up @@ -117,6 +118,8 @@ def __init__(
)
self.table = []
self.all_ports = []
version_info = device_info.get_sonic_version_info()
self.asic_type = version_info.get('asic_type')

@multi_asic_util.run_on_multi_asic
def collect_stats(self, empty, queues):
Expand Down Expand Up @@ -250,7 +253,7 @@ def start(self, action, restoration_time, ports, detection_time):

def verify_pfc_enable_status_per_port(self, port, pfcwd_info):
pfc_status = self.config_db.get_entry(PORT_QOS_MAP, port).get('pfc_enable')
if pfc_status is None:
if pfc_status is None or pfc_status == "":
log.log_warning("SKIPPED: PFC is not enabled on port: {}".format(port), also_print_to_console=True)
return

Expand All @@ -274,6 +277,10 @@ def start_cmd(self, action, restoration_time, ports, detection_time):
if len(ports) == 0:
ports = all_ports

if action == 'forward' and self.asic_type in UNSUPPORTED_FORWARD_ACTION_ASICS:
log.log_warning("SKIPPED: PFC WD 'forward' action not supported on asic '{}'".format(self.asic_type), also_print_to_console=True)
return

pfcwd_info = {
'detection_time': detection_time,
}
Expand Down