[config] Add EXP-to-TC map to clear_qos#1875
Conversation
|
HLD: sonic-net/SONiC#844 |
abdosi
left a comment
abdosi
left a comment
There was a problem hiding this comment.
This is not matching design document. https://github.com/Azure/SONiC/pull/844/files
It is define as CFG_MPLS_TC_TO_TC_MAP_TABLE_NAME in design doc.
Fixed |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
can we add unit test case to cover cases ? What happens if there is no MPLS EXP table and we do clear qos ? To make sure this change is backward compatible |
This reverts commit 74a0221.
|
Added to qos reload test (which covers the clear_qos command) |
what happens if there is no MPLS EXP table and we do clear qos ? |
Same as all the other tables - will just have no effect |
|
I've changed the tests so that only 1 of them (the non-multi-ASIC) includes the new map, so that tests clearing qos when no EXP-TC map is set |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
d29a49a [ACL] Match TCP protocol while matching TCP_FLAG (sonic-net#1854) 2569ad9 Fix sFlow sampling-rate and admin-state (sonic-net#1728) 8908a8f Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net#1848) b42c2fb [VS Test] Skip flaky tests (sonic-net#1875) Signed-off-by: bingwang <[email protected]>
3 participants
What I did
Added EXP to TC map to tables affected by clear_qos command
How I did it
Found references to DSCP to TC map, added EXP to TC map in same place
How to verify it
Run clear_qos with EXP to TC map present
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)