Add NEIGHBOR_MISS trap type and its own queue#3646
Closed
msherif1234 wants to merge 1 commit intosonic-net:masterfrom
Closed
Add NEIGHBOR_MISS trap type and its own queue#3646msherif1234 wants to merge 1 commit intosonic-net:masterfrom
msherif1234 wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Mohamed S. Mahmoud <mmahmoud2201@gmail.com>
The committers listed above are authorized under a signed CLA. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@msherif1234 we already have a PR for this. #3624 |
Contributor
|
@prsunny @msherif1234 This seems to be a duplicate of #3624. |
Author
yeah sorry didn't notice the open PR I will close mine Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add new trap type
SAI_HOSTIF_TRAP_TYPE_NEIGHBOR_MISSand dedicated queueto better control those punt packets and not impact other critical punt traffic
Why I did it
As proposed in https://github.com/sonic-net/SONiC/blob/1fba16368a803bfeea57d93e8e39b3bcdcc3a67d/doc/copp/Copp_Neighbor_Miss_Trap_And_Enhancements.md we wanted to protect cpu from being hogged with neighbor miss packets
How I verified it
Details if related