Skip to content

sonic-sairedis : Wred stats feature changes on Sai-redis and Syncd#1234

Merged
kcudnik merged 1 commit intosonic-net:masterfrom
rpmarvell:rpmarvell_wredstats_sairedis
Feb 4, 2025
Merged

sonic-sairedis : Wred stats feature changes on Sai-redis and Syncd#1234
kcudnik merged 1 commit intosonic-net:masterfrom
rpmarvell:rpmarvell_wredstats_sairedis

Conversation

@rpmarvell
Copy link
Contributor

@rpmarvell rpmarvell commented Apr 24, 2023 •
edited
Loading

  • Stats capability query API support is added

Details :

  • Changes are done to support the stats capability query from Swss to SAI.
  • This was implemented as part of WRED and ECN statistics
  • Statistics capability query is implemented in sairedis/syncd

HLD : https://github.com/sonic-net/SONiC/blob/master/doc/qos/ECN_and_WRED_statistics_HLD.md

Expected order of pull-request commits :

  1. sonic-swss common pull request : swss-common: WRED and ECN statistics specific changes sonic-swss-common#777
  2. sonic-yang-model pull requests : sonic-yang-models: WRED statistics yang sonic-buildimage#14758
  3. sonic-sairedis pull request : sonic-sairedis : Wred stats feature changes on Sai-redis and Syncd #1234
  4. sonic-swss : pull request : sonic-swss: Code changes for WRED and ECN statistics sonic-swss#2750
  5. sonic-utilities pull request : sonic-utilities: WRED stats feature changes on sonic-utilities sonic-utilities#2807

This was referenced Apr 25, 2023
Merged
Merged
@rpmarvell rpmarvell force-pushed the rpmarvell_wredstats_sairedis branch from d8bbe32 to 5da8294 Compare April 25, 2023 16:40
@rpmarvell rpmarvell mentioned this pull request Apr 26, 2023
Merged
10 tasks
@rpmarvell rpmarvell force-pushed the rpmarvell_wredstats_sairedis branch from 5da8294 to 838bc2e Compare May 1, 2023 08:06
@kcudnik
Copy link
Collaborator

kcudnik commented May 4, 2023

please fix errors

@rpmarvell
Copy link
Contributor Author

rpmarvell commented May 4, 2023

This PR is dependent on swss-common PR 777 as i have mentioned in the description. Hence the errors. Could you please review and approve the swss-common PR if possible..! Thank you

msosyak
msosyak previously approved these changes May 8, 2023
View reviewed changes
@rpmarvell rpmarvell mentioned this pull request May 9, 2023
Merged
stephenxs
stephenxs reviewed May 25, 2023
View reviewed changes
@rpmarvell rpmarvell force-pushed the rpmarvell_wredstats_sairedis branch from 838bc2e to 8d57f14 Compare May 29, 2023 10:15
@kcudnik
Copy link
Collaborator

kcudnik commented May 29, 2023

please fix build errors

@rpmarvell
Copy link
Contributor Author

rpmarvell commented May 29, 2023

please fix build errors

sonic-sairedis is dependent on sonic-swss-common PR https://github.com/sonic-net/sonic-swss-common/pull/777 .
This sonic-swss-common PR has already been approved by maintainer but we are facing issues in merging this PR as the CI is unstable.
There is an issue raised for this in the SONiC community by Myron Sosyak, Link for this issue : sonic-net/sonic-swss-common#784

@stephenxs
Copy link
Contributor

stephenxs commented May 30, 2023

Hi @rpmarvell
Please refer to my latest comment. I'm not able to unresolve a comment
Thanks

@akokhan
Copy link
Contributor

akokhan commented May 31, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 31, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@akokhan
Copy link
Contributor

akokhan commented Jun 2, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 2, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@akokhan
Copy link
Contributor

akokhan commented Jun 2, 2023

@rpmarvell , even swss-common changes are merged, sairedis CI is still failing. Please check.

@rpmarvell rpmarvell force-pushed the rpmarvell_wredstats_sairedis branch from 8d57f14 to 6b6d297 Compare June 3, 2023 17:37
@rpmarvell
Copy link
Contributor Author

rpmarvell commented Jun 3, 2023

Hi @rpmarvell Please refer to my latest comment. I'm not able to unresolve a comment Thanks

I have addressed your review comment. Thank you!

@rpmarvell rpmarvell force-pushed the rpmarvell_wredstats_sairedis branch 8 times, most recently from 68b4d42 to 380553f Compare June 4, 2023 10:31
@azure-pipelines
Copy link

azure-pipelines bot commented Jan 22, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 22, 2025

this is being handled here: #1502

@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 22, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 22, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 22, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 22, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 23, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 27, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 27, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@rpmarvell
Copy link
Contributor Author

rpmarvell commented Jan 27, 2025

address comments

I have addressed the comments.

@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 31, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 31, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@kperumalbfn
Copy link

kperumalbfn commented Feb 3, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 3, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@rpmarvell
sonic-sairedis : Wred stats feature changes on Sai-redis and Syncd
7e6f7fe 
* Stats capability query API support is added
* Marvell VS support for query stats capability added

Signed-off-by: rpmarvell <rperumal@marvell.com>
@mssonicbld
Copy link
Collaborator

mssonicbld commented Feb 4, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 4, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@rpmarvell
Copy link
Contributor Author

rpmarvell commented Feb 4, 2025

@kcudnik : Tests are green. Could you please help with pushing/merging the changes.

This was referenced Feb 7, 2025
Merged
Merged
@r12f
Copy link
Contributor

r12f commented Feb 21, 2025

hi @rpmarvell , do you mind to help create a manual PR for this cherry pick?

202412 branch is in: https://github.com/Azure/sonic-sairedis.msft.

@r12f
Copy link
Contributor

r12f commented Feb 24, 2025 •
edited
Loading

hi @rpmarvell , gently ping on this one again. It is currently blocking this PR at this moment: #1457.

@r12f r12f mentioned this pull request Feb 28, 2025
Closed
@mssonicbld mssonicbld mentioned this pull request Feb 28, 2025
Merged
@r12f
Copy link
Contributor

r12f commented Feb 28, 2025

hi @rpmarvell , do you mind to help create a manual PR for this cherry pick?

202412 branch is in: https://github.com/Azure/sonic-sairedis.msft.

This was referenced Feb 28, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenxs stephenxs stephenxs approved these changes

@kcudnik kcudnik kcudnik approved these changes

@msosyak msosyak Awaiting requested review from msosyak

Assignees

No one assigned

Labels

Approved for msft-202412 Branch Included in msft-202412 Branch Request for msft-202412 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@rpmarvell @kcudnik @stephenxs @akokhan @zhangyanzhao @kperumalbfn @mssonicbld @r12f @msosyak @dprital