Fixing the sairedis build issue caused at https://github.com/sonic-ne…

[rpmarvell]

Why did i do this change ?
To fix the Build break mentioned at sonic-net/sonic-buildimage#21614

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kcudnik]

why not revert previous change ?

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rpmarvell]

I have removed the MOCK test which caused the error.

[kcudnik]

you als ohave this:

In file included from AttrKeyMap.cpp:3:
sai_serialize.h:76:20: error: 'sai_prefix_compression_entry_t' does not name a type
   76 |         _In_ const sai_prefix_compression_entry_t &prefix_compression_entry);
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sai_serialize.h:459:15: error: 'sai_prefix_compression_entry_t' has not been declared
  459 |         _Out_ sai_prefix_compression_entry_t& prefix_compression_entry);
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[4]: *** [Makefile:729: libsaimeta_la-AttrKeyMap.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
In file included from Globals.cpp:3:
sai_serialize.h:76:20: error: 'sai_prefix_compression_entry_t' does not name a type
   76 |         _In_ const sai_prefix_compression_entry_t &prefix_compression_entry);
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sai_serialize.h:459:15: error: 'sai_prefix_compression_entry_t' has not been declared
  459 |         _Out_ sai_prefix_compression_entry_t& prefix_compression_entry);
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

since you are downgrading SAI from master to 15.4 that prefix entry don't exists, and it will pull cascade removal of apis in source code because of non existient definitions and types

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rpmarvell]

@kcudnik : I have removed the issue causing Mock method and restarted the build at sonic-net/sonic-buildimage#21685 . Once it is completed successfully , we should be able to go ahead with the merge for this PR.

[kcudnik]

you removed just unittests here, how come this was passing on sairedis repo and not on buildimage ?

[rpmarvell]

I have removed the test which caused the failure. it fixed the build "Azure.sonic-buildimage (BuildVS vs)". But there are other failures at sonic-buildimage repo, which i am not able to link with my changes.

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kperumalbfn]

@kcudnik Could you pls merge this?

[r12f]

hi @rpmarvell , do you mind helping us create the manual cherry pick change to 202412: https://github.com/Azure/sonic-sairedis.msft.

[r12f]

This PR is dependent on #1234

[kperumalbfn]

hi @rpmarvell , do you mind helping us create the manual cherry pick change to 202412: https://github.com/Azure/sonic-sairedis.msft.

@rpmarvell Could you please create a PR to 202412 branch. Looks like we have cherry pick conflict that is blocking to do auto merge this.

[mssonicbld]

Cherry-pick PR to msft-202412: Azure/sonic-sairedis.msft#33